need debugging help

need debugging help

[Chander Kant]

[-- Attachment #1: Type: text/plain, Size: 1355 bytes --]


Thanks Andrew. I am moving the discussion to the acpi-devel list:

All,

I am attaching the output of "iasl -d dsdt" (in zipped format).

Please let me know if we can do anything on this system to get rid of the problem mentioned below.

Thanks,
Chander


"Grover, Andrew" <andrew.grover-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org> wrote ..
> > When we bring up a recent Linux kernel (2.4.20) with ACPI 
> > patch on our laptop. We get following error messages 
> > continously from the kernel:
> > 
> > Jul  2 04:31:16 localhost kernel:     ACPI-1103: *** Error: 
> > Method execution failed [\_SB_.PCI0.SBRG.EC0_._Q1E] (Node 
> > c33b1380), AE_AML_REGION_LIMIT
> > 
> > Besides filling up the log files, and making the console 
> > windows, I think it is also hampering ACPI functionality to 
> > work, as I do not see and battery file in the /proc/acpi directory.
> > 
> > I have seen other folks in user groups and lists getting 
> > these errors, but so far I have not seen a good response as 
> > far as a fix or workaround.
> 
> It's most likely an AML error. This particular error is not uncommon.
> 
> Do you have the ASL for this machine? If not, get iasl from
> http://developer.intel.com/technology/iapc/acpi/downloads.htm and feed
> your DSDT into it (from /proc/acpi/dsdt). with the -d option. Then, go
> take a look at the _Q1E method.
> 
> 

[-- Attachment #2: dsdt.dsl.gz --]
[-- Type: application/x-gzip, Size: 11329 bytes --]

RE: need debugging help

[Chander Kant]

Unfortunately I don't have a way of changing the System BIOS. Can you 
please provide a link to the patch you mention below, and any instructions 
on how to apply it.

thanks

At 05:04 PM 13/07/2003 -0700, Grover, Andrew wrote:
>Hi, sorry for the delay.
>
>So do you have the ability to change your systems' BIOS? If so it is an
>easy fix. If not, then there is a Relaced AML patch to workaround this
>issue, but the ideal situation would be to fix the firmware.
>
>Regards -- Andy
>
> > -----Original Message-----
> > From: Chander Kant [mailto:ck-cFQ2QR18kktMdczFR1vadtBPR1lH4CV8@public.gmane.org]
> > Sent: Tuesday, July 01, 2003 5:13 PM
> > To: acpi-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org
> > Cc: Grover, Andrew; ck-cFQ2QR18kktMdczFR1vadtBPR1lH4CV8@public.gmane.org
> > Subject: need debugging help
> >
> >
> >
> > Thanks Andrew. I am moving the discussion to the acpi-devel list:
> >
> > All,
> >
> > I am attaching the output of "iasl -d dsdt" (in zipped format).
> >
> > Please let me know if we can do anything on this system to
> > get rid of the problem mentioned below.
> >
> > Thanks,
> > Chander
> >
> >
> > "Grover, Andrew" <andrew.grover-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org> wrote ..
> > > > When we bring up a recent Linux kernel (2.4.20) with ACPI
> > > > patch on our laptop. We get following error messages
> > > > continously from the kernel:
> > > >
> > > > Jul  2 04:31:16 localhost kernel:     ACPI-1103: *** Error:
> > > > Method execution failed [\_SB_.PCI0.SBRG.EC0_._Q1E] (Node
> > > > c33b1380), AE_AML_REGION_LIMIT
> > > >
> > > > Besides filling up the log files, and making the console
> > > > windows, I think it is also hampering ACPI functionality to
> > > > work, as I do not see and battery file in the /proc/acpi
> > directory.
> > > >
> > > > I have seen other folks in user groups and lists getting
> > > > these errors, but so far I have not seen a good response as
> > > > far as a fix or workaround.
> > >
> > > It's most likely an AML error. This particular error is not
> > uncommon.
> > >
> > > Do you have the ASL for this machine? If not, get iasl from
> > >
> > http://developer.intel.com/technology/iapc/acp> i/downloads.htm and
>feed
> > > your DSDT into it (from /proc/acpi/dsdt). with the -d
> > option. Then, go
> > > take a look at the _Q1E method.
> > >
> > >
> >



-------------------------------------------------------
This SF.Net email sponsored by: Parasoft
Error proof Web apps, automate testing & more.
Download & eval WebKing and get a free book.
www.parasoft.com/bulletproofapps1

RE: need debugging help

[Grover, Andrew]

Hi, sorry for the delay.

So do you have the ability to change your systems' BIOS? If so it is an
easy fix. If not, then there is a Relaced AML patch to workaround this
issue, but the ideal situation would be to fix the firmware.

Regards -- Andy

> -----Original Message-----
> From: Chander Kant [mailto:ck-cFQ2QR18kktMdczFR1vadtBPR1lH4CV8@public.gmane.org] 
> Sent: Tuesday, July 01, 2003 5:13 PM
> To: acpi-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org
> Cc: Grover, Andrew; ck-cFQ2QR18kktMdczFR1vadtBPR1lH4CV8@public.gmane.org
> Subject: need debugging help
> 
> 
> 
> Thanks Andrew. I am moving the discussion to the acpi-devel list:
> 
> All,
> 
> I am attaching the output of "iasl -d dsdt" (in zipped format).
> 
> Please let me know if we can do anything on this system to 
> get rid of the problem mentioned below.
> 
> Thanks,
> Chander
> 
> 
> "Grover, Andrew" <andrew.grover-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org> wrote ..
> > > When we bring up a recent Linux kernel (2.4.20) with ACPI 
> > > patch on our laptop. We get following error messages 
> > > continously from the kernel:
> > > 
> > > Jul  2 04:31:16 localhost kernel:     ACPI-1103: *** Error: 
> > > Method execution failed [\_SB_.PCI0.SBRG.EC0_._Q1E] (Node 
> > > c33b1380), AE_AML_REGION_LIMIT
> > > 
> > > Besides filling up the log files, and making the console 
> > > windows, I think it is also hampering ACPI functionality to 
> > > work, as I do not see and battery file in the /proc/acpi 
> directory.
> > > 
> > > I have seen other folks in user groups and lists getting 
> > > these errors, but so far I have not seen a good response as 
> > > far as a fix or workaround.
> > 
> > It's most likely an AML error. This particular error is not 
> uncommon.
> > 
> > Do you have the ASL for this machine? If not, get iasl from
> > 
> http://developer.intel.com/technology/iapc/acp> i/downloads.htm and
feed
> > your DSDT into it (from /proc/acpi/dsdt). with the -d 
> option. Then, go
> > take a look at the _Q1E method.
> > 
> > 
> 


-------------------------------------------------------
This SF.Net email sponsored by: Parasoft
Error proof Web apps, automate testing & more.
Download & eval WebKing and get a free book.
www.parasoft.com/bulletproofapps1

RE: need debugging help

[Grover, Andrew]

[-- Attachment #1: Type: text/plain, Size: 2848 bytes --]

> From: Chander Kant [mailto:ck-cFQ2QR18kktMdczFR1vadtBPR1lH4CV8@public.gmane.org] 
> Unfortunately I don't have a way of changing the System BIOS. Can you 
> please provide a link to the patch you mention below, and any 
> instructions 
> on how to apply it.

This is already in 2.4.22-pre4 and later but if your version doesn't
have it, here it is.

just cd to the toplevel linux src directory, and "cat relaxed.diff
|patch -p1".

Regards -- Andy

> 
> thanks
> 
> At 05:04 PM 13/07/2003 -0700, Grover, Andrew wrote:
> >Hi, sorry for the delay.
> >
> >So do you have the ability to change your systems' BIOS? If 
> so it is an
> >easy fix. If not, then there is a Relaced AML patch to 
> workaround this
> >issue, but the ideal situation would be to fix the firmware.
> >
> >Regards -- Andy
> >
> > > -----Original Message-----
> > > From: Chander Kant [mailto:ck-cFQ2QR18kktMdczFR1vadtBPR1lH4CV8@public.gmane.org]
> > > Sent: Tuesday, July 01, 2003 5:13 PM
> > > To: acpi-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org
> > > Cc: Grover, Andrew; ck-cFQ2QR18kktMdczFR1vadtBPR1lH4CV8@public.gmane.org
> > > Subject: need debugging help
> > >
> > >
> > >
> > > Thanks Andrew. I am moving the discussion to the acpi-devel list:
> > >
> > > All,
> > >
> > > I am attaching the output of "iasl -d dsdt" (in zipped format).
> > >
> > > Please let me know if we can do anything on this system to
> > > get rid of the problem mentioned below.
> > >
> > > Thanks,
> > > Chander
> > >
> > >
> > > "Grover, Andrew" <andrew.grover-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org> wrote ..
> > > > > When we bring up a recent Linux kernel (2.4.20) with ACPI
> > > > > patch on our laptop. We get following error messages
> > > > > continously from the kernel:
> > > > >
> > > > > Jul  2 04:31:16 localhost kernel:     ACPI-1103: *** Error:
> > > > > Method execution failed [\_SB_.PCI0.SBRG.EC0_._Q1E] (Node
> > > > > c33b1380), AE_AML_REGION_LIMIT
> > > > >
> > > > > Besides filling up the log files, and making the console
> > > > > windows, I think it is also hampering ACPI functionality to
> > > > > work, as I do not see and battery file in the /proc/acpi
> > > directory.
> > > > >
> > > > > I have seen other folks in user groups and lists getting
> > > > > these errors, but so far I have not seen a good response as
> > > > > far as a fix or workaround.
> > > >
> > > > It's most likely an AML error. This particular error is not
> > > uncommon.
> > > >
> > > > Do you have the ASL for this machine? If not, get iasl from
> > > >
> > > http://developer.intel.com/technology/iapc/acp> 
> i/downloads.htm and
> >feed
> > > > your DSDT into it (from /proc/acpi/dsdt). with the -d
> > > option. Then, go
> > > > take a look at the _Q1E method.
> > > >
> > > >
> > >
> 

[-- Attachment #2: relaxed.diff --]
[-- Type: application/octet-stream, Size: 2132 bytes --]

diff -Nru a/drivers/acpi/Config.in b/drivers/acpi/Config.in
--- a/drivers/acpi/Config.in	Sun Jul 13 17:57:54 2003
+++ b/drivers/acpi/Config.in	Sun Jul 13 17:57:54 2003
@@ -37,6 +37,7 @@
       tristate     '  ASUS Laptop Extras'  CONFIG_ACPI_ASUS
       tristate     '  Toshiba Laptop Extras'	CONFIG_ACPI_TOSHIBA
       bool         '  Debug Statements'	CONFIG_ACPI_DEBUG
+      bool         '  Relaxed AML Checking'	CONFIG_ACPI_RELAXED_AML
     fi
   fi
 
diff -Nru a/drivers/acpi/executer/exfldio.c b/drivers/acpi/executer/exfldio.c
--- a/drivers/acpi/executer/exfldio.c	Sun Jul 13 17:57:54 2003
+++ b/drivers/acpi/executer/exfldio.c	Sun Jul 13 17:57:54 2003
@@ -139,7 +139,41 @@
 			field_datum_byte_offset, obj_desc->common_field.access_byte_width,
 			rgn_desc->region.node->name.ascii, rgn_desc->region.length));
 
-		return_ACPI_STATUS (AE_AML_REGION_LIMIT);
+		#ifdef CONFIG_ACPI_RELAXED_AML
+		{
+			/*
+			 * Allow access to the field if it is within the region size
+			 * rounded up to a multiple of the access byte width.  This
+			 * overcomes "off-by-one" programming errors in the AML often
+			 * found in Toshiba laptops.  These errors were allowed by
+			 * the Microsoft ASL compiler.
+			 */
+			u32 rounded_length = ACPI_ROUND_UP(rgn_desc->region.length,
+									obj_desc->common_field.access_byte_width);
+
+			if (rounded_length < (obj_desc->common_field.base_byte_offset
+						+ field_datum_byte_offset
+						+ obj_desc->common_field.access_byte_width)) {
+				return_ACPI_STATUS (AE_AML_REGION_LIMIT);
+			} else {
+				static int	warn_once = 1;
+				if (warn_once) {
+					// Could also associate a flag with each field, and
+					// warn once for each field.
+					ACPI_REPORT_WARNING((
+						"The ACPI AML in your computer contains errors, "
+						"please nag the manufacturer to correct it.\n"));
+					ACPI_REPORT_WARNING((
+						"Allowing relaxed access to fields; "
+						"turn on CONFIG_ACPI_DEBUG for details.\n"));
+					warn_once = 0;
+				}
+				return_ACPI_STATUS (AE_OK);
+			}
+		}
+		#else
+			return_ACPI_STATUS (AE_AML_REGION_LIMIT);
+		#endif
 	}
 
 	return_ACPI_STATUS (AE_OK);