From: "M. Warner Losh" <imp-uzTCJ5RojNnQT0dZR+AlfA@public.gmane.org>
To: lws-RAHWjsxJnJUdnm+yROfE0A@public.gmane.org
Cc: willy-8fiUuRrzOP0dnm+yROfE0A@public.gmane.org,
acpi-devel-pyega4qmqnRoyOMFzWx49A@public.gmane.org
Subject: Re: [PATCH] Toshiba ACPI Extras 0.16
Date: Sat, 26 Jul 2003 11:18:00 -0600 (MDT) [thread overview]
Message-ID: <20030726.111800.13461649.imp@bsdimp.com> (raw)
In-Reply-To: <20030726132501.C766314829-RAHWjsxJnJUdnm+yROfE0A@public.gmane.org>
So what was wrong with strlcpy? Was strncpy used because trailing
NULs for the length of the field was required? That, and the point
below, are the only differences between two versions of the code
posted.
Also:
strncyp(str2, str, n); str2[n] = '\0';
means that you copy n + 1 bytes into str2, which is typically a bug,
so a comment explaining why it isn't would be in order.
As it is the comment of 'don't even consider using strlcpy' is about
useless because it tells what, but not why. And there's a long
history of people in the Linux world ignoring dictates when the
reasons get lost in the mists of time.
Warner
-------------------------------------------------------
This SF.Net email sponsored by: Free pre-built ASP.NET sites including
Data Reports, E-commerce, Portals, and Forums are available now.
Download today and enter to win an XBOX or Visual Studio .NET.
http://aspnet.click-url.com/go/psa00100003ave/direct;at.aspnet_072303_01/01
next prev parent reply other threads:[~2003-07-26 17:18 UTC|newest]
Thread overview: 47+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <willy@debian.org>
[not found] ` <20020916163335.J10583-+pPCBgu9SkPzIGdyhVEDUDl5KyyQGfY2kSSpQ9I8OhVaa/9Udqfwiw@public.gmane.org>
2002-09-16 16:12 ` 2.5.34? Brad Parker
[not found] ` <200209161612.g8GGCtv24883-paYRYfI9b/YMuHHiPFXXZ1fOaUvyCJUZ@public.gmane.org>
2002-09-17 15:51 ` 2.5.34? Pavel Machek
[not found] ` <20030726052012.GO1485-+pPCBgu9SkPzIGdyhVEDUDl5KyyQGfY2kSSpQ9I8OhVaa/9Udqfwiw@public.gmane.org>
2003-07-26 13:24 ` [PATCH] Toshiba ACPI Extras 0.16 Lyle Seaman
[not found] ` <20030726132501.C766314829-RAHWjsxJnJUdnm+yROfE0A@public.gmane.org>
2003-07-26 17:18 ` M. Warner Losh [this message]
[not found] ` <20030726.111800.13461649.imp-uzTCJ5RojNnQT0dZR+AlfA@public.gmane.org>
2003-07-26 22:09 ` John Belmonte
2003-07-26 21:32 ` John Belmonte
2003-07-26 21:25 ` John Belmonte
[not found] ` <3F22F1B0.9080607-ZFKsivP1bGvOQU1ULcgDhA@public.gmane.org>
2003-07-27 19:14 ` Matthew Wilcox
2004-06-23 6:26 swsusp and ac status Daniele Boffi
[not found] ` <20040623082653.A26014-xzhXYMPkGmXoPXhRcRtihA@public.gmane.org>
2004-06-23 13:34 ` Stefan Seyfried
2004-06-24 19:53 ` Pavel Machek
-- strict thread matches above, loose matches on Subject: below --
2003-07-25 23:28 [PATCH] Toshiba ACPI Extras 0.16 John Belmonte
[not found] ` <3F21BD11.8060405-ZFKsivP1bGvOQU1ULcgDhA@public.gmane.org>
2003-07-26 5:20 ` Matthew Wilcox
[not found] <pavel@suse.cz>
[not found] ` <20020917155146.F39-muQmgwBScQHrBKCeMvbIDA@public.gmane.org>
2002-09-18 12:24 ` 2.5.34? Brad Parker
[not found] ` <200209181224.g8ICONr31147-paYRYfI9b/YMuHHiPFXXZ1fOaUvyCJUZ@public.gmane.org>
2002-09-18 12:53 ` 2.5.34? Pavel Machek
[not found] ` <20040624195304.GE698-u08AdweFZfgxtPtxi4kahqVXKuFTiq87@public.gmane.org>
2004-06-29 11:50 ` swsusp and ac status Daniele Boffi
[not found] ` <200406291150.i5TBopX9001428-xzhXYMPkGmXoPXhRcRtihA@public.gmane.org>
2004-06-29 11:54 ` Pavel Machek
2002-09-16 0:14 2.5.34? Gustavo Sverzut Barbieri
[not found] ` <20020916001425.82756.qmail-jIUPyM9ARX+A/QwVtaZbd3CJp6faPEW9@public.gmane.org>
2002-09-16 0:25 ` 2.5.34? Matthew Wilcox
[not found] ` <20020916012506.G10583-+pPCBgu9SkPzIGdyhVEDUDl5KyyQGfY2kSSpQ9I8OhVaa/9Udqfwiw@public.gmane.org>
2002-09-16 6:19 ` 2.5.34? Toon van der Pas
[not found] ` <20020916081909.A25876-FeupCOz82S5hxPbjSeLqYA@public.gmane.org>
2002-09-17 15:46 ` 2.5.34? Pavel Machek
[not found] ` <20020917154653.C39-muQmgwBScQHrBKCeMvbIDA@public.gmane.org>
2002-09-18 16:38 ` 2.5.34? Toon van der Pas
[not found] ` <20020918183819.A10275-FeupCOz82S5hxPbjSeLqYA@public.gmane.org>
2002-09-17 23:36 ` 2.5.34? Pavel Machek
2002-09-16 11:30 ` 2.5.34? Brad Parker
[not found] ` <200209161130.g8GBUo024143-paYRYfI9b/YMuHHiPFXXZ1fOaUvyCJUZ@public.gmane.org>
2002-09-16 15:33 ` 2.5.34? Matthew Wilcox
2002-09-17 15:49 ` 2.5.34? Pavel Machek
[not found] <andrew.grover@intel.com>
[not found] ` <andrew.grover-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
[not found] ` <EDC461A30AC4D511ADE10002A5072CAD0236DE0D-OU+JdkIUtvd9zuciVAfUoVDQ4js95KgL@public.gmane.org>
2002-09-04 0:57 ` Runlevel for Sleep? Lyle Seaman
2002-09-04 10:50 ` P. Christeas
[not found] ` <200209041055.g84AsFW05361-a1J+ToZc0kR3t0M9ZKkFCQ@public.gmane.org>
2002-09-04 14:14 ` Charl P. Botha
2002-09-04 14:35 ` Robert Wo"rle
2002-09-06 12:21 ` Pavel Machek
[not found] ` <20020906122153.F39-muQmgwBScQHrBKCeMvbIDA@public.gmane.org>
2002-09-06 21:40 ` Patrick Mochel
[not found] ` <Pine.LNX.4.44.0209061411390.1021-100000-yZQdDDOm3n9ZQn2sFP3R7eTW4wlIGRCZ@public.gmane.org>
2002-09-06 22:29 ` Pavel Machek
[not found] ` <20020906222930.GE8827-jyMamyUUXNJG4ohzP4jBZS1Fcj925eT/@public.gmane.org>
2002-09-06 23:18 ` P. Christeas
2002-09-07 5:02 ` Stephen L Johnson
[not found] ` <1031374944.1530.44.camel-EWEM0Crkbjs/2vX+WiJxEB2eb7JE58TQ@public.gmane.org>
2002-09-07 19:51 ` Patrick Mochel
[not found] ` <Pine.LNX.4.44.0209071232170.1021-100000-yZQdDDOm3n9ZQn2sFP3R7eTW4wlIGRCZ@public.gmane.org>
2002-09-08 11:23 ` P. Christeas
2002-09-09 8:46 ` Diego Zuccato
[not found] ` <3D7C5FDF.4FB4E759-gmoNqwowlqBr8A+qpt3pXFzrSV/HdtiB@public.gmane.org>
2002-09-09 8:50 ` P. Christeas
2002-09-09 23:52 ` Diego Zuccato
2002-09-13 17:13 ` Pavel Machek
2002-09-14 7:56 ` Andreas Lohrum
[not found] ` <20020913171338.GC7096-I/5MKhXcvmPrBKCeMvbIDA@public.gmane.org>
2002-09-14 10:23 ` P. Christeas
[not found] ` <200209141237.g8ECb2d03519-a1J+ToZc0kR3t0M9ZKkFCQ@public.gmane.org>
2002-09-14 15:09 ` Pavel Machek
[not found] ` <200209081126.g88BQjn05186-a1J+ToZc0kR3t0M9ZKkFCQ@public.gmane.org>
2002-09-13 17:08 ` Pavel Machek
2002-09-07 17:32 ` Lyle Seaman
2002-09-03 23:47 Grover, Andrew
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030726.111800.13461649.imp@bsdimp.com \
--to=imp-uztcj5rojnnqt0dzr+alfa@public.gmane.org \
--cc=acpi-devel-pyega4qmqnRoyOMFzWx49A@public.gmane.org \
--cc=lws-RAHWjsxJnJUdnm+yROfE0A@public.gmane.org \
--cc=willy-8fiUuRrzOP0dnm+yROfE0A@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox