From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andi Kleen Subject: Re: [PATCH] 2.6.0-test4 Fix mpparse properly Date: Mon, 8 Sep 2003 04:25:48 +0200 Sender: acpi-devel-admin-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org Message-ID: <20030908042548.3bbfcf7d.ak@suse.de> References: <200309072130.40200.adq_dvb@lidskialf.net> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <200309072130.40200.adq_dvb-fmPXVN3awWJAJAzL26g0SA@public.gmane.org> Errors-To: acpi-devel-admin-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org List-Help: List-Post: List-Subscribe: , List-Unsubscribe: , List-Archive: To: Andrew de Quincey Cc: acpi-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org, linux-acpi-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org List-Id: linux-acpi@vger.kernel.org On Sun, 7 Sep 2003 21:30:40 +0100 Andrew de Quincey wrote: > > --- linux-2.6.0-test4.null_crs/arch/i386/kernel/mpparse.c 2003-09-06 00:23:10.000000000 +0100 > +++ linux-2.6.0-test4.es7000fix/arch/i386/kernel/mpparse.c 2003-09-07 15:53:41.369717552 +0100 > @@ -1129,8 +1129,10 @@ > continue; > ioapic_pin = irq - mp_ioapic_routing[ioapic].irq_start; > > +#ifdef CONFIG_X86_ES7000 > if (!ioapic && (irq < 16)) > irq += 16; > +#endif That won't work for an "generic" subarch kernel that supports the ES7000 and other boxes too. You should test es7000_plat instead (that's currently a static in the es7000 code, needs to be unstatic'ed). At least one 2.4 distribution kernel does it this way. -Andi ------------------------------------------------------- This sf.net email is sponsored by:ThinkGeek Welcome to geek heaven. http://thinkgeek.com/sf