Re: [PATCH] 2.6.0-test4 Fix mpparse properly

Andi Kleen
2003-09-08T02:25:48Z

On Sun, 7 Sep 2003 21:30:40 +0100
Andrew de Quincey <adq_dvb-fmPXVN3awWJAJAzL26g0SA@public.gmane.org> wrote:

>
> --- linux-2.6.0-test4.null_crs/arch/i386/kernel/mpparse.c 2003-09-06 00:23:10.000000000 +0100
> +++ linux-2.6.0-test4.es7000fix/arch/i386/kernel/mpparse.c 2003-09-07 15:53:41.369717552 +0100
> @@ -1129,8 +1129,10 @@
> continue;
> ioapic_pin = irq - mp_ioapic_routing[ioapic].irq_start;
>
> +#ifdef CONFIG_X86_ES7000
> if (!ioapic && (irq < 16))
> irq += 16;
> +#endif

That won't work for an "generic" subarch kernel that supports the ES7000 and other boxes too.
You should test es7000_plat instead (that's currently a static in the es7000 code, needs to be unstatic'ed).

At least one 2.4 distribution kernel does it this way.

-Andi