Re: [PATCH] 2.6.0-test4 Fix mpparse properly

Andrew de Quincey
2003-09-08T10:02:46Z

On Monday 08 Sep 2003 3:25 am, Andi Kleen wrote:
> On Sun, 7 Sep 2003 21:30:40 +0100
>
> Andrew de Quincey <adq_dvb-fmPXVN3awWJAJAzL26g0SA@public.gmane.org> wrote:
> > --- linux-2.6.0-test4.null_crs/arch/i386/kernel/mpparse.c 2003-09-06
> > 00:23:10.000000000 +0100 +++
> > linux-2.6.0-test4.es7000fix/arch/i386/kernel/mpparse.c 2003-09-07
> > 15:53:41.369717552 +0100 @@ -1129,8 +1129,10 @@
> > continue;
> > ioapic_pin = irq - mp_ioapic_routing[ioapic].irq_start;
> >
> > +#ifdef CONFIG_X86_ES7000
> > if (!ioapic && (irq < 16))
> > irq += 16;
> > +#endif
>
> That won't work for an "generic" subarch kernel that supports the ES7000
> and other boxes too. You should test es7000_plat instead (that's currently
> a static in the es7000 code, needs to be unstatic'ed).

Hmm, yeah, thats a good point. However, I don't think checking for es7000_plat
will work. The file defining it is only included if es7000 is targetted as a
platform directly. Theres no code which checks for an es7000 platform by
looking at the hardware or anything; it just sets the variable if the es7000
architecture is targetted...

Any ideas?