Re: acpi_bus_register_driver() returns -ENODEV after resume

[Karol Kozimor <sziwan-DETuoxkZsSqrDJvtcaxF/A@public.gmane.org>]

Thus wrote Patrick Mochel:
> Since it's __initdata, the memory will be freed early in the init process 
> (c.f. init/main.c::init() -> free_initmem()). Anything that uses it later 
> is touching memory that is either unallocated, or allocated by something 
> else. That's a bug. 
> 
> Also, it doesn't need to be EXPORTed. If it is left as initdata, that's
> another bug, because the two are semantically disjoint. However, even with
> the patch below, I'm not sure why you would want to expose the variable 
> (and I've in fact removed that). 
> 
> Please give it a try and let me know if helps. 

In short: 2.4.23-pre3 vanilla: problem present
	  2.4.23-pre3 with __initdata and EXPRT_SYMBOL removed: compiles
	  fine, the problem seems to have disappeared.

The patch you made is OK for 2.6, I inline one for 2.4 (the same except for
the top line)

--- linux-2.4.23-pre3/arch/i386/kernel/setup.c~ 2003-09-04 15:21:03.000000000 +0200
+++ linux-2.4.23-pre3/arch/i386/kernel/setup.c  2003-09-08 23:56:00.000000000 +0200
@@ -176,11 +176,10 @@
 static u32 disabled_x86_caps[NCAPINTS] __initdata = { 0 };

 #ifdef CONFIG_ACPI_INTERPRETER
-       int acpi_disabled __initdata = 0;
+       int acpi_disabled = 0;
 #else
-       int acpi_disabled __initdata = 1;
+       int acpi_disabled = 1;
 #endif
-EXPORT_SYMBOL(acpi_disabled);

 #ifdef CONFIG_ACPI_BOOT
        int acpi_ht __initdata = 1;     /* enable HT */


Thanks for help, best regards,

-- 
Karol 'sziwan' Kozimor
sziwan-DETuoxkZsSqrDJvtcaxF/A@public.gmane.org


-------------------------------------------------------
This sf.net email is sponsored by:ThinkGeek
Welcome to geek heaven.
http://thinkgeek.com/sf