From: Pavel Machek <pavel-AlSwsSmVLrQ@public.gmane.org>
To: Felipe W Damasio <felipewd-y7mWNqJcIDpfJ/NunPodnw@public.gmane.org>
Cc: "Grover,
Andrew" <andrew.grover-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>,
mochel-3NddpPZAyC0@public.gmane.org,
acpi-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org
Subject: Re: Re: [PATCH] unneeded memory barrier
Date: Fri, 12 Sep 2003 13:12:54 +0200 [thread overview]
Message-ID: <20030912111253.GL3944@openzaurus.ucw.cz> (raw)
In-Reply-To: <3F60EA55.90008-y7mWNqJcIDpfJ/NunPodnw@public.gmane.org>
Hi!
> >> Patch against 2.6-test5 to remove an, IMHO, unneeded
> >>memory barrier
> >>on acpi/bus.c. Feel free to tell me I'm totally wrong, though :)
> >>
> >> If it looks good, please consider applying.
> >
> >
> >- set_current_state(TASK_RUNNING);
> >+ __set_current_state(TASK_RUNNING);
> >
> >My understanding of functions starting with __ was "use them but you
> >better know what you're doing". This patch may be technically correct
> >but does the unneeded barrier really hurt anything? If not then I
> >think
> >the regular version is ok.
>
> I don't think it hurts in terms of "enforcing ordering too
> much", but that barrier isn't needed at all since it sets the state
> to TASK_RUNNING...
If setting to TASK_RUNNING never requires barier, I guess some
__builtin_constant and ==TASK_RUNNING check in
set_task_state is better idea.
--
Pavel
Written on sharp zaurus, because my Velo1 broke. If you have Velo you don't need...
-------------------------------------------------------
This sf.net email is sponsored by:ThinkGeek
Welcome to geek heaven.
http://thinkgeek.com/sf
prev parent reply other threads:[~2003-09-12 11:12 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-09-11 20:56 [PATCH] unneeded memory barrier Grover, Andrew
[not found] ` <F760B14C9561B941B89469F59BA3A8470255EF0F-sBd4vmA9Se4Lll3ZsUKC9FDQ4js95KgL@public.gmane.org>
2003-09-11 21:34 ` Felipe W Damasio
[not found] ` <3F60EA55.90008-y7mWNqJcIDpfJ/NunPodnw@public.gmane.org>
2003-09-12 11:12 ` Pavel Machek [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030912111253.GL3944@openzaurus.ucw.cz \
--to=pavel-alswssmvlrq@public.gmane.org \
--cc=acpi-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org \
--cc=andrew.grover-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
--cc=felipewd-y7mWNqJcIDpfJ/NunPodnw@public.gmane.org \
--cc=mochel-3NddpPZAyC0@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox