public inbox for linux-acpi@vger.kernel.org
 help / color / mirror / Atom feed
From: Andrew de Quincey <adq_dvb-fmPXVN3awWJAJAzL26g0SA@public.gmane.org>
To: linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	acpi-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org
Cc: linux-acpi-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org,
	Chris Wright <chrisw-3NddpPZAyC0@public.gmane.org>
Subject: [PATCH] 2.6.0-test4 Don't change BIOS allocated IRQs
Date: Wed, 17 Sep 2003 00:11:03 +0100	[thread overview]
Message-ID: <200309170011.03630.adq_dvb@lidskialf.net> (raw)

With the help of Chris Wright testing several failed patches, I've tracked 
down another ACPI IRQ problem. On many systems, the BIOS 
pre-allocates IRQs for certain PCI devices, providing a list of alternate 
possibilities as well.

On some systems, changing the IRQ to one of those alternate possibilities 
works fine. On others however, it really isn't a good idea. As theres no 
way to tell which systems are good and bad in advance, this patch simply 
ensures that ACPI does not change an IRQ if the BIOS has pre-allocated it.



--- linux-2.6.0-test4.es7000fix/drivers/acpi/pci_link.c	2003-09-06 00:35:16.000000000 +0100
+++ linux-2.6.0-test4.nochangeirq/drivers/acpi/pci_link.c	2003-09-17 00:00:40.740553544 +0100
@@ -510,15 +510,15 @@
 		irq = link->irq.active;
 	} else {
 		irq = link->irq.possible[0];
-	}
 
-	/* 
-	 * Select the best IRQ.  This is done in reverse to promote 
-	 * the use of IRQs 9, 10, 11, and >15.
-	 */
-	for (i=(link->irq.possible_count-1); i>0; i--) {
-		if (acpi_irq_penalty[irq] > acpi_irq_penalty[link->irq.possible[i]])
-			irq = link->irq.possible[i];
+		/* 
+		 * Select the best IRQ.  This is done in reverse to promote 
+		 * the use of IRQs 9, 10, 11, and >15.
+		 */
+		for (i=(link->irq.possible_count-1); i>0; i--) {
+			if (acpi_irq_penalty[irq] > acpi_irq_penalty[link->irq.possible[i]])
+				irq = link->irq.possible[i];
+		}
 	}
 
 	/* Attempt to enable the link device at this IRQ. */

             reply	other threads:[~2003-09-16 23:11 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-09-16 23:11 Andrew de Quincey [this message]
     [not found] ` <200309170011.03630.adq_dvb-fmPXVN3awWJAJAzL26g0SA@public.gmane.org>
2003-09-17  0:29   ` [PATCH] 2.6.0-test4 Don't change BIOS allocated IRQs Chris Wright
2003-09-17  1:02   ` [ACPI] " Greg KH
     [not found]     ` <20030917010254.GA1640-U8xfFu+wG4EAvxtiuMwx3w@public.gmane.org>
2003-09-17  8:08       ` Andrew de Quincey

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200309170011.03630.adq_dvb@lidskialf.net \
    --to=adq_dvb-fmpxvn3awwjajazl26g0sa@public.gmane.org \
    --cc=acpi-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org \
    --cc=chrisw-3NddpPZAyC0@public.gmane.org \
    --cc=linux-acpi-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
    --cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox