public inbox for linux-acpi@vger.kernel.org
 help / color / mirror / Atom feed
From: Chris Wright <chrisw-3NddpPZAyC0@public.gmane.org>
To: len.brown-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org
Cc: linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	acpi-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org,
	adq_dvb-fmPXVN3awWJAJAzL26g0SA@public.gmane.org
Subject: [PATCH] ACPI pci irq routing fix
Date: Fri, 26 Sep 2003 18:21:28 -0700	[thread overview]
Message-ID: <20030926182128.C24360@osdlab.pdx.osdl.net> (raw)

If irq.active is set from _CRS, make sure to use it, rather than trying
anything from the from the _PRS list, as some machines don't handle this
properly.  This patch is against current linux-acpi-test-2.6.0.  It's
been floating about for a while, and fixes bug #1186.

Patch originally from Andrew de Quincey.

thanks,
-chris
-- 
Linux Security Modules     http://lsm.immunix.org     http://lsm.bkbits.net

===== drivers/acpi/pci_link.c 1.19 vs edited =====
--- 1.19/drivers/acpi/pci_link.c	Thu Sep 18 11:29:36 2003
+++ edited/drivers/acpi/pci_link.c	Fri Sep 26 14:36:15 2003
@@ -500,15 +500,15 @@
 		irq = link->irq.active;
 	} else {
 		irq = link->irq.possible[0];
-	}
 
-	/* 
-	 * Select the best IRQ.  This is done in reverse to promote 
-	 * the use of IRQs 9, 10, 11, and >15.
-	 */
-	for (i=(link->irq.possible_count-1); i>0; i--) {
-		if (acpi_irq_penalty[irq] > acpi_irq_penalty[link->irq.possible[i]])
-			irq = link->irq.possible[i];
+		/*
+		 * Select the best IRQ.  This is done in reverse to promote
+		 * the use of IRQs 9, 10, 11, and >15.
+		 */
+		for (i=(link->irq.possible_count-1); i>0; i--) {
+			if (acpi_irq_penalty[irq] > acpi_irq_penalty[link->irq.possible[i]])
+				irq = link->irq.possible[i];
+		}
 	}
 
 	/* Attempt to enable the link device at this IRQ. */

             reply	other threads:[~2003-09-27  1:21 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-09-27  1:21 Chris Wright [this message]
     [not found] ` <20030926182128.C24360-BI/OLcgY7/cyyg0EjBt7GtHuzzzSOjJt@public.gmane.org>
2003-09-27  5:54   ` [PATCH] ACPI pci irq routing fix Nick Piggin
     [not found]     ` <3F752619.5000406-/x7JMgtu12E0n/F98K4Iww@public.gmane.org>
2003-09-30  5:17       ` Len Brown
     [not found]         ` <1064899042.2532.101.camel-D2Zvc0uNKG8@public.gmane.org>
2003-09-30  6:08           ` Chris Wright

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20030926182128.C24360@osdlab.pdx.osdl.net \
    --to=chrisw-3nddppzayc0@public.gmane.org \
    --cc=acpi-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org \
    --cc=adq_dvb-fmPXVN3awWJAJAzL26g0SA@public.gmane.org \
    --cc=len.brown-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
    --cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox