From: Pavel Machek <pavel-+ZI9xUNit7I@public.gmane.org>
To: Rusty trivial patch monkey Russell
<trivial-8n+1lVoiYb80n/F98K4Iww@public.gmane.org>,
ACPI mailing list
<acpi-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org>
Subject: 2 different functions with same name are bad idea
Date: Thu, 9 Oct 2003 02:11:50 +0200 [thread overview]
Message-ID: <20031009001149.GA714@elf.ucw.cz> (raw)
Hi!
There's acpi_disable somewhere in the acpi interpreter (it disables
interrupts, iirc). Thus blacklisting function needs better name.
Pavel
--- tmp/linux/arch/i386/kernel/dmi_scan.c 2003-10-09 00:13:13.000000000 +0200
+++ linux/arch/i386/kernel/dmi_scan.c 2003-10-09 00:19:11.000000000 +0200
@@ -506,7 +507,7 @@
extern int acpi_disabled, acpi_force;
-static __init __attribute__((unused)) int acpi_disable(struct dmi_blacklist *d)
+static __init __attribute__((unused)) int disable_acpi(struct dmi_blacklist *d)
{
if (!acpi_force) {
printk(KERN_NOTICE "%s detected: acpi off\n",d->ident);
@@ -880,7 +881,7 @@
* Boxes that need ACPI disabled
*/
- { acpi_disable, "IBM Thinkpad", {
+ { disable_acpi, "IBM Thinkpad", {
MATCH(DMI_BOARD_VENDOR, "IBM"),
MATCH(DMI_BOARD_NAME, "2629H1G"),
NO_MATCH, NO_MATCH }},
--
When do you have a heart between your knees?
[Johanka's followup: and *two* hearts?]
-------------------------------------------------------
This SF.net email is sponsored by: SF.net Giveback Program.
SourceForge.net hosts over 70,000 Open Source Projects.
See the people who have HELPED US provide better services:
Click here: http://sourceforge.net/supporters.php
reply other threads:[~2003-10-09 0:11 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20031009001149.GA714@elf.ucw.cz \
--to=pavel-+zi9xunit7i@public.gmane.org \
--cc=acpi-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org \
--cc=trivial-8n+1lVoiYb80n/F98K4Iww@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox