* 2 different functions with same name are bad idea
@ 2003-10-09 0:11 Pavel Machek
0 siblings, 0 replies; only message in thread
From: Pavel Machek @ 2003-10-09 0:11 UTC (permalink / raw)
To: Rusty trivial patch monkey Russell, ACPI mailing list
Hi!
There's acpi_disable somewhere in the acpi interpreter (it disables
interrupts, iirc). Thus blacklisting function needs better name.
Pavel
--- tmp/linux/arch/i386/kernel/dmi_scan.c 2003-10-09 00:13:13.000000000 +0200
+++ linux/arch/i386/kernel/dmi_scan.c 2003-10-09 00:19:11.000000000 +0200
@@ -506,7 +507,7 @@
extern int acpi_disabled, acpi_force;
-static __init __attribute__((unused)) int acpi_disable(struct dmi_blacklist *d)
+static __init __attribute__((unused)) int disable_acpi(struct dmi_blacklist *d)
{
if (!acpi_force) {
printk(KERN_NOTICE "%s detected: acpi off\n",d->ident);
@@ -880,7 +881,7 @@
* Boxes that need ACPI disabled
*/
- { acpi_disable, "IBM Thinkpad", {
+ { disable_acpi, "IBM Thinkpad", {
MATCH(DMI_BOARD_VENDOR, "IBM"),
MATCH(DMI_BOARD_NAME, "2629H1G"),
NO_MATCH, NO_MATCH }},
--
When do you have a heart between your knees?
[Johanka's followup: and *two* hearts?]
-------------------------------------------------------
This SF.net email is sponsored by: SF.net Giveback Program.
SourceForge.net hosts over 70,000 Open Source Projects.
See the people who have HELPED US provide better services:
Click here: http://sourceforge.net/supporters.php
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2003-10-09 0:11 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2003-10-09 0:11 2 different functions with same name are bad idea Pavel Machek
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox