From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ducrot Bruno Subject: Re: 2.6.0-test9 regression: panic on Fn+F7 hotkey Date: Tue, 28 Oct 2003 11:03:55 +0100 Sender: acpi-devel-admin-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org Message-ID: <20031028100355.GX28351@poupinou.org> References: <571ACEFD467F7749BC50E0A98C17CDD8D5FDBE@pdsmsx403.ccr.corp.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <571ACEFD467F7749BC50E0A98C17CDD8D5FDBE-4yWAQGcml64gGBtAFL8yw7fspsVTdybXVpNB7YpNyf8@public.gmane.org> Errors-To: acpi-devel-admin-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org List-Help: List-Post: List-Subscribe: , List-Unsubscribe: , List-Archive: To: "Li, Shaohua" Cc: =?iso-8859-1?Q?S=E9rgio?= Monteiro Basto , Karol Kozimor , acpi-devel List-Id: linux-acpi@vger.kernel.org On Tue, Oct 28, 2003 at 04:14:56PM +0800, Li, Shaohua wrote: > Hi, > > I missed non-ECDT situation. Try this one. > Please don't apply. This is not OK. You missed the point that an interrupt handler can not sleep. Anyway, from my point-of-view, ec.c is not buggy, but events/exviface.c::acpi_remove_.*(). IMHO, we should have our own acpi workqueue, at first, and then wait for completion when removing any events handlers. Those, the correct fix should be in osl.c, and in events/evxface.c calling this wait for completition implemented in osl.c. -- Ducrot Bruno -- Which is worse: ignorance or apathy? -- Don't know. Don't care. ------------------------------------------------------- This SF.net email is sponsored by: The SF.net Donation Program. Do you like what SourceForge.net is doing for the Open Source Community? Make a contribution, and help us add new features and functionality. Click here: http://sourceforge.net/donate/