RE: 2.6.0-test9 regression: panic on Fn+F7 hotkey

RE: 2.6.0-test9 regression: panic on Fn+F7 hotkey

[Li, Shaohua]

[-- Attachment #1: Type: text/plain, Size: 3187 bytes --]

Hi,

I missed non-ECDT situation. Try this one. 

Thanks,
Shaohua


> -----Original Message-----
> From: Sérgio Monteiro Basto [mailto:sergiomb-hHo3WeeoaswVhHzd4jOs4w@public.gmane.org]
> Sent: 2003年10月28日 14:23
> To: Li, Shaohua
> Cc: Karol Kozimor; acpi-devel
> Subject: RE: [ACPI] 2.6.0-test9 regression: panic on Fn+F7 hotkey
> 
> Hi
> Pressing Fn+F7 doesnt seems to be in boot time.
> For me acpi_ec_gpe_query.patch in 2.4.23-pre8, hangs my laptop when I
> press lid button, after boot and after login after enter in X, after all
> things up.
> 
> On Tue, 2003-10-28 at 02:30, Li, Shaohua wrote:
> > Hi,
> >   Which time did the panic occur? Boot time? Yes, I made the patch to
> fix some boot time errors.
> > But if boot is ok, the patch should not impact anything.
> 
> but have a lot of impact.
> in my case, boots without problems.
> 
> Please give me more info.
> >
> > Thanks,
> > Shaohua
> >
> >
> > > -----Original Message-----
> > > From: acpi-devel-admin-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org [mailto:acpi-devel-
> > > admin-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org] On Behalf Of Karol Kozimor
> > > Sent: 2003年10月28日 1:08
> > > To: acpi-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org
> > > Subject: [ACPI] 2.6.0-test9 regression: panic on Fn+F7 hotkey
> > >
> > > Hi,
> > > Pressing Fn+F7 to turn the LCD on / off causes 2.6.0-test9 to panic.
> > > That's
> > > AFAIK the single event that causes such a behaviour, other keys work
> fine.
> > > Reverting the acpi_ec_gpe_query.patchi[1] fixes the issue and makes
> the
> > > kernel
> > > run fine.
> > >
> > > [1]:
> > >
> http://www.kernel.org/pub/linux/kernel/people/lenb/acpi/patches/test/2.4.2
> > > 2/20031017152411-acpi_ec_gpe_query.patch
> > >
> > > Best regards,
> > >
> > > --
> > > Karol 'sziwan' Kozimor
> > > sziwan-DETuoxkZsSqrDJvtcaxF/A@public.gmane.org
> > >
> > >
> > > -------------------------------------------------------
> > > This SF.net email is sponsored by: The SF.net Donation Program.
> > > Do you like what SourceForge.net is doing for the Open
> > > Source Community?  Make a contribution, and help us add new
> > > features and functionality. Click here: http://sourceforge.net/donate/
> > > _______________________________________________
> > > Acpi-devel mailing list
> > > Acpi-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org
> > > https://lists.sourceforge.net/lists/listinfo/acpi-devel
> >
> >
> > -------------------------------------------------------
> > This SF.net email is sponsored by: The SF.net Donation Program.
> > Do you like what SourceForge.net is doing for the Open
> > Source Community?  Make a contribution, and help us add new
> > features and functionality. Click here: http://sourceforge.net/donate/
> > _______________________________________________
> > Acpi-devel mailing list
> > Acpi-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org
> > https://lists.sourceforge.net/lists/listinfo/acpi-devel
> --
> SérgioMB
> email: sergiomb-hHo3WeeoaswVhHzd4jOs4w@public.gmane.org
> 
> Who gives me one shell, give me everything.


[-- Attachment #2: ec_gpe.patch2 --]
[-- Type: application/octet-stream, Size: 1888 bytes --]

--- a/drivers/acpi/ec.c	2003-10-28 15:58:44.000000000 +0800
+++ b/drivers/acpi/ec.c	2003-10-28 16:05:17.000000000 +0800
@@ -90,6 +90,14 @@
 /* External interfaces use first EC only, so remember */
 static struct acpi_device *first_ec;
 
+/*
+ * We use kernel thread to handle ec's gpe query, so the query may defer.
+ * The query need a context, which can be freed when we replace ec_ecdt
+ * with EC device. So defered query may have a wrong context.
+ * We use an indication to avoid it
+ */
+static int ec_device_init = 0;
+
 /* --------------------------------------------------------------------------
                              Transaction Management
    -------------------------------------------------------------------------- */
@@ -389,8 +397,11 @@
 
 	acpi_disable_gpe(NULL, ec->gpe_bit, ACPI_ISR);
 
-	status = acpi_os_queue_for_execution(OSD_PRIORITY_GPE,
-		acpi_ec_gpe_query, ec);
+	if (!ec_device_init)
+		acpi_ec_gpe_query(ec); /* directly query when device didn't init */
+	else
+		status = acpi_os_queue_for_execution(OSD_PRIORITY_GPE,
+			acpi_ec_gpe_query, ec);
 }
 
 /* --------------------------------------------------------------------------
@@ -574,6 +585,7 @@
 	sprintf(acpi_device_name(device), "%s", ACPI_EC_DEVICE_NAME);
 	sprintf(acpi_device_class(device), "%s", ACPI_EC_CLASS);
 	acpi_driver_data(device) = ec;
+	ec_device_init = 1;
 
 	/* Use the global lock for all EC transactions? */
 	acpi_evaluate_integer(ec->handle, "_GLK", NULL, &ec->global_lock);
@@ -582,6 +594,7 @@
 	   we now have the *real* EC info, so kill the makeshift one.*/
 	acpi_evaluate_integer(ec->handle, "_UID", NULL, &uid);
 	if (ec_ecdt && ec_ecdt->uid == uid) {
+		acpi_disable_gpe(NULL, ec_ecdt->gpe_bit, ACPI_NOT_ISR);
 		acpi_remove_address_space_handler(ACPI_ROOT_OBJECT,
 			ACPI_ADR_SPACE_EC, &acpi_ec_space_handler);
 	

Re: 2.6.0-test9 regression: panic on Fn+F7 hotkey

[Ducrot Bruno]

On Tue, Oct 28, 2003 at 04:14:56PM +0800, Li, Shaohua wrote:
> Hi,
> 
> I missed non-ECDT situation. Try this one. 
> 

Please don't apply.  This is not OK.  You missed the
point that an interrupt handler can not sleep.  Anyway,
from my point-of-view, ec.c is not buggy, but
events/exviface.c::acpi_remove_.*().

IMHO, we should have our own acpi workqueue, at first, and
then wait for completion when removing any events handlers.
Those, the correct fix should be in osl.c, and in events/evxface.c
calling this wait for completition implemented in osl.c.

-- 
Ducrot Bruno

--  Which is worse:  ignorance or apathy?
--  Don't know.  Don't care.


-------------------------------------------------------
This SF.net email is sponsored by: The SF.net Donation Program.
Do you like what SourceForge.net is doing for the Open
Source Community?  Make a contribution, and help us add new
features and functionality. Click here: http://sourceforge.net/donate/

RE: 2.6.0-test9 regression: panic on Fn+F7 hotkey

[Li, Shaohua]

Hi,
Sorry, I made a mistake. should be this one.
Because ECDT unusually has similar info with EC. Changing the context should not cause problem. 

--- ec.c	2003-10-09 03:24:07.000000000 +0800
+++ ec.c.new	2003-10-28 21:29:51.000000000 +0800
@@ -93,7 +93,7 @@
 
 /* External interfaces use first EC only, so remember */
 static struct acpi_device *first_ec;
-
+static struct acpi_device *ec_context;
 /* --------------------------------------------------------------------------
                              Transaction Management
    -------------------------------------------------------------------------- */
@@ -342,7 +342,7 @@
 acpi_ec_gpe_query (
 	void			*ec_cxt)
 {
-	struct acpi_ec		*ec = (struct acpi_ec *) ec_cxt;
+	struct acpi_ec		*ec = ec_context;
 	u32			value = 0;
 	unsigned long		flags = 0;
 	static char		object_name[5] = {'_','Q','0','0','\0'};
@@ -581,7 +581,7 @@
 	sprintf(acpi_device_name(device), "%s", ACPI_EC_DEVICE_NAME);
 	sprintf(acpi_device_class(device), "%s", ACPI_EC_CLASS);
 	acpi_driver_data(device) = ec;
-
+	ec_context = ec;
 	/* Use the global lock for all EC transactions? */
 	acpi_evaluate_integer(ec->handle, "_GLK", NULL, &ec->global_lock);
 
@@ -793,7 +793,7 @@
 	/* use the GL just to be safe */
 	ec_ecdt->global_lock = TRUE;
 	ec_ecdt->uid = ecdt_ptr->uid;
-
+	ec_context = ec_ecdt;
 	status = acpi_get_handle(NULL, ecdt_ptr->ec_id, &ec_ecdt->handle);
 	if (ACPI_FAILURE(status)) {
 		goto error;


-------------------------------------------------------
This SF.net email is sponsored by: The SF.net Donation Program.
Do you like what SourceForge.net is doing for the Open
Source Community?  Make a contribution, and help us add new
features and functionality. Click here: http://sourceforge.net/donate/

Re: 2.6.0-test9 regression: panic on Fn+F7 hotkey

[Ducrot Bruno]

On Tue, Oct 28, 2003 at 09:42:45PM +0800, Li, Shaohua wrote:
> 
> Hi,
> Sorry, I made a mistake. should be this one.
> Because ECDT unusually has similar info with EC. Changing the context should not cause problem. 

Same answer.  There can be more than one EC.

-- 
Ducrot Bruno

--  Which is worse:  ignorance or apathy?
--  Don't know.  Don't care.


-------------------------------------------------------
This SF.net email is sponsored by: The SF.net Donation Program.
Do you like what SourceForge.net is doing for the Open
Source Community?  Make a contribution, and help us add new
features and functionality. Click here: http://sourceforge.net/donate/

RE: 2.6.0-test9 regression: panic on Fn+F7 hotkey

[Li, Shaohua]

> -----Original Message-----
> From: Ducrot Bruno [mailto:ducrot-kk6yZipjEM5g9hUCZPvPmw@public.gmane.org]
> Sent: 2003年10月28日 18:04
> To: Li, Shaohua
> Cc: Sérgio Monteiro Basto; Karol Kozimor; acpi-devel
> Subject: Re: [ACPI] 2.6.0-test9 regression: panic on Fn+F7 hotkey
> 
> On Tue, Oct 28, 2003 at 04:14:56PM +0800, Li, Shaohua wrote:
> > Hi,
> >
> > I missed non-ECDT situation. Try this one.
> >
> 
> Please don't apply.  This is not OK.  You missed the
> point that an interrupt handler can not sleep.  Anyway,
> from my point-of-view, ec.c is not buggy, but
> events/exviface.c::acpi_remove_.*().
> 
> IMHO, we should have our own acpi workqueue, at first, and
> then wait for completion when removing any events handlers.
> Those, the correct fix should be in osl.c, and in events/evxface.c
> calling this wait for completition implemented in osl.c.

   yes, I know it's a bad idea to execute GPE query in interrupt handler. I do such thing is because this situation is rare. The interrupts seldom occur before EC device is initialized. 

   But even though acpi has own workqueue, When replace ECDT with EC, we still have a wrong context. 

   I think a better solution is when replace ECDT with EC, we can change the context in the event queue. Or we can use indirectly accessed context. Like this:

--- ec.c	2003-10-09 03:24:07.000000000 +0800
+++ ec.c.new	2003-10-28 20:17:05.643232728 +0800
@@ -93,7 +93,7 @@
 
 /* External interfaces use first EC only, so remember */
 static struct acpi_device *first_ec;
-
+static struct acpi_device *ec_context = NULL;
 /* --------------------------------------------------------------------------
                              Transaction Management
    -------------------------------------------------------------------------- */
@@ -386,7 +386,7 @@
 	void			*data)
 {
 	acpi_status		status = AE_OK;
-	struct acpi_ec		*ec = (struct acpi_ec *) data;
+	struct acpi_ec		*ec = ec_context;
 
 	if (!ec)
 		return;
@@ -581,7 +581,7 @@
 	sprintf(acpi_device_name(device), "%s", ACPI_EC_DEVICE_NAME);
 	sprintf(acpi_device_class(device), "%s", ACPI_EC_CLASS);
 	acpi_driver_data(device) = ec;
-
+	ec_context = ec;
 	/* Use the global lock for all EC transactions? */
 	acpi_evaluate_integer(ec->handle, "_GLK", NULL, &ec->global_lock);
 
@@ -793,7 +793,7 @@
 	/* use the GL just to be safe */
 	ec_ecdt->global_lock = TRUE;
 	ec_ecdt->uid = ecdt_ptr->uid;
-
+	ec_context = ec_ecdt;
 	status = acpi_get_handle(NULL, ecdt_ptr->ec_id, &ec_ecdt->handle);
 	if (ACPI_FAILURE(status)) {
 		goto error;


In general, ECDT includes similar info as EC device. does this one make sense?

Thanks,
shaohua


-------------------------------------------------------
This SF.net email is sponsored by: The SF.net Donation Program.
Do you like what SourceForge.net is doing for the Open
Source Community?  Make a contribution, and help us add new
features and functionality. Click here: http://sourceforge.net/donate/

Re: 2.6.0-test9 regression: panic on Fn+F7 hotkey

[Ducrot Bruno]

On Tue, Oct 28, 2003 at 08:33:16PM +0800, Li, Shaohua wrote:
> 
> > -----Original Message-----
> > From: Ducrot Bruno [mailto:ducrot-kk6yZipjEM5g9hUCZPvPmw@public.gmane.org]
> > Sent: 2003??10??28?? 18:04
> > To: Li, Shaohua
> > Cc: Sérgio Monteiro Basto; Karol Kozimor; acpi-devel
> > Subject: Re: [ACPI] 2.6.0-test9 regression: panic on Fn+F7 hotkey
> > 
> > On Tue, Oct 28, 2003 at 04:14:56PM +0800, Li, Shaohua wrote:
> > > Hi,
> > >
> > > I missed non-ECDT situation. Try this one.
> > >
> > 
> > Please don't apply.  This is not OK.  You missed the
> > point that an interrupt handler can not sleep.  Anyway,
> > from my point-of-view, ec.c is not buggy, but
> > events/exviface.c::acpi_remove_.*().
> > 
> > IMHO, we should have our own acpi workqueue, at first, and
> > then wait for completion when removing any events handlers.
> > Those, the correct fix should be in osl.c, and in events/evxface.c
> > calling this wait for completition implemented in osl.c.
> 
>    yes, I know it's a bad idea to execute GPE query in interrupt handler. I do such thing is because this situation is rare. The interrupts seldom occur before EC device is initialized. 
> 
>    But even though acpi has own workqueue, When replace ECDT with EC, we still have a wrong context. 

Yes, there is still a little window where unlikely this may happens (that why
I think that should go in osl.c, because anyway this is more generic than
the EC problem, and have to be done in OS fashion).

> 
>    I think a better solution is when replace ECDT with EC, we can change the context in the event queue. Or we can use indirectly accessed context. Like this:
> 
> --- ec.c	2003-10-09 03:24:07.000000000 +0800
> +++ ec.c.new	2003-10-28 20:17:05.643232728 +0800
> @@ -93,7 +93,7 @@
>  
>  /* External interfaces use first EC only, so remember */
>  static struct acpi_device *first_ec;
> -
> +static struct acpi_device *ec_context = NULL;
>  /* --------------------------------------------------------------------------
>                               Transaction Management
>     -------------------------------------------------------------------------- */
> @@ -386,7 +386,7 @@
>  	void			*data)
>  {
>  	acpi_status		status = AE_OK;
> -	struct acpi_ec		*ec = (struct acpi_ec *) data;
> +	struct acpi_ec		*ec = ec_context;
>  
>  	if (!ec)
>  		return;

...

What happens if you have more than one EC?  Toshiba Satellite 190x
series have 2 EC IIRC, and only one will have an interrupt handler.

Cheers,

-- 
Ducrot Bruno

--  Which is worse:  ignorance or apathy?
--  Don't know.  Don't care.


-------------------------------------------------------
This SF.net email is sponsored by: The SF.net Donation Program.
Do you like what SourceForge.net is doing for the Open
Source Community?  Make a contribution, and help us add new
features and functionality. Click here: http://sourceforge.net/donate/

RE: 2.6.0-test9 regression: panic on Fn+F7 hotkey

[Li, Shaohua]

Hi,
  Which time did the panic occur? Boot time? Yes, I made the patch to fix some boot time errors. But if boot is ok, the patch should not impact anything. Please give me more info.

Thanks,
Shaohua


> -----Original Message-----
> From: acpi-devel-admin-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org [mailto:acpi-devel-
> admin-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org] On Behalf Of Karol Kozimor
> Sent: 2003年10月28日 1:08
> To: acpi-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org
> Subject: [ACPI] 2.6.0-test9 regression: panic on Fn+F7 hotkey
> 
> Hi,
> Pressing Fn+F7 to turn the LCD on / off causes 2.6.0-test9 to panic.
> That's
> AFAIK the single event that causes such a behaviour, other keys work fine.
> Reverting the acpi_ec_gpe_query.patchi[1] fixes the issue and makes the
> kernel
> run fine.
> 
> [1]:
> http://www.kernel.org/pub/linux/kernel/people/lenb/acpi/patches/test/2.4.2
> 2/20031017152411-acpi_ec_gpe_query.patch
> 
> Best regards,
> 
> --
> Karol 'sziwan' Kozimor
> sziwan-DETuoxkZsSqrDJvtcaxF/A@public.gmane.org
> 
> 
> -------------------------------------------------------
> This SF.net email is sponsored by: The SF.net Donation Program.
> Do you like what SourceForge.net is doing for the Open
> Source Community?  Make a contribution, and help us add new
> features and functionality. Click here: http://sourceforge.net/donate/
> _______________________________________________
> Acpi-devel mailing list
> Acpi-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org
> https://lists.sourceforge.net/lists/listinfo/acpi-devel


-------------------------------------------------------
This SF.net email is sponsored by: The SF.net Donation Program.
Do you like what SourceForge.net is doing for the Open
Source Community?  Make a contribution, and help us add new
features and functionality. Click here: http://sourceforge.net/donate/

RE: 2.6.0-test9 regression: panic on Fn+F7 hotkey

[Sérgio Monteiro Basto]

Hi
Pressing Fn+F7 doesnt seems to be in boot time.
For me acpi_ec_gpe_query.patch in 2.4.23-pre8, hangs my laptop when I
press lid button, after boot and after login after enter in X, after all
things up.  

On Tue, 2003-10-28 at 02:30, Li, Shaohua wrote:
> Hi,
>   Which time did the panic occur? Boot time? Yes, I made the patch to fix some boot time errors. 
> But if boot is ok, the patch should not impact anything.

but have a lot of impact.
in my case, boots without problems. 

Please give me more info.
> 
> Thanks,
> Shaohua
> 
> 
> > -----Original Message-----
> > From: acpi-devel-admin-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org [mailto:acpi-devel-
> > admin-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org] On Behalf Of Karol Kozimor
> > Sent: 2003年10月28日 1:08
> > To: acpi-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org
> > Subject: [ACPI] 2.6.0-test9 regression: panic on Fn+F7 hotkey
> > 
> > Hi,
> > Pressing Fn+F7 to turn the LCD on / off causes 2.6.0-test9 to panic.
> > That's
> > AFAIK the single event that causes such a behaviour, other keys work fine.
> > Reverting the acpi_ec_gpe_query.patchi[1] fixes the issue and makes the
> > kernel
> > run fine.
> > 
> > [1]:
> > http://www.kernel.org/pub/linux/kernel/people/lenb/acpi/patches/test/2.4.2
> > 2/20031017152411-acpi_ec_gpe_query.patch
> > 
> > Best regards,
> > 
> > --
> > Karol 'sziwan' Kozimor
> > sziwan-DETuoxkZsSqrDJvtcaxF/A@public.gmane.org
> > 
> > 
> > -------------------------------------------------------
> > This SF.net email is sponsored by: The SF.net Donation Program.
> > Do you like what SourceForge.net is doing for the Open
> > Source Community?  Make a contribution, and help us add new
> > features and functionality. Click here: http://sourceforge.net/donate/
> > _______________________________________________
> > Acpi-devel mailing list
> > Acpi-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org
> > https://lists.sourceforge.net/lists/listinfo/acpi-devel
> 
> 
> -------------------------------------------------------
> This SF.net email is sponsored by: The SF.net Donation Program.
> Do you like what SourceForge.net is doing for the Open
> Source Community?  Make a contribution, and help us add new
> features and functionality. Click here: http://sourceforge.net/donate/
> _______________________________________________
> Acpi-devel mailing list
> Acpi-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org
> https://lists.sourceforge.net/lists/listinfo/acpi-devel
-- 
SérgioMB
email: sergiomb-hHo3WeeoaswVhHzd4jOs4w@public.gmane.org

Who gives me one shell, give me everything.



-------------------------------------------------------
This SF.net email is sponsored by: The SF.net Donation Program.
Do you like what SourceForge.net is doing for the Open
Source Community?  Make a contribution, and help us add new
features and functionality. Click here: http://sourceforge.net/donate/

2.6.0-test9 regression: panic on Fn+F7 hotkey

[Karol Kozimor]

Hi,
Pressing Fn+F7 to turn the LCD on / off causes 2.6.0-test9 to panic. That's
AFAIK the single event that causes such a behaviour, other keys work fine.
Reverting the acpi_ec_gpe_query.patchi[1] fixes the issue and makes the kernel
run fine.

[1]:
http://www.kernel.org/pub/linux/kernel/people/lenb/acpi/patches/test/2.4.22/20031017152411-acpi_ec_gpe_query.patch

Best regards,

-- 
Karol 'sziwan' Kozimor
sziwan-DETuoxkZsSqrDJvtcaxF/A@public.gmane.org


-------------------------------------------------------
This SF.net email is sponsored by: The SF.net Donation Program.
Do you like what SourceForge.net is doing for the Open
Source Community?  Make a contribution, and help us add new
features and functionality. Click here: http://sourceforge.net/donate/

Re: 2.6.0-test9 regression: panic on Fn+F7 hotkey

[Luca Capello]

Hello, maybe it could be useful even if the thread is (quite) old.

on 10/27/03 18:08, Karol Kozimor wrote:
> Pressing Fn+F7 to turn the LCD on / off causes 2.6.0-test9 to panic.
I've an ASUS Centrino M3N, bios 0203A (20030514), Debian 
testing/unstable, kernel 2.6.0-test9 w/ ACPI 20031002. When I press 
Fn+F7 the LCD correctly switchs on/off and I don't have any kernel panic.

Just you to know :-)

Thx, bye,
Gismo / Luca



-------------------------------------------------------
This SF.net email is sponsored by: SF.net Giveback Program.
Does SourceForge.net help you be more productive?  Does it
help you create better code?   SHARE THE LOVE, and help us help
YOU!  Click Here: http://sourceforge.net/donate/

Re: 2.6.0-test9 regression: panic on Fn+F7 hotkey

[Nikolaus Filus]

On Mon, Nov 03, 2003 at 10:37:48AM +0100, Luca Capello wrote:
>Hello, maybe it could be useful even if the thread is (quite) old.
>
>on 10/27/03 18:08, Karol Kozimor wrote:
>>Pressing Fn+F7 to turn the LCD on / off causes 2.6.0-test9 to panic.
>I've an ASUS Centrino M3N, bios 0203A (20030514), Debian 
>testing/unstable, kernel 2.6.0-test9 w/ ACPI 20031002. When I press 
>Fn+F7 the LCD correctly switchs on/off and I don't have any kernel panic.
>
>Just you to know :-)


BTW: Is this a general ACPI feature or BIOS-related? I mean, I have a
Toshiba Satellite 3000-601 and was NEVER able to switch to/from external vga
using linux (no 2.4 and no 2.6 version!). The display freezes, the fan goes
on and that was it .... :(


-------------------------------------------------------
This SF.net email is sponsored by: SF.net Giveback Program.
Does SourceForge.net help you be more productive?  Does it
help you create better code?   SHARE THE LOVE, and help us help
YOU!  Click Here: http://sourceforge.net/donate/

Re: 2.6.0-test9 regression: panic on Fn+F7 hotkey

[Ducrot Bruno]

On Mon, Nov 03, 2003 at 11:58:03AM +0100, Nikolaus Filus wrote:
> On Mon, Nov 03, 2003 at 10:37:48AM +0100, Luca Capello wrote:
> >Hello, maybe it could be useful even if the thread is (quite) old.
> >
> >on 10/27/03 18:08, Karol Kozimor wrote:
> >>Pressing Fn+F7 to turn the LCD on / off causes 2.6.0-test9 to panic.
> >I've an ASUS Centrino M3N, bios 0203A (20030514), Debian 
> >testing/unstable, kernel 2.6.0-test9 w/ ACPI 20031002. When I press 
> >Fn+F7 the LCD correctly switchs on/off and I don't have any kernel panic.
> >
> >Just you to know :-)
> 
> 
> BTW: Is this a general ACPI feature or BIOS-related? I mean, I have a
> Toshiba Satellite 3000-601 and was NEVER able to switch to/from external vga
> using linux (no 2.4 and no 2.6 version!). The display freezes, the fan goes
> on and that was it .... :(
> 

That depend.  For the Satellite 3000-601, this is even the two:
the toshiba will got an acpi event from the embeded controller
and the portion of the AML related to will call a smi handler...

-- 
Ducrot Bruno

--  Which is worse:  ignorance or apathy?
--  Don't know.  Don't care.


-------------------------------------------------------
This SF.net email is sponsored by: SF.net Giveback Program.
Does SourceForge.net help you be more productive?  Does it
help you create better code?   SHARE THE LOVE, and help us help
YOU!  Click Here: http://sourceforge.net/donate/

Re: 2.6.0-test9 regression: panic on Fn+F7 hotkey

[Luca Capello]

Hello,

on 11/03/03 11:58, Nikolaus Filus wrote:
> BTW: Is this a general ACPI feature or BIOS-related? I mean, I have a
> Toshiba Satellite 3000-601 and was NEVER able to switch to/from external vga
> using linux (no 2.4 and no 2.6 version!). The display freezes, the fan goes
> on and that was it .... :(
IIRC, on ASUS laptops you can use Fn+F7 hotkey even if you don't install 
the 'acpi4asus' package: I just tried removing the 'asus_acpi' module 
and Fn+F7 works. With the 'asus_acpi' module you've notification of 
Fn+F7 hotkey pressing in /var/log/acpid, so you can configure an action 
when you press this hotkey.

I don't remember when I didn't have ACPI on my 2.4.21 what happened: I 
think it's a BIOS-related feature, not an ACPI one, but I'm not sure.

Thx, bye,
Gismo / Luca



-------------------------------------------------------
This SF.net email is sponsored by: SF.net Giveback Program.
Does SourceForge.net help you be more productive?  Does it
help you create better code?   SHARE THE LOVE, and help us help
YOU!  Click Here: http://sourceforge.net/donate/

Re: 2.6.0-test9 regression: panic on Fn+F7 hotkey

[Karol Kozimor]

Thus wrote Luca Capello:
> IIRC, on ASUS laptops you can use Fn+F7 hotkey even if you don't install 
> the 'acpi4asus' package: I just tried removing the 'asus_acpi' module 
> and Fn+F7 works. With the 'asus_acpi' module you've notification of 
> Fn+F7 hotkey pressing in /var/log/acpid, so you can configure an action 
> when you press this hotkey.

Fn+F7 is completely AML-dependent, asus_acpi has nothing to do with it.
Best regards,

-- 
Karol 'sziwan' Kozimor
sziwan-DETuoxkZsSqrDJvtcaxF/A@public.gmane.org


-------------------------------------------------------
This SF.net email is sponsored by: SF.net Giveback Program.
Does SourceForge.net help you be more productive?  Does it
help you create better code?   SHARE THE LOVE, and help us help
YOU!  Click Here: http://sourceforge.net/donate/