Re: [Fwd: [PATCH] Don't save state in ACPI on shutdown/reboot]

[Ducrot Bruno <ducrot-kk6yZipjEM5g9hUCZPvPmw@public.gmane.org>]

On Wed, Nov 12, 2003 at 10:05:59PM +0000, Dave Jones wrote:
> On Tue, Nov 11, 2003 at 06:00:35PM +0100, Ducrot Bruno wrote:
> 
>  > > The ACPI code in 2.4 currently saves the machine state as for a 
>  > > suspend when doing an reboot or shutdown. This fails on x86-64
>  > > on some boxes.
>  > > 
>  > > Don't save/restore state in ACPI when entering S5.
>  > 
>  > That break also some i386 boxes.  That why I submitted another patch (do
>  > I have to post it again?)
> 
> Do you mean Andi's patch breaks i386 boxes, or this bug also appears
> on i386 ? The former seems unlikely from the look of Andi's patch.
> 

I wanted to point that some i386 boxes are broken as well, and
then a patch is needed.  And yes, when I read again my email, that
a bit confusing.

The patch I send actually implement the exact same
behaviour of 2.6 (minus S5 via the proc file, disabled on 2.6).

Also, it is much likely a design fix.  'power off' shall not
be dependant of CONFIG_ACPI_SLEEP (even though than one is always
yes for 2.4 if CONFIG_ACPI, at least on i386).

Cheers,

-- 
Ducrot Bruno

--  Which is worse:  ignorance or apathy?
--  Don't know.  Don't care.


-------------------------------------------------------
This SF.Net email sponsored by: ApacheCon 2003,
16-19 November in Las Vegas. Learn firsthand the latest
developments in Apache, PHP, Perl, XML, Java, MySQL,
WebDAV, and more! http://www.apachecon.com/