All 2.4.22 patches after 09-16 broken?

All 2.4.22 patches after 09-16 broken?

[Marcel Meckel]

Hello,

can someone confirm this strange behaviour:

I patched vanilla 2.4.22 kernel with acpi-20031002-2.4.22.diff, ran 
make xconfig. In menu "character devices" i see option
"/dev/agpgart (AGP Support)" twice, one as bool one as tristate option. 
Without changing an option (and without .config of course) i get this 
error after pressing "Save and Exit" Button:

Error in Tcl Script
Error: can't read "CONFIG_SCSI": no such variable

ERROR - Attempting to write value for unconfigured variable 
(CONFIG_PARPORT_PC_CML1).

Stack trace says:

can't read "CONFIG_SCSI": no such variable
    while executing
"list $CONFIG_BLK_CPQ_CISS_DA $CONFIG_SCSI"
    (procedure "writeconfig" line 672)
    invoked from within
"writeconfig .config include/linux/autoconf.h"
    invoked from within
".f0.right.save invoke"
    ("uplevel" body line 1)
    invoked from within
"uplevel #0 [list $w invoke]"
    (procedure "tkButtonUp" line 7)
    invoked from within
"tkButtonUp .f0.right.save
"
    (command bound to event)

Not necessary to say that this does not happen with vanilla kernel 
neighter with acpi-20030916-2.4.22.diff from sourceforge ftp.

Checked this with acpi-20030918-2.4.22.diff too, same strange result.

Someone an idea what's going wrong here?

(Didn't want to open a new bug unless i am 100% sure it's a bug in the 
patch)

Greetings,
Marcel.



-------------------------------------------------------
This SF.net email is sponsored by: SF.net Giveback Program.
Does SourceForge.net help you be more productive?  Does it
help you create better code?  SHARE THE LOVE, and help us help
YOU!  Click Here: http://sourceforge.net/donate/

Re: All 2.4.22 patches after 09-16 broken?

[Micha Feigin]

On Thu, Nov 20, 2003 at 08:53:16AM +0100, Marcel Meckel wrote:
> Hello,
> 
> can someone confirm this strange behaviour:
> 
> I patched vanilla 2.4.22 kernel with acpi-20031002-2.4.22.diff, ran 
> make xconfig. In menu "character devices" i see option
> "/dev/agpgart (AGP Support)" twice, one as bool one as tristate option. 
> Without changing an option (and without .config of course) i get this 
> error after pressing "Save and Exit" Button:
> 
> Error in Tcl Script
> Error: can't read "CONFIG_SCSI": no such variable
> 

I had this error too. Using make menuconfig seemed to work OK though.
I got this error also with when firing up xconfig and immediately exiting
with a valid .config

> ERROR - Attempting to write value for unconfigured variable 
> (CONFIG_PARPORT_PC_CML1).
> 
> Stack trace says:
> 
> can't read "CONFIG_SCSI": no such variable
>     while executing
> "list $CONFIG_BLK_CPQ_CISS_DA $CONFIG_SCSI"
>     (procedure "writeconfig" line 672)
>     invoked from within
> "writeconfig .config include/linux/autoconf.h"
>     invoked from within
> ".f0.right.save invoke"
>     ("uplevel" body line 1)
>     invoked from within
> "uplevel #0 [list $w invoke]"
>     (procedure "tkButtonUp" line 7)
>     invoked from within
> "tkButtonUp .f0.right.save
> "
>     (command bound to event)
> 
> Not necessary to say that this does not happen with vanilla kernel 
> neighter with acpi-20030916-2.4.22.diff from sourceforge ftp.
> 
> Checked this with acpi-20030918-2.4.22.diff too, same strange result.
> 
> Someone an idea what's going wrong here?
> 
> (Didn't want to open a new bug unless i am 100% sure it's a bug in the 
> patch)
> 
> Greetings,
> Marcel.
> 
> 
> 
> -------------------------------------------------------
> This SF.net email is sponsored by: SF.net Giveback Program.
> Does SourceForge.net help you be more productive?  Does it
> help you create better code?  SHARE THE LOVE, and help us help
> YOU!  Click Here: http://sourceforge.net/donate/
> _______________________________________________
> Acpi-devel mailing list
> Acpi-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org
> https://lists.sourceforge.net/lists/listinfo/acpi-devel
> 


-------------------------------------------------------
This SF.net email is sponsored by: SF.net Giveback Program.
Does SourceForge.net help you be more productive?  Does it
help you create better code?  SHARE THE LOVE, and help us help
YOU!  Click Here: http://sourceforge.net/donate/

Re: All 2.4.22 patches after 09-16 broken?

[Matthew Wilcox]

On Thu, Nov 20, 2003 at 08:53:16AM +0100, Marcel Meckel wrote:
> I patched vanilla 2.4.22 kernel with acpi-20031002-2.4.22.diff, ran 
> make xconfig. In menu "character devices" i see option
> "/dev/agpgart (AGP Support)" twice, one as bool one as tristate option. 
> Without changing an option (and without .config of course) i get this 
> error after pressing "Save and Exit" Button:
> 
> Error in Tcl Script
> Error: can't read "CONFIG_SCSI": no such variable
> 
> ERROR - Attempting to write value for unconfigured variable 
> (CONFIG_PARPORT_PC_CML1).

Maybe the tk program is having trouble parsing this:

+  else if [ "$CONFIG_SMP" = "y" ]; then

Can you try changing that line in drivers/acpi/Config.in by putting a
new line between the `else' and the `if'?  ie make it look like:
  else
    if [ "$CONFIG_SMP" = "y" ]; then

-- 
"It's not Hollywood.  War is real, war is primarily not about defeat or
victory, it is about death.  I've seen thousands and thousands of dead bodies.
Do you think I want to have an academic debate on this subject?" -- Robert Fisk


-------------------------------------------------------
This SF.net email is sponsored by: SF.net Giveback Program.
Does SourceForge.net help you be more productive?  Does it
help you create better code?  SHARE THE LOVE, and help us help
YOU!  Click Here: http://sourceforge.net/donate/

Re: All 2.4.22 patches after 09-16 broken?

[Marcel Meckel]

> > Error in Tcl Script
> > Error: can't read "CONFIG_SCSI": no such variable
> > 
> > ERROR - Attempting to write value for unconfigured variable 
> > (CONFIG_PARPORT_PC_CML1).
> 
> Maybe the tk program is having trouble parsing this:
> 
> +  else if [ "$CONFIG_SMP" = "y" ]; then
> 
> Can you try changing that line in drivers/acpi/Config.in by putting a
> new line between the `else' and the `if'?  ie make it look like:
>   else
>     if [ "$CONFIG_SMP" = "y" ]; then

Thanks, that's it! Please correct the patches after 09-16 or
release a new one :)

Greetings from germany,
Marcel.


-------------------------------------------------------
This SF.net email is sponsored by: SF.net Giveback Program.
Does SourceForge.net help you be more productive?  Does it
help you create better code?  SHARE THE LOVE, and help us help
YOU!  Click Here: http://sourceforge.net/donate/

Fix xconfig in 2.4-ACPI latest

[Matthew Wilcox]

On Thu, Nov 20, 2003 at 04:32:00PM +0000, Matthew Wilcox wrote:
> Maybe the tk program is having trouble parsing this:
> 
> +  else if [ "$CONFIG_SMP" = "y" ]; then

I just figured out why I couldn't reproduce this problem.  Oops.
Len, can you apply this patch for 2.4 ASAP?  Otherwise people
using xconfig won't be able to configure their kernels.

diff -u b/drivers/acpi/Config.in linux-2.4/drivers/acpi/Config.in
--- b/drivers/acpi/Config.in    Wed Oct  1 01:10:29 2003
+++ linux-2.4/drivers/acpi/Config.in    20 Nov 2003 21:45:57 -0000
@@ -32,7 +32,8 @@
     tristate     '  Toshiba Laptop Extras'     CONFIG_ACPI_TOSHIBA
     bool         '  Debug Statements'  CONFIG_ACPI_DEBUG
     bool         '  Relaxed AML Checking'      CONFIG_ACPI_RELAXED_AML
-  else if [ "$CONFIG_SMP" = "y" ]; then
+  else
+    if [ "$CONFIG_SMP" = "y" ]; then
       define_bool CONFIG_ACPI_BOOT             y
     fi
   fi

-- 
"It's not Hollywood.  War is real, war is primarily not about defeat or
victory, it is about death.  I've seen thousands and thousands of dead bodies.
Do you think I want to have an academic debate on this subject?" -- Robert Fisk


-------------------------------------------------------
This SF.net email is sponsored by: SF.net Giveback Program.
Does SourceForge.net help you be more productive?  Does it
help you create better code?  SHARE THE LOVE, and help us help
YOU!  Click Here: http://sourceforge.net/donate/

RE: All 2.4.22 patches after 09-16 broken?

[Brown, Len]

Thanks for reporting this one Marcel, and thanks for the quick response
Matt!

Turns out this fix went into 2.4.23 in October.  As it went directly to
Marcelo instead of through me, it wasn't in our 2.4.22 ACPI patch.  So
I've updated the 2.4.22 ACPI patch on kernel.org, and will update the
2.4.22 release tree on bkbits when the nice person pulling it via modem
finishes and unlocks the repo...)

Thanks,
-Len


> -----Original Message-----
> From: acpi-devel-admin-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org 
> [mailto:acpi-devel-admin-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org] On Behalf Of 
> Matthew Wilcox
> Sent: Thursday, November 20, 2003 11:32 AM
> To: Marcel Meckel
> Cc: acpi-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org
> Subject: Re: [ACPI] All 2.4.22 patches after 09-16 broken?
> 
> 
> On Thu, Nov 20, 2003 at 08:53:16AM +0100, Marcel Meckel wrote:
> > I patched vanilla 2.4.22 kernel with acpi-20031002-2.4.22.diff, ran 
> > make xconfig. In menu "character devices" i see option
> > "/dev/agpgart (AGP Support)" twice, one as bool one as 
> tristate option. 
> > Without changing an option (and without .config of course) 
> i get this 
> > error after pressing "Save and Exit" Button:
> > 
> > Error in Tcl Script
> > Error: can't read "CONFIG_SCSI": no such variable
> > 
> > ERROR - Attempting to write value for unconfigured variable 
> > (CONFIG_PARPORT_PC_CML1).
> 
> Maybe the tk program is having trouble parsing this:
> 
> +  else if [ "$CONFIG_SMP" = "y" ]; then
> 
> Can you try changing that line in drivers/acpi/Config.in by putting a
> new line between the `else' and the `if'?  ie make it look like:
>   else
>     if [ "$CONFIG_SMP" = "y" ]; then
> 
> -- 
> "It's not Hollywood.  War is real, war is primarily not about 
> defeat or
> victory, it is about death.  I've seen thousands and 
> thousands of dead bodies.
> Do you think I want to have an academic debate on this 
> subject?" -- Robert Fisk
> 
> 
> -------------------------------------------------------
> This SF.net email is sponsored by: SF.net Giveback Program.
> Does SourceForge.net help you be more productive?  Does it
> help you create better code?  SHARE THE LOVE, and help us help
> YOU!  Click Here: http://sourceforge.net/donate/
> _______________________________________________
> Acpi-devel mailing list
> Acpi-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org
> https://lists.sourceforge.net/lists/listinfo/acpi-devel
> 


-------------------------------------------------------
This SF.net email is sponsored by: SF.net Giveback Program.
Does SourceForge.net help you be more productive?  Does it
help you create better code?  SHARE THE LOVE, and help us help
YOU!  Click Here: http://sourceforge.net/donate/