From mboxrd@z Thu Jan 1 00:00:00 1970 From: Pavel Machek Subject: Re: Tell user when ACPI is killing machine Date: Fri, 28 Nov 2003 17:52:46 +0100 Sender: acpi-devel-admin-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org Message-ID: <20031128165246.GA323@elf.ucw.cz> References: <20031128145558.GA576@elf.ucw.cz> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <20031128145558.GA576-I/5MKhXcvmPrBKCeMvbIDA@public.gmane.org> Errors-To: acpi-devel-admin-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org List-Help: List-Post: List-Subscribe: , List-Unsubscribe: , List-Archive: To: ACPI mailing list , kernel list , len.brown-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org, Rusty trivial patch monkey Russell List-Id: linux-acpi@vger.kernel.org Hi! > On critical overheat (or perceived critical overheat -- acpi bioses on > some notebooks apparently report bogus values from time to time), > kernel itself calls /sbin/halt *without telling anything*. User can > not see anything, his machine just shuts down cleanly. Bad. > > We should at least tell the user what is going on... Okay, I had two bugs in single line of code (%ld and KELVIN_TO_CELSIUS). Sorry about that, here's better version. Pavel --- clean/drivers/acpi/thermal.c 2003-07-27 22:31:09.000000000 +0200 +++ linux/drivers/acpi/thermal.c 2003-11-28 17:42:17.000000000 +0100 @@ -467,6 +474,7 @@ if (result) return_VALUE(result); + printk(KERN_EMERG "Critical temperature reached (%ld C), shutting down.\n", KELVIN_TO_CELSIUS(tz->temperature)); acpi_bus_generate_event(device, ACPI_THERMAL_NOTIFY_CRITICAL, tz->trips.critical.flags.enabled); acpi_thermal_call_usermode(ACPI_THERMAL_PATH_POWEROFF); -- When do you have a heart between your knees? [Johanka's followup: and *two* hearts?] ------------------------------------------------------- This SF.net email is sponsored by: SF.net Giveback Program. Does SourceForge.net help you be more productive? Does it help you create better code? SHARE THE LOVE, and help us help YOU! Click Here: http://sourceforge.net/donate/