Re: Tell user when ACPI is killing machine

Pavel Machek
2003-11-28T16:52:46Z

Hi!

> On critical overheat (or perceived critical overheat -- acpi bioses on
> some notebooks apparently report bogus values from time to time),
> kernel itself calls /sbin/halt *without telling anything*. User can
> not see anything, his machine just shuts down cleanly. Bad.
>
> We should at least tell the user what is going on...

Okay, I had two bugs in single line of code (%ld and
KELVIN_TO_CELSIUS). Sorry about that, here's better version.

Pavel

--- clean/drivers/acpi/thermal.c 2003-07-27 22:31:09.000000000 +0200
+++ linux/drivers/acpi/thermal.c 2003-11-28 17:42:17.000000000 +0100
@@ -467,6 +474,7 @@
if (result)
return_VALUE(result);

+ printk(KERN_EMERG "Critical temperature reached (%ld C), shutting down.\n", KELVIN_TO_CELSIUS(tz->temperature));
acpi_bus_generate_event(device, ACPI_THERMAL_NOTIFY_CRITICAL, tz->trips.critical.flags.enabled);

acpi_thermal_call_usermode(ACPI_THERMAL_PATH_POWEROFF);

--
When do you have a heart between your knees?
[Johanka's followup: and *two* hearts?]