Re: [patch] remove null-ifiers

[Nate Lawson <nate-Y6VGUYTwhu0@public.gmane.org>]

On Tue, 27 Jan 2004, Karol Kozimor wrote:
> Thus wrote Jes Sorensen:
> > diff -urN -X /usr/people/jes/exclude-linux orig/linux-2.6.1-mm3-boot/drivers/acpi/asus_acpi.c linux-2.6.1-mm3/drivers/acpi/asus_acpi.c
> > --- orig/linux-2.6.1-mm3-boot/drivers/acpi/asus_acpi.c	Wed Dec 17 18:58:39 2003
> > +++ linux-2.6.1-mm3/drivers/acpi/asus_acpi.c	Wed Jan 14 05:00:01 2004
> > @@ -73,8 +73,8 @@
> >  MODULE_LICENSE("GPL");
> >
> >
> > -static uid_t asus_uid = 0;
> > -static gid_t asus_gid = 0;
> > +static uid_t asus_uid;
> > +static gid_t asus_gid;
> >  MODULE_PARM(asus_uid, "i");
> >  MODULE_PARM_DESC(uid, "UID for entries in /proc/acpi/asus.\n");
> >  MODULE_PARM(asus_gid, "i");
>
> We certainly *don't* want to do that, last time I checked C did not
> actually guarantee to zero out uninitialized variables -- unless it's
> different in the kernelspace. Are you sure pointers are initialized as
> NULLs?

Static variables have always been guaranteed to be initialized to 0, at
least since K&R.

-Nate


-------------------------------------------------------
The SF.Net email is sponsored by EclipseCon 2004
Premiere Conference on Open Tools Development and Integration
See the breadth of Eclipse activity. February 3-5 in Anaheim, CA.
http://www.eclipsecon.org/osdn