public inbox for linux-acpi@vger.kernel.org
 help / color / mirror / Atom feed
From: Matthew Wilcox <willy-8fiUuRrzOP0dnm+yROfE0A@public.gmane.org>
To: Jes Sorensen
	<jes-dtAfj9ClZIwnoBwkMbRkTB2eb7JE58TQ@public.gmane.org>,
	acpi-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org,
	len.brown-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org
Subject: Re: [patch] remove null-ifiers
Date: Tue, 27 Jan 2004 15:43:14 +0000	[thread overview]
Message-ID: <20040127154314.GY11844@parcelfarce.linux.theplanet.co.uk> (raw)
In-Reply-To: <20040127150954.GA12740-DETuoxkZsSqrDJvtcaxF/A@public.gmane.org>

On Tue, Jan 27, 2004 at 04:09:55PM +0100, Karol Kozimor wrote:
> > -static uid_t asus_uid = 0;
> > -static gid_t asus_gid = 0;
> > +static uid_t asus_uid;
> > +static gid_t asus_gid;
> 
> We certainly *don't* want to do that, last time I checked C did not
> actually guarantee to zero out uninitialized variables -- unless it's
> different in the kernelspace. Are you sure pointers are initialized as
> NULLs?

Looks like you checked the wrong standard then.  Global variables are
guaranteed to be zeroed, stack variables (ie function-local) have the
behaviour you described.  Jes' patch is correct.

-- 
"Next the statesmen will invent cheap lies, putting the blame upon 
the nation that is attacked, and every man will be glad of those
conscience-soothing falsities, and will diligently study them, and refuse
to examine any refutations of them; and thus he will by and by convince 
himself that the war is just, and will thank God for the better sleep 
he enjoys after this process of grotesque self-deception." -- Mark Twain


-------------------------------------------------------
The SF.Net email is sponsored by EclipseCon 2004
Premiere Conference on Open Tools Development and Integration
See the breadth of Eclipse activity. February 3-5 in Anaheim, CA.
http://www.eclipsecon.org/osdn

  parent reply	other threads:[~2004-01-27 15:43 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-01-14 13:15 [patch] remove null-ifiers Jes Sorensen
     [not found] ` <E1AgkrW-00080w-00-uLT3q8aHQDsX9StFTm9pZA@public.gmane.org>
2004-01-26 20:58   ` Len Brown
2004-01-27 15:09   ` Karol Kozimor
     [not found]     ` <20040127150954.GA12740-DETuoxkZsSqrDJvtcaxF/A@public.gmane.org>
2004-01-27 15:15       ` Jes Sorensen
     [not found]         ` <16406.32889.922823.45313-4mDQ13Tdud8Jw5R7aSpS0dP8p4LwMBBS@public.gmane.org>
2004-01-27 15:31           ` John Belmonte
     [not found]             ` <40168442.7020806-wanGne27zNesTnJN9+BGXg@public.gmane.org>
2004-01-27 15:35               ` Jes Sorensen
     [not found]                 ` <16406.34107.51859.924117-4mDQ13Tdud8Jw5R7aSpS0dP8p4LwMBBS@public.gmane.org>
2004-01-30  7:09                   ` Nate Lawson
2004-01-30 14:54               ` Matthew Wilcox
2004-01-27 21:29           ` Karol Kozimor
2004-01-27 15:43       ` Matthew Wilcox [this message]
     [not found]         ` <20040127154314.GY11844-+pPCBgu9SkPzIGdyhVEDUDl5KyyQGfY2kSSpQ9I8OhVaa/9Udqfwiw@public.gmane.org>
2004-01-27 16:44           ` Yury V. Umanets
2004-01-27 20:04       ` Nate Lawson
     [not found]         ` <20040127120357.X37323-Y6VGUYTwhu0@public.gmane.org>
2004-01-27 20:07           ` Karol Kozimor

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20040127154314.GY11844@parcelfarce.linux.theplanet.co.uk \
    --to=willy-8fiuurrzop0dnm+yrofe0a@public.gmane.org \
    --cc=acpi-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org \
    --cc=jes-dtAfj9ClZIwnoBwkMbRkTB2eb7JE58TQ@public.gmane.org \
    --cc=len.brown-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox