[PATCH] acpi_leave_sleep_state (was: [PATCH] Re: [BUG] acpi_hw_[enable|disable]_non_wakeup_gpe_block)

Alexander Malysh
2004-02-15T22:12:52Z

[-- Attachment #1: Type: text/plain, Size: 2478 bytes --]

Hi again,

what are you think about attached patch?

Note: at least on my laptop gpes must be enabled before '_WAK' method
execution, otherwise after '_WAK' was executed interrupts are enabled and gpe
register were restored with wrong values...

@Karol: can you please get this patch a try?

On Sunday 15 February 2004 22:00, Alexander Malysh wrote:
> On Sunday 15 February 2004 21:07, you wrote:
> > On Sun, Feb 15, 2004 at 04:47:19PM +0100, Alexander Malysh wrote:
> > > Hi again,
> > >
> > > after some more testing, I have found a cause for this.
> > > We disable non wakeup gpes (and store those values) with interrupts
> > > disabled, but enable those with interrupts enabled which were already
> > > overwritten while handling of wakeup interrupt[1]. So we must restore
> > > non wakeup gpes as long interrupts are disabled. Attached patch should
> > > fix it.
> > >
> > >
> > > --- linux-2.6.2-linus/drivers/acpi/hardware/hwsleep.c~orig 2004-02-15
> > > 16:31:50.928455040 +0100 +++
> > > linux-2.6.2-linus/drivers/acpi/hardware/hwsleep.c 2004-02-15
> > > 16:35:30.030146520 +0100 @@ -342,6 +342,12 @@
> > >
> > > } while (!in_value);
> > >
> > > + /* Enable non_wakeup_gpes as long interrupts are disabled */
> > > + status = acpi_hw_enable_non_wakeup_gpes ();
> > > + if (ACPI_FAILURE (status)) {
> > > + return_ACPI_STATUS (status);
> > > + }
> > > +
> > > return_ACPI_STATUS (AE_OK);
> >
> > First, this path is *never reached* for S3 and S4, so you break somehow
> > S3 and S4 in fact...
>
> hmm, where do we jump after wakeup from S3/S4 ?
>
> > Second, the path for which you remove the enable gpes is supposed to be
> > run with interrupt *dissabled*. If that is not the case, then it is the
> > real bug in fact.
>
> as you can see from log (or in drivers/acpi/sleep/main.c)
> acpi_leave_sleep_state called with interrupts enabled.
> and you are right: acpi_leave_sleep_state _must_ be called with interrupts
> disabled, so no wonder why sleep/resume fail on many laptops :(
>
>
>
> -------------------------------------------------------
> SF.Net is sponsored by: Speed Start Your Linux Apps Now.
> Build and deploy apps & Web services for Linux with
> a free DVD software kit from IBM. Click Now!
> http://ads.osdn.com/?ad_id=1356&alloc_id=3438&op=click
> _______________________________________________
> Acpi-devel mailing list
> Acpi-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org
> https://lists.sourceforge.net/lists/listinfo/acpi-devel

[-- Attachment #2: acpi_leave_sleep_state.diff --]
[-- Type: text/x-diff, Size: 1608 bytes --]

--- linux-2.6.2-linus/drivers/acpi/hardware/hwsleep.c~orig 2004-02-15 16:31:50.000000000 +0100
+++ linux-2.6.2-linus/drivers/acpi/hardware/hwsleep.c 2004-02-15 23:03:41.522301504 +0100
@@ -477,6 +477,11 @@

/* Ignore any errors from these methods */

+ status = acpi_hw_enable_non_wakeup_gpes ();
+ if (ACPI_FAILURE (status)) {
+ ACPI_REPORT_ERROR(("Could not enable non wakeup gpes, %s\n", acpi_format_exception (status)));
+ }
+
arg.integer.value = 0;
status = acpi_evaluate_object (NULL, "\\_SI._SST", &arg_list, NULL);
if (ACPI_FAILURE (status) && status != AE_NOT_FOUND) {
@@ -496,11 +501,6 @@

/* _WAK returns stuff - do we want to look at it? */

- status = acpi_hw_enable_non_wakeup_gpes ();
- if (ACPI_FAILURE (status)) {
- return_ACPI_STATUS (status);
- }
-
/* Enable BM arbitration */

status = acpi_set_register (ACPI_BITREG_ARB_DISABLE, 0, ACPI_MTX_LOCK);
--- linux-2.6.2-linus/drivers/acpi/sleep/main.c~orig 2004-02-15 23:03:49.543082160 +0100
+++ linux-2.6.2-linus/drivers/acpi/sleep/main.c 2004-02-15 23:04:14.258324872 +0100
@@ -107,7 +107,6 @@
default:
return -EINVAL;
}
- local_irq_restore(flags);
printk(KERN_DEBUG "Back to C!\n");

/* restore processor state
@@ -118,6 +117,8 @@
if (state > PM_SUSPEND_STANDBY)
acpi_restore_state_mem();

+ acpi_leave_sleep_state(state);
+ local_irq_restore(flags);

return ACPI_SUCCESS(status) ? 0 : -EFAULT;
}
@@ -133,8 +134,6 @@

static int acpi_pm_finish(u32 state)
{
- acpi_leave_sleep_state(state);
-
/* reset firmware waking vector */
acpi_set_firmware_waking_vector((acpi_physical_address) 0);