[PATCH] Discover ACPI serial ports before plug-in ports

[PATCH] Discover ACPI serial ports before plug-in ports

[Bjorn Helgaas]

I propose the following patch (against 2.6.2).  This makes us
discover ACPI serial ports before PCI ones.  The ACPI ports
tend to be built-in, and discovering them late means their ttyS
names move around if PCI serial ports are added or removed.  I
think it makes more sense to have relatively predictable and
consistent names for the built-in hardware.

===== drivers/serial/Makefile 1.20 vs edited =====
--- 1.20/drivers/serial/Makefile	Tue Sep  9 03:30:53 2003
+++ edited/drivers/serial/Makefile	Tue Feb 10 15:46:15 2004
@@ -5,11 +5,11 @@
 #
 
 serial-8250-y :=
+serial-8250-$(CONFIG_SERIAL_8250_ACPI) += 8250_acpi.o
 serial-8250-$(CONFIG_GSC) += 8250_gsc.o
 serial-8250-$(CONFIG_PCI) += 8250_pci.o
 serial-8250-$(CONFIG_PNP) += 8250_pnp.o
 serial-8250-$(CONFIG_SERIAL_8250_HCDP) += 8250_hcdp.o
-serial-8250-$(CONFIG_SERIAL_8250_ACPI) += 8250_acpi.o
 
 obj-$(CONFIG_SERIAL_CORE) += serial_core.o
 obj-$(CONFIG_SERIAL_21285) += 21285.o



-------------------------------------------------------
The SF.Net email is sponsored by EclipseCon 2004
Premiere Conference on Open Tools Development and Integration
See the breadth of Eclipse activity. February 3-5 in Anaheim, CA.
http://www.eclipsecon.org/osdn

Re: [PATCH] Discover ACPI serial ports before plug-in ports

[Russell King]

On Tue, Feb 10, 2004 at 04:11:22PM -0700, Bjorn Helgaas wrote:
> I propose the following patch (against 2.6.2).  This makes us
> discover ACPI serial ports before PCI ones.  The ACPI ports
> tend to be built-in, and discovering them late means their ttyS
> names move around if PCI serial ports are added or removed.  I
> think it makes more sense to have relatively predictable and
> consistent names for the built-in hardware.

Applied, thanks.

-- 
Russell King
 Linux kernel    2.6 ARM Linux   - http://www.arm.linux.org.uk/
 maintainer of:  2.6 PCMCIA      - http://pcmcia.arm.linux.org.uk/
                 2.6 Serial core