From: Pavel Machek <pavel-AlSwsSmVLrQ@public.gmane.org>
To: Rusty trivial patch monkey Russell
<trivial-8n+1lVoiYb80n/F98K4Iww@public.gmane.org>,
Andrew Morton <akpm-LJ1TwQYPT6cQrrorzV6ljw@public.gmane.org>,
kernel list
<linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
Stefan Seyfried <seife-l3A5Bk7waGM@public.gmane.org>
Cc: acpi-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org
Subject: swsusp/s3: Assembly interactions need asmlinkage
Date: Tue, 24 Feb 2004 14:00:51 +0100 [thread overview]
Message-ID: <20040224130051.GA8964@elf.ucw.cz> (raw)
Hi!
swsusp/s3 assembly parts, and parts called from assembly are not
properly marked asmlinkage; that leads to double fault on resume when
someone compiles kernel with regparm. Thanks go to Stefan Seyfried for
discovering this. Please apply,
Pavel
--- tmp/linux/drivers/acpi/hardware/hwsleep.c 2004-02-05 01:53:59.000000000 +0100
+++ linux/drivers/acpi/hardware/hwsleep.c 2004-02-23 21:47:23.000000000 +0100
@@ -205,7 +205,7 @@
*
******************************************************************************/
-acpi_status
+acpi_status asmlinkage
acpi_enter_sleep_state (
u8 sleep_state)
{
--- tmp/linux/include/linux/suspend.h 2004-02-24 13:21:40.000000000 +0100
+++ linux/include/linux/suspend.h 2004-02-23 20:57:04.000000000 +0100
@@ -82,4 +82,10 @@
}
#endif /* CONFIG_PM */
+asmlinkage extern void do_magic(int is_resume);
+asmlinkage extern void do_magic_resume_1(void);
+asmlinkage extern void do_magic_resume_2(void);
+asmlinkage extern void do_magic_suspend_1(void);
+asmlinkage extern void do_magic_suspend_2(void);
+
#endif /* _LINUX_SWSUSP_H */
--
When do you have a heart between your knees?
[Johanka's followup: and *two* hearts?]
-------------------------------------------------------
SF.Net is sponsored by: Speed Start Your Linux Apps Now.
Build and deploy apps & Web services for Linux with
a free DVD software kit from IBM. Click Now!
http://ads.osdn.com/?ad_id=1356&alloc_id=3438&op=click
next reply other threads:[~2004-02-24 13:00 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-02-24 13:00 Pavel Machek [this message]
[not found] ` <20040224130051.GA8964-I/5MKhXcvmPrBKCeMvbIDA@public.gmane.org>
2004-02-25 8:39 ` swsusp/s3: Assembly interactions need asmlinkage Bruno Ducrot
[not found] ` <20040225083957.GE2869-kk6yZipjEM5g9hUCZPvPmw@public.gmane.org>
2004-02-25 10:11 ` Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040224130051.GA8964@elf.ucw.cz \
--to=pavel-alswssmvlrq@public.gmane.org \
--cc=acpi-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org \
--cc=akpm-LJ1TwQYPT6cQrrorzV6ljw@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=seife-l3A5Bk7waGM@public.gmane.org \
--cc=trivial-8n+1lVoiYb80n/F98K4Iww@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox