From mboxrd@z Thu Jan 1 00:00:00 1970 From: Pavel Machek Subject: Re: swsusp/s3: Assembly interactions need asmlinkage Date: Wed, 25 Feb 2004 11:11:00 +0100 Sender: acpi-devel-admin-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org Message-ID: <20040225101100.GA214@elf.ucw.cz> References: <20040224130051.GA8964@elf.ucw.cz> <20040225083957.GE2869@poupinou.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <20040225083957.GE2869-kk6yZipjEM5g9hUCZPvPmw@public.gmane.org> Errors-To: acpi-devel-admin-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , List-Archive: To: Bruno Ducrot Cc: Rusty trivial patch monkey Russell , Andrew Morton , kernel list , Stefan Seyfried , acpi-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org List-Id: linux-acpi@vger.kernel.org Hi! > > swsusp/s3 assembly parts, and parts called from assembly are not > > properly marked asmlinkage; that leads to double fault on resume when > > someone compiles kernel with regparm. Thanks go to Stefan Seyfried for > > discovering this. Please apply, > > Does acpi_enter_sleep_state_s4bios() have the same issue ? Yes, it does; I missed that. Thanks. Here's the fix. Pavel --- clean/drivers/acpi/hardware/hwsleep.c 2004-02-05 01:53:59.000000000 +0100 +++ linux/drivers/acpi/hardware/hwsleep.c 2004-02-25 11:08:15.000000000 +0100 @@ -359,7 +359,7 @@ * ******************************************************************************/ -acpi_status +acpi_status asmlinkage acpi_enter_sleep_state_s4bios ( void) { -- When do you have a heart between your knees? [Johanka's followup: and *two* hearts?] ------------------------------------------------------- SF.Net is sponsored by: Speed Start Your Linux Apps Now. Build and deploy apps & Web services for Linux with a free DVD software kit from IBM. Click Now! http://ads.osdn.com/?ad_id=1356&alloc_id=3438&op=click