public inbox for linux-acpi@vger.kernel.org
 help / color / mirror / Atom feed
From: Pavel Machek <pavel-+ZI9xUNit7I@public.gmane.org>
To: ACPI mailing list
	<acpi-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org>
Cc: trenn-l3A5Bk7waGM@public.gmane.org,
	behlert-l3A5Bk7waGM@public.gmane.org,
	len.brown-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org
Subject: ACPI C4 support
Date: Sat, 28 Feb 2004 17:10:11 +0100	[thread overview]
Message-ID: <20040228161011.GA10448@elf.ucw.cz> (raw)

Hi!

Thomas told me:

>what about C4 - Cn states in the kernel implementation?
>A short look into the /proc/acpi/processor/.../power file let me think
>that only C0-C3 is supported by the kernel, even specification talks
>about Cn states?

As a first step, it would be nice if kernel at least used C0..C3 if
the machine supports them... This should do the trick. Does it look
okay?

								Pavel

--- tmp/linux/drivers/acpi/processor.c	2004-02-20 12:29:21.000000000 +0100
+++ linux/drivers/acpi/processor.c	2004-02-28 15:30:52.000000000 +0100
@@ -2205,7 +2202,8 @@
 
 	if (!object.processor.pblk_address)
 		ACPI_DEBUG_PRINT((ACPI_DB_INFO, "No PBLK (NULL address)\n"));
-	else if (object.processor.pblk_length != 6)
+	else if (object.processor.pblk_length < 6)
+		/* pblk_length of 7 is okay if cpu supports C4 */
 		ACPI_DEBUG_PRINT((ACPI_DB_ERROR, "Invalid PBLK length [%d]\n",
 			object.processor.pblk_length));
 	else {




-- 
When do you have a heart between your knees?
[Johanka's followup: and *two* hearts?]


-------------------------------------------------------
SF.Net is sponsored by: Speed Start Your Linux Apps Now.
Build and deploy apps & Web services for Linux with
a free DVD software kit from IBM. Click Now!
http://ads.osdn.com/?ad_id=1356&alloc_id=3438&op=click

             reply	other threads:[~2004-02-28 16:10 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-02-28 16:10 Pavel Machek [this message]
     [not found] ` <20040228161011.GA10448-I/5MKhXcvmPrBKCeMvbIDA@public.gmane.org>
2004-03-01 15:28   ` ACPI C4 support Bruno Ducrot
     [not found]     ` <20040301152810.GT2869-kk6yZipjEM5g9hUCZPvPmw@public.gmane.org>
2004-03-01 18:09       ` Stefan Behlert
     [not found]         ` <20040301180958.GI2624-l3A5Bk7waGM@public.gmane.org>
2004-03-01 19:48           ` Bruno Ducrot
     [not found]             ` <20040301194825.GB2869-kk6yZipjEM5g9hUCZPvPmw@public.gmane.org>
2004-03-02 10:17               ` Stefan Behlert
  -- strict thread matches above, loose matches on Subject: below --
2004-03-01 19:03 Grover, Andrew
     [not found] ` <F760B14C9561B941B89469F59BA3A84702C932FD-sBd4vmA9Se4Lll3ZsUKC9FDQ4js95KgL@public.gmane.org>
2004-03-01 19:16   ` Pavel Machek
2004-03-01 19:27   ` Pavel Machek
     [not found]     ` <20040301192738.GA9459-I/5MKhXcvmPrBKCeMvbIDA@public.gmane.org>
2004-03-01 19:39       ` Bruno Ducrot
     [not found]         ` <20040301193917.GA2869-kk6yZipjEM5g9hUCZPvPmw@public.gmane.org>
2004-03-02 22:22           ` Stefan Seyfried
2004-03-01 21:26 Grover, Andrew
     [not found] ` <F760B14C9561B941B89469F59BA3A8470255F035-sBd4vmA9Se4Lll3ZsUKC9FDQ4js95KgL@public.gmane.org>
2004-03-02  9:52   ` Bruno Ducrot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20040228161011.GA10448@elf.ucw.cz \
    --to=pavel-+zi9xunit7i@public.gmane.org \
    --cc=acpi-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org \
    --cc=behlert-l3A5Bk7waGM@public.gmane.org \
    --cc=len.brown-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
    --cc=trenn-l3A5Bk7waGM@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox