From mboxrd@z Thu Jan 1 00:00:00 1970 From: Pavel Machek Subject: ACPI C4 support Date: Sat, 28 Feb 2004 17:10:11 +0100 Sender: acpi-devel-admin-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org Message-ID: <20040228161011.GA10448@elf.ucw.cz> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline Errors-To: acpi-devel-admin-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , List-Archive: To: ACPI mailing list Cc: trenn-l3A5Bk7waGM@public.gmane.org, behlert-l3A5Bk7waGM@public.gmane.org, len.brown-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org List-Id: linux-acpi@vger.kernel.org Hi! Thomas told me: >what about C4 - Cn states in the kernel implementation? >A short look into the /proc/acpi/processor/.../power file let me think >that only C0-C3 is supported by the kernel, even specification talks >about Cn states? As a first step, it would be nice if kernel at least used C0..C3 if the machine supports them... This should do the trick. Does it look okay? Pavel --- tmp/linux/drivers/acpi/processor.c 2004-02-20 12:29:21.000000000 +0100 +++ linux/drivers/acpi/processor.c 2004-02-28 15:30:52.000000000 +0100 @@ -2205,7 +2202,8 @@ if (!object.processor.pblk_address) ACPI_DEBUG_PRINT((ACPI_DB_INFO, "No PBLK (NULL address)\n")); - else if (object.processor.pblk_length != 6) + else if (object.processor.pblk_length < 6) + /* pblk_length of 7 is okay if cpu supports C4 */ ACPI_DEBUG_PRINT((ACPI_DB_ERROR, "Invalid PBLK length [%d]\n", object.processor.pblk_length)); else { -- When do you have a heart between your knees? [Johanka's followup: and *two* hearts?] ------------------------------------------------------- SF.Net is sponsored by: Speed Start Your Linux Apps Now. Build and deploy apps & Web services for Linux with a free DVD software kit from IBM. Click Now! http://ads.osdn.com/?ad_id=1356&alloc_id=3438&op=click