From mboxrd@z Thu Jan 1 00:00:00 1970 From: Willy Tarreau Subject: Re: Re: fix ACPI poweroff in 2.4.25-rc2 Date: Wed, 3 Mar 2004 21:20:27 +0100 Sender: acpi-devel-admin-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org Message-ID: <20040303202027.GA30084@alpha.home.local> References: <200403031117.25937.bjorn.helgaas@hp.com> <20040303194656.GV25779@parcelfarce.linux.theplanet.co.uk> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <20040303194656.GV25779-+pPCBgu9SkPzIGdyhVEDUDl5KyyQGfY2kSSpQ9I8OhVaa/9Udqfwiw@public.gmane.org> Errors-To: acpi-devel-admin-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , List-Archive: To: Matthew Wilcox Cc: Bjorn Helgaas , Marcelo Tosatti , acpi-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org List-Id: linux-acpi@vger.kernel.org Hi, On Wed, Mar 03, 2004 at 07:46:56PM +0000, Matthew Wilcox wrote: > On Wed, Mar 03, 2004 at 11:17:25AM -0700, Bjorn Helgaas wrote: > > ===== drivers/acpi/system.c 1.18 vs edited ===== > > --- 1.18/drivers/acpi/system.c Tue Mar 2 14:50:40 2004 > > +++ edited/drivers/acpi/system.c Wed Mar 3 10:43:11 2004 > > @@ -95,7 +95,9 @@ > > { > > if (unlikely(in_interrupt())) > > BUG(); > > +#ifdef CONFIG_ACPI_SLEEP > > acpi_system_save_state(ACPI_STATE_S5); > > +#endif > > Should we not rather define a null acpi_system_save_state() function if > CONFIG_ACPI_SLEEP is not set? well, since I know of at least one machine on which this patch is not enough, and since Pavel says that it might cause reboots on some systems, I think that this line has a few chances to stay here anyway. I wish I had some time to propose a cleaner version of the patch I sent last week. Zwane proposed to try with set_cpus_allowed(). I don't know if this could work here, because I don't know how to use it. Perhaps something like set_cpus_allowed(boot_cpu) ; schedule() ? Regards, Willy ------------------------------------------------------- This SF.Net email is sponsored by: IBM Linux Tutorials Free Linux tutorial presented by Daniel Robbins, President and CEO of GenToo technologies. Learn everything from fundamentals to system administration.http://ads.osdn.com/?ad_id=1470&alloc_id=3638&op=click