Re: ASUS M6800N: processor has only C1

[Bruno Ducrot <ducrot-kk6yZipjEM5g9hUCZPvPmw@public.gmane.org>]

On Wed, Mar 03, 2004 at 09:18:08PM +0100, Luca Capello wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
> 
> Hello,
> 
> on 03/03/04 11:35, Bruno Ducrot wrote:
> > Thanks.  Sound like that I send only an half patch, sorry.
> nothing changed, well, I got one more error:
> =====
> acpi_processor-2490 [29] acpi_processor_get_inf: Invalid PBLK length [7]
> acpi_processor-0654 [31] acpi_processor_get_pow: Invalid _CST data
> ACPI: Processor [CPU1] (supports C1)
> =====
> 

Could you please try:

--- linux-2.6-bk/drivers/acpi/processor.c	2004/03/04 11:05:47	1.2
+++ linux-2.6-bk/drivers/acpi/processor.c	2004/03/04 11:09:21
@@ -649,8 +649,8 @@ acpi_processor_get_power_info_cst (
 
 	count = cst->package.elements[0].integer.value;
 
-	/* There must be at least 2 power states. */
-	if (count <= 1 || count != cst->package.count - 1) {
+	/* There must be at least one power state (some bios forgot C1), and validate count */
+	if (count < 1 || count != cst->package.count - 1) {
 		ACPI_DEBUG_PRINT((ACPI_DB_ERROR, "Invalid _CST data\n"));
 		status = -EFAULT;
 		goto end;


I think also that the bios will only allow C2, not C3 nor C4 if you are on AC.

Could you then try on battery also?  Note that I have not implemented
yet the reevaluation of _CST in case of AC/battery switch...

-- 
Bruno Ducrot

--  Which is worse:  ignorance or apathy?
--  Don't know.  Don't care.


-------------------------------------------------------
This SF.Net email is sponsored by: IBM Linux Tutorials
Free Linux tutorial presented by Daniel Robbins, President and CEO of
GenToo technologies. Learn everything from fundamentals to system
administration.http://ads.osdn.com/?ad_id=1470&alloc_id=3638&op=click