public inbox for linux-acpi@vger.kernel.org
 help / color / mirror / Atom feed
From: Pavel Machek <pavel-+ZI9xUNit7I@public.gmane.org>
To: "Yu, Luming" <luming.yu-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
Cc: Jakob Praher <jpraher-LWAfsSFWpa4@public.gmane.org>,
	acpi-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org
Subject: Re: thermal shutdown
Date: Thu, 4 Mar 2004 21:07:07 +0100	[thread overview]
Message-ID: <20040304200706.GF531@openzaurus.ucw.cz> (raw)
In-Reply-To: <3ACA40606221794F80A5670F0AF15F8401CBB71C-SRlDPOYGfgogGBtAFL8yw7fspsVTdybXVpNB7YpNyf8@public.gmane.org>

Hi!

> It's known issue!

Well, its broken hw to start with.

> Pavel has the following solution. Let me know whether it works for you

The first hunk is really debugging hack, probably should
be dropped.
				Pavel

> --- clean/drivers/acpi/thermal.c	2004-02-05 01:54:00.000000000
> +0100
> +++ linux/drivers/acpi/thermal.c	2004-02-05 02:24:15.000000000
> +0100
> @@ -223,8 +223,11 @@
>  	tz->last_temperature = tz->temperature;
>  
>  	status = acpi_evaluate_integer(tz->handle, "_TMP", NULL,
> &tz->temperature);
> -	if (ACPI_FAILURE(status))
> +	if (ACPI_FAILURE(status)) {
> +		if (tz->temperature != tz->last_temperature)
> +			printk(KERN_ERR "temperature damaged while
> processing\n");
>  		return -ENODEV;
> +	}
>  
>  	ACPI_DEBUG_PRINT((ACPI_DB_INFO, "Temperature is %lu dK\n",
> tz->temperature));
>  
> @@ -457,7 +460,17 @@
>  		return_VALUE(-EINVAL);
>  
>  	if (tz->temperature >= tz->trips.critical.temperature) {
> +		long old_temperature = tz->temperature;
>  		ACPI_DEBUG_PRINT((ACPI_DB_WARN, "Critical trip
> point\n"));
> +
> +		result = acpi_thermal_get_temperature(tz);
> +		if (!result) {
> +			if (tz->temperature <
> (tz->trips.critical.temperature - 100)) {
> +				printk(KERN_ALERT "ACPI changed its mind
> about temperature, was %ld C, now %ld C", 
> +
> KELVIN_TO_CELSIUS(old_temperature), KELVIN_TO_CELSIUS(tz->temperature));
> +				return_VALUE(0);
> +			}
> +		}
>  		tz->trips.critical.flags.enabled = 1;
>  	}
>  	else if (tz->trips.critical.flags.enabled)
> 
> 
> 
> > -----Original Message-----
> > From: acpi-devel-admin-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org 
> > [mailto:acpi-devel-admin-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org] On Behalf Of 
> > Jakob Praher
> > Sent: Wednesday, March 03, 2004 7:42 PM
> > To: acpi-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org
> > Subject: [ACPI] thermal shutdown
> > 
> > 
> > hi,
> > 
> > my system: 2.6.3 acpi patched
> > 
> > I have noticed, that at some sudden point in time (especially 
> > when I am
> > not working actively ( I mean using input devices )), I receive a
> > thermal shutdown, because of a (false?) temperature value.
> > 
> > looking under /var/log/kern.log I found  
> > 
> > jaques2:/var/log# cat  kern.log | grep  Critical
> > Feb 19 16:11:21 jaques2 kernel: Critical temperature reached (123 C),
> > shutting down.
> > Feb 19 16:11:22 jaques2 kernel: Critical temperature reached (46 C),
> > shutting down.
> > Feb 20 10:47:02 jaques2 kernel: Critical temperature reached (123 C),
> > shutting down.
> > Feb 20 10:47:02 jaques2 kernel: Critical temperature reached (44 C),
> > shutting down.
> > Mar  2 22:38:27 jaques2 kernel: Critical temperature reached (123 C),
> > shutting down.
> > Mar  2 22:38:27 jaques2 kernel: Critical temperature reached (44 C),
> > shutting do
> > 
> > this temperature always happens to be 123 C.
> > How is that possible?
> > I noticed that the acpi_thermal_critical method uses some kind of flag
> > for enabled disabled, but apparently in any case the shutdown 
> > user space
> > app (/sbin/poweroff) is called.
> > Should this only be the case when the temperature is too high and the
> > flag (enabled) is set to != 0? Otherwise, what is the point in the
> > enabled thing. [tz->trips.critical.flags.enabled]
> > 
> > As you can see from my kern.log, the second value is 
> > drastically lower,
> > so could this be a weekness in the system, that one sporadically high
> > value can trigger a shutdown?
> > 
> > thanks
> > -- Jakob
> > 
> > 
> > 
> > 
> > -------------------------------------------------------
> > SF.Net is sponsored by: Speed Start Your Linux Apps Now.
> > Build and deploy apps & Web services for Linux with
> > a free DVD software kit from IBM. Click Now!
> > http://ads.osdn.com/?ad_id=1356&alloc_id=3438&op=click
> > _______________________________________________
> > Acpi-devel mailing list
> > Acpi-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org
> > https://lists.sourceforge.net/lists/listinfo/acpi-devel
> > 
> 
> 
> -------------------------------------------------------
> SF.Net is sponsored by: Speed Start Your Linux Apps Now.
> Build and deploy apps & Web services for Linux with
> a free DVD software kit from IBM. Click Now!
> http://ads.osdn.com/?ad_id\x1356&alloc_id438&op=click
> _______________________________________________
> Acpi-devel mailing list
> Acpi-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org
> https://lists.sourceforge.net/lists/listinfo/acpi-devel

-- 
64 bytes from 195.113.31.123: icmp_seq=28 ttl=51 time=448769.1 ms         



-------------------------------------------------------
This SF.Net email is sponsored by: IBM Linux Tutorials
Free Linux tutorial presented by Daniel Robbins, President and CEO of
GenToo technologies. Learn everything from fundamentals to system
administration.http://ads.osdn.com/?ad_id\x1470&alloc_id638&op=click

  parent reply	other threads:[~2004-03-04 20:07 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-03-03 11:51 thermal shutdown Yu, Luming
     [not found] ` <3ACA40606221794F80A5670F0AF15F8401CBB71C-SRlDPOYGfgogGBtAFL8yw7fspsVTdybXVpNB7YpNyf8@public.gmane.org>
2004-03-04 20:07   ` Pavel Machek [this message]
  -- strict thread matches above, loose matches on Subject: below --
2004-03-03 11:41 Jakob Praher
2004-02-19  2:55 Thermal Shutdown Tod Morrison

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20040304200706.GF531@openzaurus.ucw.cz \
    --to=pavel-+zi9xunit7i@public.gmane.org \
    --cc=acpi-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org \
    --cc=jpraher-LWAfsSFWpa4@public.gmane.org \
    --cc=luming.yu-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox