Re: Re: fix ACPI poweroff in 2.4.25-rc2

[Willy Tarreau <willy-tRhHnHjXm5DYtjvyW6yDsg@public.gmane.org>]

On Sat, Mar 06, 2004 at 01:21:26AM -0500, Len Brown wrote:
> Willy,
> Zwane was right, set_cpus_allowed() fixes the SMP poweroff problem.  The
> patch is here:
> 
> http://bugzilla.kernel.org/show_bug.cgi?id=1141

Great ! I didn't know that set_cpus_allowed() was so easy to use !
Unfortunately I cannot test it anymore on the P4 HT because it's been
racked at a colo. But I'll try this right here on my dual athlon at least
to confirm that it still works.

BTW, I've seen in the machine_restart() code that there were some cases
were the authors prefered to use boot_cpu instead of CPU 0, perhaps because
of particular machines which boot on another CPU. Wouldn't it be better to
use boot_cpu here, since we know for sure that it can access ACPI without
problem ?

Another thing : if we do a AltGr-SysRq-O, is 'current' valid, and can we
schedule ? or are we just in an interrupt handler ? I'll try this right
here anyway.

Thanks for the good news,
Willy



-------------------------------------------------------
This SF.Net email is sponsored by: IBM Linux Tutorials
Free Linux tutorial presented by Daniel Robbins, President and CEO of
GenToo technologies. Learn everything from fundamentals to system
administration.http://ads.osdn.com/?ad_id=1470&alloc_id=3638&op=click