From mboxrd@z Thu Jan 1 00:00:00 1970 From: Willy Tarreau Subject: Re: Re: fix ACPI poweroff in 2.4.25-rc2 Date: Sat, 6 Mar 2004 09:52:22 +0100 Sender: acpi-devel-admin-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org Message-ID: <20040306085222.GA6996@alpha.home.local> References: <200403031117.25937.bjorn.helgaas@hp.com> <20040303194656.GV25779@parcelfarce.linux.theplanet.co.uk> <20040303202027.GA30084@alpha.home.local> <1078554086.12991.3191.camel@dhcppc4> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <1078554086.12991.3191.camel-D2Zvc0uNKG8@public.gmane.org> Errors-To: acpi-devel-admin-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , List-Archive: To: Len Brown Cc: Matthew Wilcox , Bjorn Helgaas , Marcelo Tosatti , ACPI Developers List-Id: linux-acpi@vger.kernel.org On Sat, Mar 06, 2004 at 01:21:26AM -0500, Len Brown wrote: > Willy, > Zwane was right, set_cpus_allowed() fixes the SMP poweroff problem. The > patch is here: > > http://bugzilla.kernel.org/show_bug.cgi?id=1141 Great ! I didn't know that set_cpus_allowed() was so easy to use ! Unfortunately I cannot test it anymore on the P4 HT because it's been racked at a colo. But I'll try this right here on my dual athlon at least to confirm that it still works. BTW, I've seen in the machine_restart() code that there were some cases were the authors prefered to use boot_cpu instead of CPU 0, perhaps because of particular machines which boot on another CPU. Wouldn't it be better to use boot_cpu here, since we know for sure that it can access ACPI without problem ? Another thing : if we do a AltGr-SysRq-O, is 'current' valid, and can we schedule ? or are we just in an interrupt handler ? I'll try this right here anyway. Thanks for the good news, Willy ------------------------------------------------------- This SF.Net email is sponsored by: IBM Linux Tutorials Free Linux tutorial presented by Daniel Robbins, President and CEO of GenToo technologies. Learn everything from fundamentals to system administration.http://ads.osdn.com/?ad_id=1470&alloc_id=3638&op=click