Re: Re: fix ACPI poweroff in 2.4.25-rc2

[Willy Tarreau <willy-tRhHnHjXm5DYtjvyW6yDsg@public.gmane.org>]

On Sat, Mar 06, 2004 at 01:21:26AM -0500, Len Brown wrote:
> Willy,
> Zwane was right, set_cpus_allowed() fixes the SMP poweroff problem.  The
> patch is here:

Len, my last mail was totally stupid : my dual athlon uses APM to power off,
so the code was not even compiled ! And guess what ? it does not compile :-(
So please use this one instead, which compiles in 2.4 :

--- linux-2.4.25-wt3/drivers/acpi/system.c.old	Sat Mar  6 10:22:25 2004
+++ linux-2.4.25-wt3/drivers/acpi/system.c	Sat Mar  6 11:56:28 2004
@@ -40,6 +40,7 @@
 #include <asm/acpi.h>
 #include <acpi/acpi_bus.h>
 #include <acpi/acpi_drivers.h>
+#include <linux/sched.h>
 
 #ifdef CONFIG_X86
 #ifdef CONFIG_ACPI_SLEEP
@@ -95,6 +96,10 @@
 {
 	if (unlikely(in_interrupt())) 
 		BUG();
+#ifdef CONFIG_SMP
+	/* Some SMP machines only can poweroff in boot CPU */
+	set_cpus_allowed(current, 1 << cpu_logical_map(0));
+#endif
 	acpi_system_save_state(ACPI_STATE_S5);
 	acpi_enter_sleep_state_prep(ACPI_STATE_S5);
 	ACPI_DISABLE_IRQS();

Now the SMP athlon *really* powers off with this code since APM is disabled.

Sorry for the confusion,
Willy



-------------------------------------------------------
This SF.Net email is sponsored by: IBM Linux Tutorials
Free Linux tutorial presented by Daniel Robbins, President and CEO of
GenToo technologies. Learn everything from fundamentals to system
administration.http://ads.osdn.com/?ad_id=1470&alloc_id=3638&op=click