Re: Re: fix ACPI poweroff in 2.4.25-rc2

[Pavel Machek <pavel-+ZI9xUNit7I@public.gmane.org>]

Hi!

> > > The recent 2.4 patch breaks the build for ia64 because we don't
> > > set CONFIG_ACPI_SLEEP, and acpi_system_save_state() is only
> > > defined under #ifdef CONFIG_ACPI_SLEEP.  Can you add the following
> > > patch to deal with this?
> > 
> > Original patch should be reverted. Having different
> > behaviour of poweroff depending on ACPI_SLEEP would
> > be wrong.
> 
> Hi Pavel,
> 
> Original patches fixes a real problem, so its not as easy as "lets revert 
> it", yes? 

Well, it is.

Real problem was that someone's machine was not able to suspend with
APIC enabled (IIRC). He found that calling acpi_system_save_state()
accidentally fixes it for him (probably AML disables APIC or something
like that).

Now, right fix is to make linux shutdown APIC (etc) prior to
powerdown. Calling random functions is not the way to go.

							Pavel
-- 
When do you have a heart between your knees?
[Johanka's followup: and *two* hearts?]


-------------------------------------------------------
This SF.Net email is sponsored by: IBM Linux Tutorials
Free Linux tutorial presented by Daniel Robbins, President and CEO of
GenToo technologies. Learn everything from fundamentals to system
administration.http://ads.osdn.com/?ad_id=1470&alloc_id=3638&op=click