From mboxrd@z Thu Jan 1 00:00:00 1970 From: Pavel Machek Subject: Re: Re: fix ACPI poweroff in 2.4.25-rc2 Date: Mon, 8 Mar 2004 21:54:44 +0100 Sender: acpi-devel-admin-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org Message-ID: <20040308205444.GH484@elf.ucw.cz> References: <20040308163452.GE5352@openzaurus.ucw.cz> <20040308183228.GD484@elf.ucw.cz> <20040308201411.GA18636@alpha.home.local> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <20040308201411.GA18636-HkMpAodKYdnXX8ko2wsARw@public.gmane.org> Errors-To: acpi-devel-admin-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , List-Archive: To: Willy Tarreau Cc: Marcelo Tosatti , acpi-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org List-Id: linux-acpi@vger.kernel.org Hi! > > there's broken machine where calling acpi_system_save_state() with > > invalid argument fixes it by accident. > > In fact it does not fix it by accident, it's the previous code which > broke it by accident. Older ACPI poweroff code has been working well > on this machine, and suddenly stopped working. So i looked at what > changed and noticed that the acpi_poweroff() function changed from > _I don't remember what function_ to acpi_suspend(S5), and that > acpi_system_save_state(), which was called implicitly in the previous > function got lost during the change. Taking it back fixed my problem, > but I cannot say for sure that it will not break anything else, but its > use seems legitimate at first glance. Can you replace acpi_system_save_state() with pm_send_all(PM_SAVE_STATE, (void *)3); pm_send_all(PM_SUSPEND, (void *)3); ? That should fix it, too, and does not depend on CONFIG_ACPI_SLEEP. Pavel -- When do you have a heart between your knees? [Johanka's followup: and *two* hearts?] ------------------------------------------------------- This SF.Net email is sponsored by: IBM Linux Tutorials Free Linux tutorial presented by Daniel Robbins, President and CEO of GenToo technologies. Learn everything from fundamentals to system administration.http://ads.osdn.com/?ad_id=1470&alloc_id=3638&op=click