Re: [PATCH] ACPI poweroff fixes for 2.4.26-pre2

[Bruno Ducrot <ducrot-kk6yZipjEM5g9hUCZPvPmw@public.gmane.org>]

On Wed, Mar 10, 2004 at 12:33:25AM +0100, Willy Tarreau wrote:
> Hi Pavel,
> 
> On Mon, Mar 08, 2004 at 09:54:44PM +0100, Pavel Machek wrote:
> > Can you replace
> > 
> > acpi_system_save_state() with
> > 
> >         pm_send_all(PM_SAVE_STATE, (void *)3);
> >         pm_send_all(PM_SUSPEND, (void *)3);
> > 
> > ?
> > 
> > That should fix it, too, and does not depend on CONFIG_ACPI_SLEEP.
> 
> Just checked, and I still can poweroff (which was a bit expected anyway, but
> now confirmed). So with this little patch against 2.4.26-pre2, poweroff does
> not depend on CONFIG_ACPI_SLEEP anymore, as you fairly requested (thank you
> for having insisted).

IMHO, that is much likely a bug somewhere in the notifer_reboot chain
than an ACPI problem.  For example, IDE disks would all been in standby
modes, and IDE hwif will be 'cleaned up' before even calling the
poweroff callback, yet with your patch the pm_send_all with
PM_SAVE_STATE would actually hang some of those IDE hwif.

-- 
Bruno Ducrot

--  Which is worse:  ignorance or apathy?
--  Don't know.  Don't care.


-------------------------------------------------------
This SF.Net email is sponsored by: IBM Linux Tutorials
Free Linux tutorial presented by Daniel Robbins, President and CEO of
GenToo technologies. Learn everything from fundamentals to system
administration.http://ads.osdn.com/?ad_id=1470&alloc_id=3638&op=click