public inbox for linux-acpi@vger.kernel.org
 help / color / mirror / Atom feed
From: Dominik Brodowski <linux@dominikbrodowski.de>
To: Bruno Ducrot <ducrot@poupinou.org>
Cc: Tomasz Ciolek <tmc@dreamcraft.com.au>,
	acpi-devel@lists.sourceforge.net, cpufreq@www.linux.org.uk,
	Pavel Machek <pavel@ucw.cz>
Subject: Re: [ACPI] [PATCH 1/2] 2.6: use scaling_available_freqs in acpi-cpufreq-ioport driver
Date: Fri, 12 Mar 2004 15:52:44 +0100	[thread overview]
Message-ID: <20040312145244.GD4813@dominikbrodowski.de> (raw)
In-Reply-To: <20040303162255.GK2869@poupinou.org>


[-- Attachment #1.1: Type: text/plain, Size: 918 bytes --]

On Wed, Mar 03, 2004 at 05:22:55PM +0100, Bruno Ducrot wrote:
> > --- clean/include/linux/cpufreq.h	2004-01-09 20:24:26.000000000 +0100
> > +++ linux/include/linux/cpufreq.h	2004-03-01 19:02:48.000000000 +0100
> > @@ -316,6 +316,7 @@
> >  	unsigned int	index;     /* any */
> >  	unsigned int	frequency; /* kHz - doesn't need to be in ascending
> >  				    * order */
> > +	unsigned int	voltage;   /* mV */
> >  };
> 
> Well, why not?

Four reasons:

1.) not all cpufreq drivers which use frequency table helpers know the
voltage

2.) most cpufreq drivers don't need to know the voltage -- they need to know
a value [==index] to be written to some sort of register [msr/io/whatever].

3.) sizeof(struct cpufreq_table_entry)

4.) the overrides discussed for k{7,8} are very driver-specific and do
neither belong into the cpufreq core nor into the cpufreq frequency table
helpers. 

	Dominik

[-- Attachment #1.2: Type: application/pgp-signature, Size: 189 bytes --]

[-- Attachment #2: Type: text/plain, Size: 143 bytes --]

_______________________________________________
Cpufreq mailing list
Cpufreq@www.linux.org.uk
http://www.linux.org.uk/mailman/listinfo/cpufreq

  reply	other threads:[~2004-03-12 14:52 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-02-20  8:31 [PATCH 1/2] 2.6: use scaling_available_freqs in acpi-cpufreq-ioport driver Dominik Brodowski
2004-02-24 12:56 ` [ACPI] " Pavel Machek
2004-02-24 14:43   ` Dominik Brodowski
2004-02-25 10:26     ` Pavel Machek
2004-02-24 21:00   ` Tomasz Ciolek
2004-02-24 22:16     ` Pavel Machek
2004-02-26 17:28       ` Bruno Ducrot
2004-02-26 21:50         ` Pavel Machek
2004-03-01 17:54           ` Bruno Ducrot
2004-03-01 18:03             ` Pavel Machek
     [not found]               ` <20040301180325.GA562-I/5MKhXcvmPrBKCeMvbIDA@public.gmane.org>
2004-03-03 16:22                 ` Bruno Ducrot
2004-03-12 14:52                   ` Dominik Brodowski [this message]
2004-03-12 20:01                     ` [ACPI] " Pavel Machek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20040312145244.GD4813@dominikbrodowski.de \
    --to=linux@dominikbrodowski.de \
    --cc=acpi-devel@lists.sourceforge.net \
    --cc=cpufreq@www.linux.org.uk \
    --cc=ducrot@poupinou.org \
    --cc=pavel@ucw.cz \
    --cc=tmc@dreamcraft.com.au \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox