Re: [PATCH] ACPI poweroff fixes for 2.4.26-pre2

[Hartwig Felger <liste-9nAOAgdJVo4b1SvskN2V4Q@public.gmane.org>]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Salut Willy, Pavel and Sérgio,
I have a problem coming through on this list, altough I am subscribed...

Am Freitag, 26. März 2004 06:55 schrieb Willy Tarreau:
> >...
> > IIRC there was patch that made acpi_system_save_state() do nothing at
> > all if !CONFIG_ACPI_SLEEP. I'm arguing thats very wrong.
>
> I 100% agree that it's dirty to call a fake function instead of not
> calling it at all. Indeed, one of my proposed patches removed the
> dependency on CONFIG_ACPI_SLEEP through a simple replacement of
> acpi_system_save_state() with two calls to pm_send_all() which does
> not depend on CONFIG_ACPI_SLEEP. I believe it was cleaner, but it's
> not what is included in BK right now... Here it is for reference.

The regression started with the vanilla-kernels 2.4.25 and 2.6.3, and did not 
happen with the versions 2.4.24 and 2.6.2.
So I started to look at the differences and found out, that reverting this 3 
lines did revert the regression. I did not try to understand, what I did.

Andy Kleen started recently a new thread "Re: [ACPI] [PATCH] Handle disabled 
local apic better" that made me think... I compiled a vanilla 2.6.4 (without 
my patch, and with APIC disabled in config), et voila, everything is happy 
again.

So we need not to look at my patch. I think it would be better to drive 
forward Andy's work on handling APIC-disable in a correct manner.

Thanks for your discussion ;-)

http://bugme.osdl.org/show_bug.cgi?id=2183

Cheers
  hartwig felger

Hartwig Felger informatics

- -- 
1024D/339FD693 Hartwig Felger <hgfelger-9nAOAgdJVo4b1SvskN2V4Q@public.gmane.org>
Key fingerprint = FB2F 3EE9 345A D55B 6FF2  0EC1 F5B0 684F 339F D693
For the pulic keys, please visit my page.
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.4 (GNU/Linux)

iD8DBQFAY++Y9bBoTzOf1pMRAupCAKCSRV0jjisoVYqqn3M17tQgtCMEEwCbBISe
HeQ2UNdvEbmqSkj4v9T/w3o=
=kBdT
-----END PGP SIGNATURE-----



-------------------------------------------------------
This SF.Net email is sponsored by: IBM Linux Tutorials
Free Linux tutorial presented by Daniel Robbins, President and CEO of
GenToo technologies. Learn everything from fundamentals to system
administration.http://ads.osdn.com/?ad_id\x1470&alloc_id638&op=click