From mboxrd@z Thu Jan 1 00:00:00 1970 From: Pavel Machek Subject: Re: PCI not restored correctly after suspend to ram Date: Wed, 31 Mar 2004 18:15:38 +0200 Sender: acpi-devel-admin-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org Message-ID: <20040331161538.GA7762@elf.ucw.cz> References: <200403180935.09436.stefan.doesinger@gym-leoben.asn-graz.ac.at> <1079719856.7278.30.camel@dhcppc4> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <1079719856.7278.30.camel-D2Zvc0uNKG8@public.gmane.org> Errors-To: acpi-devel-admin-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , List-Archive: To: Len Brown Cc: stefan.doesinger-dYJrdcitkgg0+Ua9VpOLR6Q1ief8SNuKXqFh9Ls21Oc@public.gmane.org, ACPI Developers List-Id: linux-acpi@vger.kernel.org Hi! > ... > > I can get most devices devies to work by setting the pci registers with setpci > > after resume. I use the attached fixpci.sh script to do so. I can get my > > soundcard, the ethernet card(02:02.0) and the wireless(02:04.0) to work. I > > have not tested firewire(02:07.0). The secound Cardbus bride(02:06.1) seems > > to have more problems, it's not even listed correctly. > > The file "lspci_after_suspend_fix" contains the output of lspci -vvx after > > running fixpci.sh > > > > Restoring the pci registers is a workaround, but I'd like the kernel to handle > > this so I don't have to unload and reload all modules, especially the > > soundcard driver. > > > > It this a acpi bug, a bug in the pci driver or a bug in the drivers for the > > devices? > > Stefan, > Bruno is correct, the PCI config space should be saved and restored by > the driver's suspend and resume routines. suspend/resume routines > typically do other hardware dependent stuff, but your debugging suggests > that at least for some of these devices, simply saving and restoring pci > config space (pci_save_state()/pci_restore_state()) may be sufficient. > > Time to take a look at the drivers for those devices... Perhaps doing it once in PCI layer is better, then? Pavel -- When do you have a heart between your knees? [Johanka's followup: and *two* hearts?] ------------------------------------------------------- This SF.Net email is sponsored by: IBM Linux Tutorials Free Linux tutorial presented by Daniel Robbins, President and CEO of GenToo technologies. Learn everything from fundamentals to system administration.http://ads.osdn.com/?ad_id=1470&alloc_id=3638&op=click