From: Chris McDermott <lcm-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
To: acpi-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org
Cc: bjorn.helgaas-VXdhtT5mjnY@public.gmane.org,
davidm-sDzT885Ts8HQT0dZR+AlfA@public.gmane.org
Subject: [PATCH 2.6] ia64 support for PCI link devices
Date: Mon, 5 Apr 2004 18:45:53 -0700 [thread overview]
Message-ID: <20040406014553.GV7695@us.ibm.com> (raw)
This patch enables correct enablement of interrupts described by
PCI link device entries in the DSDT.
The current ia64 implementation ignores link entries and therefore
prevents such interrupts from being configured correctly.
Comments?
thanks,
--
Chris McDermott
--- orig/arch/ia64/kernel/iosapic.c 2004-03-31 16:19:20.000000000 -0800
+++ new/arch/ia64/kernel/iosapic.c 2004-04-05 10:29:11.668281924 -0700
@@ -688,15 +688,23 @@ iosapic_parse_prt (void)
char pci_id[16];
struct hw_interrupt_type *irq_type = &irq_type_iosapic_level;
irq_desc_t *idesc;
+ int trigger = IOSAPIC_LEVEL;
+ int polarity = IOSAPIC_POL_LOW;
list_for_each(node, &acpi_prt.entries) {
entry = list_entry(node, struct acpi_prt_entry, node);
- /* We're only interested in static (non-link) entries. */
- if (entry->link.handle)
- continue;
+ /* Check for dynamic (PCI link) entry. */
+ if (entry->link.handle) {
+ gsi = acpi_pci_link_get_irq(entry->link.handle, entry->link.index, &trigger, &polarity);
+ if (!gsi)
+ continue;
- gsi = entry->link.index;
+ if (trigger == IOSAPIC_EDGE)
+ irq_type = &irq_type_iosapic_edge;
+ } else {
+ gsi = entry->link.index;
+ }
vector = gsi_to_vector(gsi);
if (vector < 0) {
@@ -710,8 +718,12 @@ iosapic_parse_prt (void)
/* new GSI; allocate a vector for it */
vector = ia64_alloc_vector();
- register_intr(gsi, vector, IOSAPIC_LOWEST_PRIORITY, IOSAPIC_POL_LOW,
- IOSAPIC_LEVEL);
+ if (entry->link.handle)
+ register_intr(gsi, vector, IOSAPIC_LOWEST_PRIORITY, polarity,
+ trigger);
+ else
+ register_intr(gsi, vector, IOSAPIC_LOWEST_PRIORITY, IOSAPIC_POL_LOW,
+ IOSAPIC_LEVEL);
}
entry->irq = vector;
snprintf(pci_id, sizeof(pci_id), "%02x:%02x:%02x[%c]",
@@ -723,8 +735,8 @@ iosapic_parse_prt (void)
*/
idesc = irq_descp(vector);
if (idesc->handler != irq_type)
- register_intr(gsi, vector, IOSAPIC_LOWEST_PRIORITY, IOSAPIC_POL_LOW,
- IOSAPIC_LEVEL);
+ register_intr(gsi, vector, IOSAPIC_LOWEST_PRIORITY, polarity,
+ trigger);
}
}
-------------------------------------------------------
This SF.Net email is sponsored by: IBM Linux Tutorials
Free Linux tutorial presented by Daniel Robbins, President and CEO of
GenToo technologies. Learn everything from fundamentals to system
administration.http://ads.osdn.com/?ad_id=1470&alloc_id=3638&op=click
next reply other threads:[~2004-04-06 1:45 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-04-06 1:45 Chris McDermott [this message]
[not found] ` <20040406014553.GV7695-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
2004-04-06 16:11 ` [PATCH 2.6] ia64 support for PCI link devices Bjorn Helgaas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040406014553.GV7695@us.ibm.com \
--to=lcm-r/jw6+rmf7hqt0dzr+alfa@public.gmane.org \
--cc=acpi-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org \
--cc=bjorn.helgaas-VXdhtT5mjnY@public.gmane.org \
--cc=davidm-sDzT885Ts8HQT0dZR+AlfA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox