Re: S3 suspend/resume driver questions

[tmc-+XVqjN4+fIJfbCVcMT5z6Ydd74u8MsAO@public.gmane.org (Tomasz Ciolek)]

[-- Attachment #1: Type: text/plain, Size: 5062 bytes --]

 Hooray.
 
 If only someone at ATI or Fujitsu finnaly mamanged to cough up
 the magic incantations for the radeon cards so that the POST
 correctly... 

 Regards
 TMC

On Mon, Apr 19, 2004 at 09:42:12PM -0400, Ilya Bagrak wrote:
> Adrian,
> 
> Your patch worked beautifully on my Fujitsu E7010 laptop.  Prior to the
> patch, the system would lock up hard if I tried to load snd_intel8x0 after
> waking up from S3.  If I didn't not unload the sound modules before going
> to sleep, the system would not wake up at all (lock up would happen on
> resume).  In any case, the sound "just works" (tm) now.
> 
> There is more good news.  I adapted your patch to orinoco_pci driver which
> manages my built in Prism2 wireless adapter.  The unpatched driver failed
> to reinit the card upon resume.  Even though that didn't not lock up my
> computer like sound did, the card was not functional.  I was absolutely
> stunned when this 3-liner-of-a-patch returned full functionality to the
> card upon resume.  You don't even have to unload the driver before going
> to sleep.  I have a little signal strength applet running in the toolbar,
> and you can watch the signal strength gradually increase after wakeup and
> the card is back to normal in a couple of seconds.
> 
> The wireless NIC was the last stumbling block in getting S3 to work.  I
> now officially declare Fujitsu E7010 Linux ACPI-friendly.  All major
> devices (have not tested Firewire or IrDA) recover and work properly after
> S3. Thank you all.
> 
> Ilya
> 
> > Hi,
> >
> >> mine isn't a technical reply, but you can post in the 'alsa-devel'
> >> mailing-list, as it seems that Takashi Iwai is working on PM-lacking
> >> drivers. Here some links:
> >>    http://sourceforge.net/mailarchive/forum.php?thread_id=4201761&forum_id=1752
> >
> > Doing a grep through the alsa code, it doesn't look like any driver
> > save/restores pci state.
> >
> >>    http://sourceforge.net/mailarchive/forum.php?thread_id=4107033&forum_id=1752
> >>
> >> BTW-1, could you post your 'intel8x0' patch? I could give it a try
> >> ASAP...
> >
> > That's essentially what I did.  It is a little different though:
> >
> > --- /usr/src/linux-2.6.5-mm6/sound/pci/intel8x0.c       2004-04-05
> > 18:46:17.000000000 -0700 +++ intel8x0.c  2004-04-18 04:03:34.000000000
> > -0700
> > @@ -445,6 +445,7 @@ struct _snd_intel8x0 {
> >
> >  #ifdef CONFIG_PM
> >         int in_suspend;
> > +       u32 pci_state[16];
> >  #endif
> >  };
> >
> > @@ -2223,11 +2224,13 @@ static int snd_intel8x0_suspend(struct p
> >  {
> >         intel8x0_t *chip = snd_magic_cast(intel8x0_t,
> > pci_get_drvdata(dev), return -ENXIO); intel8x0_suspend(chip);
> > +       pci_save_state(dev, chip->pci_state);
> >         return 0;
> >  }
> >  static int snd_intel8x0_resume(struct pci_dev *dev)
> >  {
> >         intel8x0_t *chip = snd_magic_cast(intel8x0_t,
> > pci_get_drvdata(dev), return -ENXIO);
> > +       pci_restore_state(dev, chip->pci_state);
> >         intel8x0_resume(chip);
> >         return 0;
> >  }
> >
> >> BTW-2, in the few tests I made on my ASUS M6842NWH ('intel8x0' based),
> >> I have to remove the sound modules even to have a successfull S1.
> >
> > Actually, I haven't tried out S1 yet, but I don't have to remove the
> > sound modules for S3 to work.  And even if I do, my system will lock up
> > when trying to load the alsa drivers due to the device's configuration
> > state.
> >
> > Adrian
> >
> >
> > -------------------------------------------------------
> > This SF.Net email is sponsored by: IBM Linux Tutorials
> > Free Linux tutorial presented by Daniel Robbins, President and CEO of
> > GenToo technologies. Learn everything from fundamentals to system
> > administration.http://ads.osdn.com/?ad_id\x1470&alloc_id638&op?k
> > _______________________________________________
> > Acpi-devel mailing list
> > Acpi-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org
> > https://lists.sourceforge.net/lists/listinfo/acpi-devel
> 
> 
> 
> 
> 
> -------------------------------------------------------
> This SF.Net email is sponsored by: IBM Linux Tutorials
> Free Linux tutorial presented by Daniel Robbins, President and CEO of
> GenToo technologies. Learn everything from fundamentals to system
> administration.http://ads.osdn.com/?ad_id\x1470&alloc_id638&op=click
> _______________________________________________
> Acpi-devel mailing list
> Acpi-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org
> https://lists.sourceforge.net/lists/listinfo/acpi-devel

-- 
Tomasz M. Ciolek	
*******************************************************************************
 tmc at dreamcraft dot com dot au 
*******************************************************************************
   GPG Key ID:		0x41C4C2F0
   GPG Key Fingerprint: 3883 B308 8256 2246 D3ED  A1FF 3A1D 0EAD 41C4 C2F0
   Key available on www.pgp.net	
*******************************************************************************

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 189 bytes --]