* 2.6.6-rc3-mm1: modular ACPI button broken [not found] ` <87ad0sshku.fsf@basilikum.skogtun.org> @ 2004-05-01 11:44 ` Adrian Bunk 2004-05-03 18:36 ` Valdis.Kletnieks 0 siblings, 1 reply; 3+ messages in thread From: Adrian Bunk @ 2004-05-01 11:44 UTC (permalink / raw) To: Harald Arnesen, len.brown, luming.yu Cc: Andrew Morton, linux-kernel, acpi-devel On Sat, May 01, 2004 at 10:00:01AM +0200, Harald Arnesen wrote: > I don't see this in plain 2.6.6-rc3 or 2.6.6-rc2-mm2: > > > $ sudo make modules_install > INSTALL... > if [ -r System.map ]; then /sbin/depmod -ae -F System.map > 2.6.6-rc3-mm1; fi > WARNING: /lib/modules/2.6.6-rc3-mm1/kernel/drivers/acpi/button.ko needs > unknown symbol acpi_fixed_sleep_button > WARNING: /lib/modules/2.6.6-rc3-mm1/kernel/drivers/acpi/button.ko needs > unknown symbol acpi_fixed_pwr_button > $ >... Thanks for this report. This seems to be introduced by the button driver unload unload patch (Bugzilla #2281) included in the ACPI BK patch. It seems two EXPORT_SYMBOL's are missing in scan.c? cu Adrian -- "Is there not promise of rain?" Ling Tan asked suddenly out of the darkness. There had been need of rain for many days. "Only a promise," Lao Er said. Pearl S. Buck - Dragon Seed ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: 2.6.6-rc3-mm1: modular ACPI button broken 2004-05-01 11:44 ` 2.6.6-rc3-mm1: modular ACPI button broken Adrian Bunk @ 2004-05-03 18:36 ` Valdis.Kletnieks 2004-05-03 19:21 ` Len Brown 0 siblings, 1 reply; 3+ messages in thread From: Valdis.Kletnieks @ 2004-05-03 18:36 UTC (permalink / raw) To: Adrian Bunk Cc: Harald Arnesen, len.brown, luming.yu, Andrew Morton, linux-kernel, acpi-devel [-- Attachment #1: Type: text/plain, Size: 1002 bytes --] On Sat, 01 May 2004 13:44:21 +0200, Adrian Bunk said: > This seems to be introduced by the button driver unload unload patch > (Bugzilla #2281) included in the ACPI BK patch. > > It seems two EXPORT_SYMBOL's are missing in scan.c? And a needed #include, as well (found that out the hard way). Here's the "works for me" patch... --- linux-2.6.6-rc3-mm1/drivers/acpi/scan.c.modules 2004-04-30 21:45:27.348492000 -0400 +++ linux-2.6.6-rc3-mm1/drivers/acpi/scan.c 2004-04-30 23:26:24.994263676 -0400 @@ -4,6 +4,7 @@ #include <linux/init.h> #include <linux/acpi.h> +#include <linux/module.h> #include <acpi/acpi_drivers.h> #include <acpi/acinterp.h> /* for acpi_ex_eisa_id_to_string() */ @@ -16,7 +17,9 @@ ACPI_MODULE_NAME ("scan") extern struct acpi_device *acpi_root; struct acpi_device *acpi_fixed_pwr_button; +EXPORT_SYMBOL(acpi_fixed_pwr_button); struct acpi_device *acpi_fixed_sleep_button; +EXPORT_SYMBOL(acpi_fixed_sleep_button); #define ACPI_BUS_CLASS "system_bus" [-- Attachment #2: Type: application/pgp-signature, Size: 226 bytes --] ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: 2.6.6-rc3-mm1: modular ACPI button broken 2004-05-03 18:36 ` Valdis.Kletnieks @ 2004-05-03 19:21 ` Len Brown 0 siblings, 0 replies; 3+ messages in thread From: Len Brown @ 2004-05-03 19:21 UTC (permalink / raw) To: Valdis.Kletnieks Cc: Adrian Bunk, Harald Arnesen, Luming Yu, Andrew Morton, linux-kernel, ACPI Developers On Mon, 2004-05-03 at 14:36, Valdis.Kletnieks@vt.edu wrote: > On Sat, 01 May 2004 13:44:21 +0200, Adrian Bunk said: > > > This seems to be introduced by the button driver unload unload patch > > (Bugzilla #2281) included in the ACPI BK patch. > > > > It seems two EXPORT_SYMBOL's are missing in scan.c? > > And a needed #include, as well (found that out the hard way). Here's > the "works for me" patch... I should have mentioned that I pushed the works-for-me patch to linus a few hours ago -- so -mm will get it that way. Note also with the existing -mm tree you can always CONFIG_ACPI_BUTTON=y instead of using a module for now. thanks, -Len ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2004-05-03 19:21 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20040430014658.112a6181.akpm@osdl.org>
[not found] ` <87ad0sshku.fsf@basilikum.skogtun.org>
2004-05-01 11:44 ` 2.6.6-rc3-mm1: modular ACPI button broken Adrian Bunk
2004-05-03 18:36 ` Valdis.Kletnieks
2004-05-03 19:21 ` Len Brown
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox