RE: Fixing broken DSDT - code suggestions for comment please!

RE: Fixing broken DSDT - code suggestions for comment please!

[Yu, Luming]

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset="us-ascii", Size: 593 bytes --]

>
>If you're interested in seeing how we did it in FreeBSD, see
>src/sys/dev/acpica/Osd/OsdDebug.c and the #ifdef ACPI_DEBUGGER in the
>ACPI-CA code that we added.

Wha'ts the interactive kernel debug tool in FreeBSD? Does ASL debug
feature 
work in that debug tool?

Thanks,
Luming


-------------------------------------------------------
This SF.Net email is sponsored by: Oracle 10g
Get certified on the hottest thing ever to hit the market... Oracle 10g.
Take an Oracle 10g class now, and we'll give you the exam FREE.
http://ads.osdn.com/?ad_id149&alloc_id66&op=click

RE: Fixing broken DSDT - code suggestions for comment please!

[Nate Lawson]

On Fri, 28 May 2004, Yu, Luming wrote:
> >If you're interested in seeing how we did it in FreeBSD, see
> >src/sys/dev/acpica/Osd/OsdDebug.c and the #ifdef ACPI_DEBUGGER in the
> >ACPI-CA code that we added.
>
> Wha'ts the interactive kernel debug tool in FreeBSD? Does ASL debug
> feature
> work in that debug tool?

FreeBSD has a built-in kernel debugger called DDB.  So basically we just
had to define the get line routine and it was hooked in.

http://www.freebsd.org/cgi/cvsweb.cgi/~checkout~/src/sys/dev/acpica/Osd/OsdDebug.c?rev=1.7&content-type=text/plain

Note that this is optionally included in the kernel compile -- we don't
enable this for acpi by default.

-Nate


-------------------------------------------------------
This SF.Net email is sponsored by: Oracle 10g
Get certified on the hottest thing ever to hit the market... Oracle 10g. 
Take an Oracle 10g class now, and we'll give you the exam FREE.
http://ads.osdn.com/?ad_id=3149&alloc_id=8166&op=click

RE: Fixing broken DSDT - code suggestions for comment please!

[Yu, Luming]

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset="us-ascii", Size: 746 bytes --]

 
>There *is* an interactive AML debugger in the ACPI CA package. 
> However,
>it needs to be integrated into Linux.
>
>As far as I can tell, the reason it hasn't been done yet is because the
>whole concept of "interactive kernel debugging" is rather foreign to
>Linux.
>
>Bob

I think Kdb and Kgdb in Linux are so-called "interactive kernel
debugging" tool.
So , AML debugger should be feasible to be ported into linux.

--Luming


-------------------------------------------------------
This SF.Net email is sponsored by: Oracle 10g
Get certified on the hottest thing ever to hit the market... Oracle 10g.
Take an Oracle 10g class now, and we'll give you the exam FREE.
http://ads.osdn.com/?ad_id149&alloc_id66&op=click

RE: Fixing broken DSDT - code suggestions for comment please!

[Moore, Robert]

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset="us-ascii", Size: 1515 bytes --]

There *is* an interactive AML debugger in the ACPI CA package.  However,
it needs to be integrated into Linux.

As far as I can tell, the reason it hasn't been done yet is because the
whole concept of "interactive kernel debugging" is rather foreign to
Linux.

Bob


> -----Original Message-----
> From: Yu, Luming
> Sent: Tuesday, May 25, 2004 7:36 PM
> To: marmon-GymH4r+vMzPQT0dZR+AlfA@public.gmane.org; ACPI Developers
> Cc: linux-acpi
> Subject: RE: [ACPI] Fixing broken DSDT - code suggestions for comment
> please!
> 
>  >
> >I've posted this question before, if its just a question that shall
go
> >unanswered someone please let me know so I stop reposting it
different
> >ways:
> >
> >Where would start searching for information on debugging a compiled
> >DSDT?  The iasl compiler believes it is fine, 0 errors, 0 warnings;
but
> >I kernel panic in the one_complete_parse phase when booting using the
> >custom dsdt table.
> >
> 
>   AFAIK, there is no AML debugging tool under linux. To debug the
DSDT,
> you have to add some statement like "store ( xxx, debug) " in your ASL
> code.
> 
>   PS, can you post the detailed message of the panic.
> 
> Thanks,
> Luming


-------------------------------------------------------
This SF.Net email is sponsored by: Oracle 10g
Get certified on the hottest thing ever to hit the market... Oracle 10g.
Take an Oracle 10g class now, and we'll give you the exam FREE.
http://ads.osdn.com/?ad_id149&alloc_id66&op=click

RE: Fixing broken DSDT - code suggestions for comment please!

[Nate Lawson]

If you're interested in seeing how we did it in FreeBSD, see
src/sys/dev/acpica/Osd/OsdDebug.c and the #ifdef ACPI_DEBUGGER in the
ACPI-CA code that we added.

-Nate

On Wed, 26 May 2004, Moore, Robert wrote:
> There *is* an interactive AML debugger in the ACPI CA package.  However,
> it needs to be integrated into Linux.
>
> As far as I can tell, the reason it hasn't been done yet is because the
> whole concept of "interactive kernel debugging" is rather foreign to
> Linux.
>
> Bob
>
>
> > -----Original Message-----
> > From: Yu, Luming
> > Sent: Tuesday, May 25, 2004 7:36 PM
> > To: marmon-GymH4r+vMzPQT0dZR+AlfA@public.gmane.org; ACPI Developers
> > Cc: linux-acpi
> > Subject: RE: [ACPI] Fixing broken DSDT - code suggestions for comment
> > please!
> >
> >  >
> > >I've posted this question before, if its just a question that shall
> go
> > >unanswered someone please let me know so I stop reposting it
> different
> > >ways:
> > >
> > >Where would start searching for information on debugging a compiled
> > >DSDT?  The iasl compiler believes it is fine, 0 errors, 0 warnings;
> but
> > >I kernel panic in the one_complete_parse phase when booting using the
> > >custom dsdt table.
> > >
> >
> >   AFAIK, there is no AML debugging tool under linux. To debug the
> DSDT,
> > you have to add some statement like "store ( xxx, debug) " in your ASL
> > code.
> >
> >   PS, can you post the detailed message of the panic.
> >
> > Thanks,
> > Luming
>
>
> -------------------------------------------------------
> This SF.Net email is sponsored by: Oracle 10g
> Get certified on the hottest thing ever to hit the market... Oracle 10g.
> Take an Oracle 10g class now, and we'll give you the exam FREE.
> _______________________________________________
> Acpi-devel mailing list
> Acpi-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org
> https://lists.sourceforge.net/lists/listinfo/acpi-devel
>


-------------------------------------------------------
This SF.Net email is sponsored by: Oracle 10g
Get certified on the hottest thing ever to hit the market... Oracle 10g. 
Take an Oracle 10g class now, and we'll give you the exam FREE.
http://ads.osdn.com/?ad_id=3149&alloc_id=8166&op=click

RE: Fixing broken DSDT - code suggestions for comment please!

[Yu, Luming]

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset="us-ascii", Size: 931 bytes --]

 >
>I've posted this question before, if its just a question that shall go
>unanswered someone please let me know so I stop reposting it different
>ways:
>
>Where would start searching for information on debugging a compiled
>DSDT?  The iasl compiler believes it is fine, 0 errors, 0 warnings; but
>I kernel panic in the one_complete_parse phase when booting using the
>custom dsdt table.
>

  AFAIK, there is no AML debugging tool under linux. To debug the DSDT,
you have to add some statement like "store ( xxx, debug) " in your ASL
code. 

  PS, can you post the detailed message of the panic.

Thanks,
Luming


-------------------------------------------------------
This SF.Net email is sponsored by: Oracle 10g
Get certified on the hottest thing ever to hit the market... Oracle 10g.
Take an Oracle 10g class now, and we'll give you the exam FREE.
http://ads.osdn.com/?ad_id149&alloc_id66&op=click

RE: Fixing broken DSDT - code suggestions for comment please!

[Brown, Len]

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset="us-ascii", Size: 1534 bytes --]

I've asked the web page gnomes to delete the obsolete
Linux binary.

Linux folks can build iasl from course

untar
cd compiler
make


cheers,
-Len
 

>-----Original Message-----
>From: Chris McDermott [mailto:lcm-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org] 
>Sent: Thursday, May 20, 2004 4:30 PM
>To: Brown, Len
>Cc: ACPI Developers; Moore, Robert
>Subject: Re: [ACPI] Fixing broken DSDT - code suggestions for 
>comment please!
>
>On Mon, May 17, 2004 at 21:00 -0400, Len Brown wrote: 
>> On Mon, 2004-05-17 at 20:54, Cam wrote:
>> > Len Brown wrote:
>> > > Please verify that you still have this problem
>> > > when running the latest iasl:
>> > > 
>> > > http://www.intel.com/technology/IAPC/acpi/downloads.htm
>> > 
>> > I was working with iasl-linux-20030918 which I think is 
>the latest. Do 
>> > you think the Store(Local0, Local0) is an iasl bug? I can 
>send the dsdt 
>> > binary if you are interested.
>> 
>> Follow the link above to download a version 6 months newer.
>
>Following the link above, I see a newer version of iasl for 
>Windows, but not 
>for Linux. Is there a version of iasl newer than 20030918 for 
>Linux? Am I
>missing something?
>
>thanks,
>-- 
>-chris
>
>


-------------------------------------------------------
This SF.Net email is sponsored by: Oracle 10g
Get certified on the hottest thing ever to hit the market... Oracle 10g.
Take an Oracle 10g class now, and we'll give you the exam FREE.
http://ads.osdn.com/?ad_id149&alloc_id66&op=click

Re: Fixing broken DSDT - code suggestions for comment please!

[Franklin Marmon]

I've posted this question before, if its just a question that shall go
unanswered someone please let me know so I stop reposting it different
ways:

Where would start searching for information on debugging a compiled
DSDT?  The iasl compiler believes it is fine, 0 errors, 0 warnings; but
I kernel panic in the one_complete_parse phase when booting using the
custom dsdt table.

Thank you,

frm




-------------------------------------------------------
This SF.Net email is sponsored by: SourceForge.net Broadband
Sign-up now for SourceForge Broadband and get the fastest
6.0/768 connection for only $19.95/mo for the first 3 months!
http://ads.osdn.com/?ad_id=2562&alloc_id=6184&op=click

Re: Fixing broken DSDT - code suggestions for comment please!

[Bas Mevissen]

On Tue, 2004-05-18 at 16:19, Franklin Marmon wrote:
> I've posted this question before, if its just a question that shall go
> unanswered someone please let me know so I stop reposting it different
> ways:
> 
> Where would start searching for information on debugging a compiled
> DSDT?  The iasl compiler believes it is fine, 0 errors, 0 warnings; but
> I kernel panic in the one_complete_parse phase when booting using the
> custom dsdt table.
> 

Enable debugging in APCI and write down the call trace from syslog. Post
it here and hopefully it will ring a bell.

N.B. You are running a current kernel and using the latest ACPI patches?
Please check that before trying. Because getting the answer that you've
spent the whole night on hunting an old bug is quite frustrating...

Bas.





-------------------------------------------------------
This SF.Net email is sponsored by: SourceForge.net Broadband
Sign-up now for SourceForge Broadband and get the fastest
6.0/768 connection for only $19.95/mo for the first 3 months!
http://ads.osdn.com/?ad_id=2562&alloc_id=6184&op=click

Fixing broken DSDT - code suggestions for comment please!

[Cam]

Hi ACPI list,

I have been trying to get ACPI running on my laptop but have found there 
are problems with the DSDT. I have followed some instructions on getting 
iasl and recompiling the DSDT but find some errors that go beyond the 
scope of the list at:

http://www.cpqlinux.com/acpi-howto.html#fix_broken_dsdt

The errors are:


dsdt.dsl  2149:                     Store (Local0, Local0)
Error    1013 -                                 ^ Method local variable 
is not initialized (Local0)

This occurs several times in the code, a typical case is:

                 Method (_PS0, 0, NotSerialized)
                 {
                     Store (And (0xF0, TIA4), TIA4)
                     Store (0x01, _PSC)
                     Store (Local0, Local0)
                 }

I'm guessing that is effectively a NOP so I can comment it out.

Later there are two other errors not mentioned in the FAQ:

dsdt.dsl  2390:                     Return (WQS (0x0E, Arg0))
Error    1029 -                               ^ Called method returns no 
value
 

dsdt.dsl  2395:                     Return (WQSB (0x0E, Arg0))
Error    1029 - Called method returns no value ^
 


The offending code is:

                 Method (WENR, 1, NotSerialized)
                 {
                     Return (WQS (0x0E, Arg0))
                 }

                 Method (WETR, 1, NotSerialized)
                 {
                     Return (WQSB (0x0E, Arg0))
                 }

All the calls to those methods seem to discard any return value, eg:

         If (\_SB.OKEC)
         {
             \_SB.PCI0.QSB.WENR (0x01F0)
         }

I couldn't find a reference to WETR



So I thought to not return anything:

                 Method (WENR, 1, NotSerialized)
                 {
/*                    Return (WQS (0x0E, Arg0))*/
                     WQS (0x0E, Arg0)
                 }

                 Method (WETR, 1, NotSerialized)
                 {
/*                    Return (WQSB (0x0E, Arg0))*/
                     WQSB (0x0E, Arg0)
                 }

I am more than a bit wary about trying this for real so would appreciate 
  any comments on the dsdt code above. If the fixes are good then maybe 
they could be incorporated into the FAQ?

Any comments gratefully received,

-Cam


-------------------------------------------------------
This SF.Net email is sponsored by: SourceForge.net Broadband
Sign-up now for SourceForge Broadband and get the fastest
6.0/768 connection for only $19.95/mo for the first 3 months!
http://ads.osdn.com/?ad_id=2562&alloc_id=6184&op=click

Re: Fixing broken DSDT - code suggestions for comment please!

[Cam]

Hi again ACPI list,

I'm really hoping someone with DSDT hacking experience will cast an eye 
over the DSDT patches I gave before (dated 16/05/04 10:29).

I also see some messages at boot time:

ACPI: Subsystem revision 20040326
ACPI: IRQ9 SCI: Level Trigger.
     ACPI-1133: *** Error: Method execution failed 
[\_SB_.PCI0.QSB_.WQS_] (Node 19f1a5bc), AE_NOT_EXIST
     ACPI-1133: *** Error: Method execution failed 
[\_SB_.PCI0.QSB_.WENR] (Node 19f1a77c), AE_NOT_EXIST
     ACPI-1133: *** Error: Method execution failed [\_SB_.PCI0._INI] 
(Node 19f2123c), AE_NOT_EXIST
ACPI: Interpreter enabled

Any suggestions how I can fix or work around these? Or any more links to 
useful guides to hacking the DSDT?

Thanks in advance,

-Cam

-- 
camilo-Nk/s8sJ9yP7QXOPxS62xeg@public.gmane.org                                                 <--


-------------------------------------------------------
This SF.Net email is sponsored by: SourceForge.net Broadband
Sign-up now for SourceForge Broadband and get the fastest
6.0/768 connection for only $19.95/mo for the first 3 months!
http://ads.osdn.com/?ad_id=2562&alloc_id=6184&op=click

Re: Fixing broken DSDT - code suggestions for comment please!

[Len Brown]

Please verify that you still have this problem
when running the latest iasl:

http://www.intel.com/technology/IAPC/acpi/downloads.htm


On Sun, 2004-05-16 at 05:29, Cam wrote:
> Hi ACPI list,
> 
> I have been trying to get ACPI running on my laptop but have found there 
> are problems with the DSDT. I have followed some instructions on getting 
> iasl and recompiling the DSDT but find some errors that go beyond the 
> scope of the list at:
> 
> http://www.cpqlinux.com/acpi-howto.html#fix_broken_dsdt
> 
> The errors are:
> 
> 
> dsdt.dsl  2149:                     Store (Local0, Local0)
> Error    1013 -                                 ^ Method local variable 
> is not initialized (Local0)
> 
> This occurs several times in the code, a typical case is:
> 
>                  Method (_PS0, 0, NotSerialized)
>                  {
>                      Store (And (0xF0, TIA4), TIA4)
>                      Store (0x01, _PSC)
>                      Store (Local0, Local0)
>                  }
> 
> I'm guessing that is effectively a NOP so I can comment it out.
> 
> Later there are two other errors not mentioned in the FAQ:
> 
> dsdt.dsl  2390:                     Return (WQS (0x0E, Arg0))
> Error    1029 -                               ^ Called method returns no 
> value
>  
> 
> dsdt.dsl  2395:                     Return (WQSB (0x0E, Arg0))
> Error    1029 - Called method returns no value ^
>  
> 
> 
> The offending code is:
> 
>                  Method (WENR, 1, NotSerialized)
>                  {
>                      Return (WQS (0x0E, Arg0))
>                  }
> 
>                  Method (WETR, 1, NotSerialized)
>                  {
>                      Return (WQSB (0x0E, Arg0))
>                  }
> 
> All the calls to those methods seem to discard any return value, eg:
> 
>          If (\_SB.OKEC)
>          {
>              \_SB.PCI0.QSB.WENR (0x01F0)
>          }
> 
> I couldn't find a reference to WETR
> 
> 
> 
> So I thought to not return anything:
> 
>                  Method (WENR, 1, NotSerialized)
>                  {
> /*                    Return (WQS (0x0E, Arg0))*/
>                      WQS (0x0E, Arg0)
>                  }
> 
>                  Method (WETR, 1, NotSerialized)
>                  {
> /*                    Return (WQSB (0x0E, Arg0))*/
>                      WQSB (0x0E, Arg0)
>                  }
> 

no. the problem is that WQS and WQSB need to have Return() statements.

> I am more than a bit wary about trying this for real so would appreciate 
>   any comments on the dsdt code above. If the fixes are good then maybe 
> they could be incorporated into the FAQ?
> 
> Any comments gratefully received,
> 
> -Cam
> 
> 
> -------------------------------------------------------
> This SF.Net email is sponsored by: SourceForge.net Broadband
> Sign-up now for SourceForge Broadband and get the fastest
> 6.0/768 connection for only $19.95/mo for the first 3 months!
> http://ads.osdn.com/?ad_id=2562&alloc_id=6184&op=click
> _______________________________________________
> Acpi-devel mailing list
> Acpi-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org
> https://lists.sourceforge.net/lists/listinfo/acpi-devel



-------------------------------------------------------
This SF.Net email is sponsored by: SourceForge.net Broadband
Sign-up now for SourceForge Broadband and get the fastest
6.0/768 connection for only $19.95/mo for the first 3 months!
http://ads.osdn.com/?ad_id=2562&alloc_id=6184&op=click

Re: Fixing broken DSDT - code suggestions for comment please!

[Cam]

Len

thanks for the feedback and comments,

Len Brown wrote:
> Please verify that you still have this problem
> when running the latest iasl:
> 
> http://www.intel.com/technology/IAPC/acpi/downloads.htm

I was working with iasl-linux-20030918 which I think is the latest. Do 
you think the Store(Local0, Local0) is an iasl bug? I can send the dsdt 
binary if you are interested.

>>Later there are two other errors not mentioned in the FAQ:
>>
>>dsdt.dsl  2390:                     Return (WQS (0x0E, Arg0))
>>Error    1029 -                               ^ Called method returns no 
>>value
>> 
>>
>>dsdt.dsl  2395:                     Return (WQSB (0x0E, Arg0))
>>Error    1029 - Called method returns no value ^
>> 

[... my bad fix snipped ...]

> no. the problem is that WQS and WQSB need to have Return() statements.

OK from another look at the code I see the declarations for the WQS and 
WQSB methods. I am struggling what to return from these. Zero? Arg0? 
Arg1? Some success/fail code? Any ideas? There are lots of calls to WQS 
and WQSB that mostly seem to discard the (not yet) returned value.


                 Method (WQSB, 2, NotSerialized)
                 {
                     If (LNot (LOr (\_SB.PCI0.ISA.EC0.FBAT, 
\_SB.PCI0.ISA.EC0.FTMP)))
                     {
                         Store (0x01, \_SB.PCI0.ISA.EC0.FQSB)
                         And (Arg1, 0xFF, Local0)
                         ShiftRight (Arg1, 0x08, Local1)
                         And (Local1, 0xFF, Local1)
                         Acquire (\_SB.PCI0.ISA.EC0.BNKM, 0xFFFF)
                         Store (Local1, \_SB.PCI0.ISA.EC0.CMD3)
                         Store (Local0, \_SB.PCI0.ISA.EC0.CMD2)
                         Store (Arg0, \_SB.PCI0.ISA.EC0.CMD1)
                         Store (0xE9, \_SB.PCI0.ISA.EC0.CMCM)
                         Release (\_SB.PCI0.ISA.EC0.BNKM)
                         Store (0x00, \_SB.PCI0.ISA.EC0.FQSB)
                     }
                 }
 

                 Method (WQS, 2, NotSerialized)
                 {
                     While (LOr (\_SB.PCI0.ISA.EC0.FBAT, 
\_SB.PCI0.ISA.EC0.FTMP))                    {
                         Noop
                     }
 

                     Store (0x01, \_SB.PCI0.ISA.EC0.FQSB)
                     And (Arg1, 0xFF, Local0)
                     ShiftRight (Arg1, 0x08, Local1)
                     And (Local1, 0xFF, Local1)
                     Acquire (\_SB.PCI0.ISA.EC0.BNKM, 0xFFFF)
                     Store (Local1, \_SB.PCI0.ISA.EC0.CMD3)
                     Store (Local0, \_SB.PCI0.ISA.EC0.CMD2)
                     Store (Arg0, \_SB.PCI0.ISA.EC0.CMD1)
                     Store (0xE9, \_SB.PCI0.ISA.EC0.CMCM)
                     Release (\_SB.PCI0.ISA.EC0.BNKM)
                     Store (0x00, \_SB.PCI0.ISA.EC0.FQSB)
                 }


-Cam


-------------------------------------------------------
This SF.Net email is sponsored by: SourceForge.net Broadband
Sign-up now for SourceForge Broadband and get the fastest
6.0/768 connection for only $19.95/mo for the first 3 months!
http://ads.osdn.com/?ad_id=2562&alloc_id=6184&op=click

Re: Fixing broken DSDT - code suggestions for comment please!

[Len Brown]

On Mon, 2004-05-17 at 20:54, Cam wrote:
> Len
> 
> thanks for the feedback and comments,
> 
> Len Brown wrote:
> > Please verify that you still have this problem
> > when running the latest iasl:
> > 
> > http://www.intel.com/technology/IAPC/acpi/downloads.htm
> 
> I was working with iasl-linux-20030918 which I think is the latest. Do 
> you think the Store(Local0, Local0) is an iasl bug? I can send the dsdt 
> binary if you are interested.

Follow the link above to download a version 6 months newer.

> 
> >>Later there are two other errors not mentioned in the FAQ:
> >>
> >>dsdt.dsl  2390:                     Return (WQS (0x0E, Arg0))
> >>Error    1029 -                               ^ Called method returns no 
> >>value
> >> 
> >>
> >>dsdt.dsl  2395:                     Return (WQSB (0x0E, Arg0))
> >>Error    1029 - Called method returns no value ^
> >> 
> 
> [... my bad fix snipped ...]
> 
> > no. the problem is that WQS and WQSB need to have Return() statements.
> 
> OK from another look at the code I see the declarations for the WQS and 
> WQSB methods. I am struggling what to return from these. Zero? Arg0? 
> Arg1? Some success/fail code? Any ideas? There are lots of calls to WQS 
> and WQSB that mostly seem to discard the (not yet) returned value.
> 
> 
>                  Method (WQSB, 2, NotSerialized)
>                  {
>                      If (LNot (LOr (\_SB.PCI0.ISA.EC0.FBAT, 
> \_SB.PCI0.ISA.EC0.FTMP)))
>                      {
>                          Store (0x01, \_SB.PCI0.ISA.EC0.FQSB)
>                          And (Arg1, 0xFF, Local0)
>                          ShiftRight (Arg1, 0x08, Local1)
>                          And (Local1, 0xFF, Local1)
>                          Acquire (\_SB.PCI0.ISA.EC0.BNKM, 0xFFFF)
>                          Store (Local1, \_SB.PCI0.ISA.EC0.CMD3)
>                          Store (Local0, \_SB.PCI0.ISA.EC0.CMD2)
>                          Store (Arg0, \_SB.PCI0.ISA.EC0.CMD1)
>                          Store (0xE9, \_SB.PCI0.ISA.EC0.CMCM)
>                          Release (\_SB.PCI0.ISA.EC0.BNKM)
>                          Store (0x00, \_SB.PCI0.ISA.EC0.FQSB)
>                      }
>                  }
>  
> 
>                  Method (WQS, 2, NotSerialized)
>                  {
>                      While (LOr (\_SB.PCI0.ISA.EC0.FBAT, 
> \_SB.PCI0.ISA.EC0.FTMP))                    {
>                          Noop
>                      }
>  
> 
>                      Store (0x01, \_SB.PCI0.ISA.EC0.FQSB)
>                      And (Arg1, 0xFF, Local0)
>                      ShiftRight (Arg1, 0x08, Local1)
>                      And (Local1, 0xFF, Local1)
>                      Acquire (\_SB.PCI0.ISA.EC0.BNKM, 0xFFFF)
>                      Store (Local1, \_SB.PCI0.ISA.EC0.CMD3)
>                      Store (Local0, \_SB.PCI0.ISA.EC0.CMD2)
>                      Store (Arg0, \_SB.PCI0.ISA.EC0.CMD1)
>                      Store (0xE9, \_SB.PCI0.ISA.EC0.CMCM)
>                      Release (\_SB.PCI0.ISA.EC0.BNKM)
>                      Store (0x00, \_SB.PCI0.ISA.EC0.FQSB)
>                  }

usually the fix to the 'implicit return bug' is to return the value
returned by the last method called.  I guess here you'd return 0?

-Len




-------------------------------------------------------
This SF.Net email is sponsored by: SourceForge.net Broadband
Sign-up now for SourceForge Broadband and get the fastest
6.0/768 connection for only $19.95/mo for the first 3 months!
http://ads.osdn.com/?ad_id=2562&alloc_id=6184&op=click

Re: Fixing broken DSDT - code suggestions for comment please!

[Chris McDermott]

On Mon, May 17, 2004 at 21:00 -0400, Len Brown wrote: 
> On Mon, 2004-05-17 at 20:54, Cam wrote:
> > Len Brown wrote:
> > > Please verify that you still have this problem
> > > when running the latest iasl:
> > > 
> > > http://www.intel.com/technology/IAPC/acpi/downloads.htm
> > 
> > I was working with iasl-linux-20030918 which I think is the latest. Do 
> > you think the Store(Local0, Local0) is an iasl bug? I can send the dsdt 
> > binary if you are interested.
> 
> Follow the link above to download a version 6 months newer.

Following the link above, I see a newer version of iasl for Windows, but not 
for Linux. Is there a version of iasl newer than 20030918 for Linux? Am I
missing something?

thanks,
-- 
-chris



-------------------------------------------------------
This SF.Net email is sponsored by: Oracle 10g
Get certified on the hottest thing ever to hit the market... Oracle 10g. 
Take an Oracle 10g class now, and we'll give you the exam FREE.
http://ads.osdn.com/?ad_id=3149&alloc_id=8166&op=click

Re: Fixing broken DSDT - code suggestions for comment please!

[Cam]

Chris

> Following the link above, I see a newer version of iasl for Windows, but not 
> for Linux. Is there a version of iasl newer than 20030918 for Linux? Am I
> missing something?

Get the sources for linux from that page.

For the record it did not give any different errrors in my case.

-Cam

-- 
camilo-Nk/s8sJ9yP7QXOPxS62xeg@public.gmane.org                                                 <--


-------------------------------------------------------
This SF.Net email is sponsored by: Oracle 10g
Get certified on the hottest thing ever to hit the market... Oracle 10g. 
Take an Oracle 10g class now, and we'll give you the exam FREE.
http://ads.osdn.com/?ad_id=3149&alloc_id=8166&op=click