RE: Re: Oops during startup

Li, Shaohua
2004-06-02T05:42:57Z

Hi,
I don't know if below patch can help you, but it seems there is a
potential error. We should remove gpe handler before address space
hander is removed, since gpe handler may use gpe address space handler.
Please just try.

Thanks
Shaohua

--- 2.6/drivers/acpi/ec.c.orig 2004-06-02 13:31:31.273490992 +0800
+++ 2.6/drivers/acpi/ec.c 2004-06-02 13:32:23.205596112 +0800
@@ -595,11 +595,9 @@ acpi_ec_add (
we now have the *real* EC info, so kill the makeshift one.*/
acpi_evaluate_integer(ec->handle, "_UID", NULL, &uid);
if (ec_ecdt && ec_ecdt->uid == uid) {
+ acpi_remove_gpe_handler(NULL, ec_ecdt->gpe_bit,
&acpi_ec_gpe_handler);
acpi_remove_address_space_handler(ACPI_ROOT_OBJECT,
ACPI_ADR_SPACE_EC, &acpi_ec_space_handler);
-
- acpi_remove_gpe_handler(NULL, ec_ecdt->gpe_bit,
&acpi_ec_gpe_handler);
-
kfree(ec_ecdt);
}

>-----Original Message-----
>From: acpi-devel-admin-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org [mailto:acpi-devel-
>admin-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org] On Behalf Of Ethan Glasser-Camp
>Sent: Wednesday, June 02, 2004 12:29 PM
>To: Yu, Luming; acpi-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org
>Subject: Re: [ACPI] Re: Oops during startup
>
>On Wed, Jun 02, 2004 at 11:17:57AM +0800, Yu, Luming wrote:
>> Please try kernel option: acpi_sci={ level | edge | high | low }
>>
>> --Luming
>
>None of the above resulted in any differences.
>
>Yi Zhu wrote:
>> But firstly could you provide whatever be seen to give us a clue?
>
>Here is my reproduction of the oops, as well as I could do it:
>
> EIP is at acpi_os_read_memory+0x0c/0x60
>eax: c0428120 ebx: c13d6b7c ecx: 00000008 edx: c1233f38
>esi: c13d6b94 edi: c1233f38 ebp: 00000008 esp: c1233edc
>ds: 007b es: 0007b ss: 0068
> Process events/0 (pid:3, threadinfo=c1232000 task=c123cc10)
>Stack: 00001a66 c0246116 c0428120 c04280c0 c1233f38 00000008 c13d6b7c
>c1233f38
> 00000282 c1233f3c c13c72bc 00000282 00000002 c03c18d0 c03c1520
>c025edc8
> 00000008 c1233f38 c13d6b94 c1233f68 c13c72bc c1232000 00000283
>00000000
>
>Call trace:
> [<c0246116>] acpi_hw_low_level_read+0x6e/0x124
> [<c025edc8>] acpi_ec_gpe_query+0x128/0x220
> [<c023019d>] acpi_os_execute_deferred+0x5d/0x80
> [<c0230140>] acpi_os_execute_deferred+0x0/0x80
> [<c0130604>] worker_thread+0x298/0x3dc
> [<c013036c>] worker_thread+0x0/0x3dc
> [<c0230140>] acpi_os_execute_deferred+0x0/0x80
> [<c011913c>] default_wake_function+0x0/0x1c
> [<c011913c>] default_wake_function+0x0/0x1c
> [<c013519c>] kthread+0x70/0xa0
> [<c013512c>] kthread+0x0/0xa0
> [<c0103245>] kernel_thread_helper+0x5/0xc
>
>Code: 8a 80 00 00 00 c0 88 02 eb 26 0f b7 80 00 00 00 c0 66 89 02
><6>note: events/0[3] exited with preempt-count 1
>
>Ethan Glasser-Camp