From: Pavel Machek <pavel-+ZI9xUNit7I@public.gmane.org>
To: "Wang, Zhenyu Z" <zhenyu.z.wang-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
Cc: "Brown, Len" <len.brown-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>,
acpi-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org,
"Yu, Luming" <luming.yu-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>,
"Li,
Shaohua" <shaohua.li-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>,
"Qiang,
Mike" <mike.qiang-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>,
"Zhu, Yi" <yi.zhu-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
Subject: Re: [PATCH] thermal active cooling step
Date: Tue, 22 Jun 2004 19:37:08 +0200 [thread overview]
Message-ID: <20040622173707.GA26555@elf.ucw.cz> (raw)
In-Reply-To: <6E0C289723A0564F9A8279E236E8565F078052FF-4yWAQGcml64divtuJNk2fFDQ4js95KgL@public.gmane.org>
Hi!
> I have a question about thermal active cooling process that we do
> in acpi_thermal_active.
> For example, if _AC0 is lower than current temperature, we set maxtemp
> to _AC0's temperature then turn it on. Next step is checking _AC1, if
> _AC1
> is also lower than current, we turn it on by ignore maxtemp in current
> code.
>
> According to the Spec, _AC0 should be greater than _AC1's cooling
> strength.
> (If two fans are in system, AC0 includes both two and AC1 may include
> one of them)
> So i think the variable maxtemp seems not be used properly here.
>
> Pls, see my patch attached. And correct me if I am wrong.
At least indentation is very wrong. Plus please include patches in the
text, *not* as attachments.
Pavel
--
People were complaining that M$ turns users into beta-testers...
...jr ghea gurz vagb qrirybcref, naq gurl frrz gb yvxr vg gung jnl!
-------------------------------------------------------
This SF.Net email sponsored by Black Hat Briefings & Training.
Attend Black Hat Briefings & Training, Las Vegas July 24-29 -
digital self defense, top technical experts, no vendor pitches,
unmatched networking opportunities. Visit www.blackhat.com
next prev parent reply other threads:[~2004-06-22 17:37 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-05-28 5:23 [PATCH] thermal active cooling step Wang, Zhenyu Z
[not found] ` <6E0C289723A0564F9A8279E236E8565F078052FF-4yWAQGcml64divtuJNk2fFDQ4js95KgL@public.gmane.org>
2004-06-22 17:37 ` Pavel Machek [this message]
-- strict thread matches above, loose matches on Subject: below --
2004-06-23 1:51 Wang, Zhenyu Z
[not found] ` <6E0C289723A0564F9A8279E236E8565F07A55409-4yWAQGcml64divtuJNk2fFDQ4js95KgL@public.gmane.org>
2004-06-23 9:25 ` Pavel Machek
2004-06-23 9:36 Wang, Zhenyu Z
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040622173707.GA26555@elf.ucw.cz \
--to=pavel-+zi9xunit7i@public.gmane.org \
--cc=acpi-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org \
--cc=len.brown-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
--cc=luming.yu-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
--cc=mike.qiang-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
--cc=shaohua.li-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
--cc=yi.zhu-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
--cc=zhenyu.z.wang-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox