Re: pci device resume too early?

[Luca <kronos-0Y2hHv2PMqFeoWH0uzbU5w@public.gmane.org>]

Il Wed, Jul 28, 2004 at 09:18:52PM +0200, Stefan Dösinger ha scritto: 
> I moved device_resume(); in suspend_finish to be called after 
> pm_ops->finish(state); and my system resumes MUCH nicer.
> Sound resume works, usb-uhci resume works, ehci pci restore works. My suspend 
> script will shink a lot.
> 
> That's what suspend_finish looks like:
> 
> static void suspend_finish(u32 state)
> {
> 	if (pm_ops && pm_ops->finish)
> 		pm_ops->finish(state);
> 	device_resume();	/*Call it after pm_ops->finish*/	
> 	thaw_processes();
> 	pm_restore_console();
> }

Well, it may work but it's not correct. ->finish is meant to be called
to finalize the wakeup procedure *after* devices are waked up.

ACPI finish calls acpi_leave_sleep_state() and restore the waking
vectore. I'm not an ACPI guru but my guess is that what you need is
in acpi_leave_sleep_state().

If that's the case we may want to split the finish callback (say
prepare_wake and finish_wake).

Luca
-- 
Home: http://kronoz.cjb.net
"In linea di principio sarei indifferente al natale, se solo il natale
 ricambiasse la cortesia e mi lasciasse in pace." -- Marco d'Itri


-------------------------------------------------------
This SF.Net email is sponsored by BEA Weblogic Workshop
FREE Java Enterprise J2EE developer tools!
Get your free copy of BEA WebLogic Workshop 8.1 today.
http://ads.osdn.com/?ad_idG21&alloc_id\x10040&op=click