[Fwd: [Fwd: patch to include a custom dsdt]]

[Fwd: [Fwd: patch to include a custom dsdt]]

[Len Brown]

[-- Attachment #1: Type: text/plain, Size: 43 bytes --]

This looks handy.
comments?

thanks,
-Len


[-- Attachment #2: Forwarded message - [Fwd: patch to include a custom dsdt] --]
[-- Type: message/rfc822, Size: 7105 bytes --]

[-- Attachment #2.1.1: Type: text/html, Size: 462 bytes --]

[-- Attachment #2.1.2: Type: message/rfc822, Size: 3812 bytes --]

[-- Attachment #2.1.2.1.1: Type: text/html, Size: 1204 bytes --]

[-- Attachment #2.1.2.1.2: acpi_custom_table-2.6.7.patch --]
[-- Type: text/x-diff, Size: 1453 bytes --]

--- linux-2.6.7/drivers/acpi/Kconfig.orig	2004-07-17 10:34:39.000000000 +0200
+++ linux-2.6.7/drivers/acpi/Kconfig	2004-07-17 10:28:11.000000000 +0200
@@ -204,6 +204,23 @@
 	  If you have a legacy free Toshiba laptop (such as the Libretto L1
 	  series), say Y.
 
+config ACPI_CUSTOM_TABLE
+	bool "Include Custom ACPI Table"
+	depends on X86
+	depends on ACPI_INTERPRETER
+	default ""
+	help
+	  Thist option is to load a custom acpi dsdt table, e.g. for buggy acpi 
+	  implementations like on DELL inspiron 5100
+
+config ACPI_CUSTOM_TABLE_FILE
+	string "Custom ACPI Table file to include"
+	depends on ACPI_CUSTOM_TABLE
+	default ""
+	help
+	  please enter the full path name to the file wich includes the AmlCode delclaration
+
+
 config ACPI_DEBUG
 	bool "Debug Statements"
 	depends on ACPI_INTERPRETER
--- linux-2.6.7/drivers/acpi/osl.c.orig	2004-07-17 08:39:55.000000000 +0200
+++ linux-2.6.7/drivers/acpi/osl.c	2004-07-17 10:31:51.000000000 +0200
@@ -55,6 +55,9 @@
     void		    *context;
 };
 
+#ifdef CONFIG_ACPI_CUSTOM_TABLE
+#include CONFIG_ACPI_CUSTOM_TABLE_FILE
+#endif
 
 #ifdef ENABLE_DEBUGGER
 #include <linux/kdb.h>
@@ -235,7 +238,14 @@
 	if (!existing_table || !new_table)
 		return AE_BAD_PARAMETER;
 
+#ifdef CONFIG_ACPI_CUSTOM_TABLE
+	if (strncmp(existing_table->signature, "DSDT", 4) == 0)
+		*new_table = (struct acpi_table_header*)AmlCode;
+	else
+		*new_table = NULL;
+#else
 	*new_table = NULL;
+#endif
 	return AE_OK;
 }
 

Re: [Fwd: [Fwd: patch to include a custom dsdt]]

[Karol Kozimor]

Thus wrote Len Brown:
> This looks handy.
> comments?

I guess the DSDT-in-initrd patch is more flexible, specifying the DSDT at
compile time is clearly not something distro maintainers would love to do
:)
Best regards,

-- 
Karol 'sziwan' Kozimor
sziwan-DETuoxkZsSqrDJvtcaxF/A@public.gmane.org


-------------------------------------------------------
This SF.Net email is sponsored by OSTG. Have you noticed the changes on
Linux.com, ITManagersJournal and NewsForge in the past few weeks? Now,
one more big change to announce. We are now OSTG- Open Source Technology
Group. Come see the changes on the new OSTG site. www.ostg.com

Re: [Fwd: [Fwd: patch to include a custom dsdt]]

[Dominik Brodowski]

On Mon, Aug 09, 2004 at 07:49:36PM +0200, Karol Kozimor wrote:
> Thus wrote Len Brown:
> > This looks handy.
> > comments?
> 
> I guess the DSDT-in-initrd patch is more flexible, specifying the DSDT at
> compile time is clearly not something distro maintainers would love to do
> :)

However, I'd dislike needing to use an initrd. Maybe _both_ options would be
best? Or even three choices, with initramfs being the third...

	Dominik


-------------------------------------------------------
SF.Net email is sponsored by Shop4tech.com-Lowest price on Blank Media
100pk Sonic DVD-R 4x for only $29 -100pk Sonic DVD+R for only $33
Save 50% off Retail on Ink & Toner - Free Shipping and Free Gift.
http://www.shop4tech.com/z/Inkjet_Cartridges/9_108_r285

Re: [Fwd: [Fwd: patch to include a custom dsdt]]

[Stefan Schweizer]

On 09 Aug 2004 12:59:16 -0400, Len Brown <len.brown <at> intel.com> wrote:
> This looks handy.
> comments?

You should take the patch of Michael Blumenstein for initrd support:

http://gaugusch.at/kernel.shtml

http://gaugusch.at/acpi-dsdt-initrd-patches/acpi-dsdt-initrd-patch-v0.4-2.6.7.patch

I use it and I can confirm that it works :)

Stefan


-------------------------------------------------------
This SF.Net email is sponsored by OSTG. Have you noticed the changes on
Linux.com, ITManagersJournal and NewsForge in the past few weeks? Now,
one more big change to announce. We are now OSTG- Open Source Technology
Group. Come see the changes on the new OSTG site. www.ostg.com

Re: [Fwd: [Fwd: patch to include a custom dsdt]]

[Len Brown]

On Mon, 2004-08-09 at 14:28, Stefan Schweizer wrote:
> On 09 Aug 2004 12:59:16 -0400, Len Brown <len.brown <at> intel.com>
> wrote:
> > This looks handy.
> > comments?
> 
> You should take the patch of Michael Blumenstein for initrd support:
> 
> http://gaugusch.at/kernel.shtml
> 
> http://gaugusch.at/acpi-dsdt-initrd-patches/acpi-dsdt-initrd-patch-v0.4-2.6.7.patch
> 
> I use it and I can confirm that it works :)

Yes, the dsdt-in-initrd patch works.
Yes, it is perfect for the unfortunate but determined soul who
administers a variety of broken machines where they all run the same
kernel and require a different DSDT -- I really do feel sorry for that
person and look forward to the day they find non-broken hardware.

But DSDT overrides are for developers, not end-users, not customers.
Nobody can support the OEM's firmware, or a modified version of it
except the OEM themselves.  If a developer happens to fix an OEM's
firmware and sends the OEM the fix, that happy situation is purely
between the end-user and the OEM.  Distros should absolutely never
be in the business of supporting hardware running modified firmware.

I think that one major Distro pulled the dsdt-in-initrd patch, and I
think it was a mistake for them to do so -- they can't support it.

That said, it is useful for developers to be able to override the DSDT.
There are two methods -- re-build kernel or re-build kernel and also
modify the initrd.

Kernel re-build is (I think) simple enought.  I think the patch at hand
takes it from simple to trivial.

Kernel re-build + initrd update I dislike because it depends on the
existence of an initrd (not everybody uses has an initrd, I haven't used
an initrd in over a year), and worse, it depends on the format of the
initrd, which we don't control.

Anyway, I hope that my position, and the reason I haven't pulled the
perfectly functional and useful dsdt-in-initrd patch before is clear.

Any comments on the patch at hand?

thanks,
-Len




-------------------------------------------------------
SF.Net email is sponsored by Shop4tech.com-Lowest price on Blank Media
100pk Sonic DVD-R 4x for only $29 -100pk Sonic DVD+R for only $33
Save 50% off Retail on Ink & Toner - Free Shipping and Free Gift.
http://www.shop4tech.com/z/Inkjet_Cartridges/9_108_r285

Re: [Fwd: [Fwd: patch to include a custom dsdt]]

[Stefan Schweizer]

> Yes, the dsdt-in-initrd patch works.
> Yes, it is perfect for the unfortunate but determined soul who
> administers a variety of broken machines where they all run the same
> kernel and require a different DSDT -- I really do feel sorry for that
> person and look forward to the day they find non-broken hardware.

I only use it on one machine and if I want to change the dsdt I dont
want to recompile my kernel.
> 
> But DSDT overrides are for developers, not end-users, not customers.
> Nobody can support the OEM's firmware, or a modified version of it
> except the OEM themselves.  If a developer happens to fix an OEM's
> firmware and sends the OEM the fix, that happy situation is purely
> between the end-user and the OEM.  Distros should absolutely never
> be in the business of supporting hardware running modified firmware.
Right, distros should not support it, but people who know what they do
should have the ability to do it easy and w/o recompiling the kernel.

> I think that one major Distro pulled the dsdt-in-initrd patch, and I
> think it was a mistake for them to do so -- they can't support it.
They do not need to support it - if people use it, its on their own risk.

> That said, it is useful for developers to be able to override the DSDT.
> There are two methods -- re-build kernel or re-build kernel and also
> modify the initrd.
the difference is I can do the second one without looking into the
howto, because i know where my initrd is - in fact it is the DSDT.aml.
For the first method I would need to know the place where to copy the
dsdt - and always recompile/recopy/reinstall the kernel for minimal
changes.

> Kernel re-build is (I think) simple enought.  I think the patch at hand
> takes it from simple to trivial.


> Kernel re-build + initrd update I dislike because it depends on the
> existence of an initrd (not everybody uses has an initrd, I haven't used
> an initrd in over a year), and worse, it depends on the format of the
> initrd, which we don't control.
Initramfs would be the solution here - why not use it as additional method?
> 
> Anyway, I hope that my position, and the reason I haven't pulled the
> perfectly functional and useful dsdt-in-initrd patch before is clear.
Can you not just provide all possibilities, so that the user, sorry
the "developer", can decide himself how he wants to override his
initrd?


-------------------------------------------------------
SF.Net email is sponsored by Shop4tech.com-Lowest price on Blank Media
100pk Sonic DVD-R 4x for only $29 -100pk Sonic DVD+R for only $33
Save 50% off Retail on Ink & Toner - Free Shipping and Free Gift.
http://www.shop4tech.com/z/Inkjet_Cartridges/9_108_r285

Re: [Fwd: [Fwd: patch to include a custom dsdt]]

[Karol Kozimor]

Thus wrote Len Brown:
> Any comments on the patch at hand?

The patch is pretty straightforward, though I'd guess the help text could
be more general (I mean, there are dozens of systems that require 
overrides), if you really need my $0.02.
Best regards,

-- 
Karol 'sziwan' Kozimor
sziwan-DETuoxkZsSqrDJvtcaxF/A@public.gmane.org


-------------------------------------------------------
SF.Net email is sponsored by Shop4tech.com-Lowest price on Blank Media
100pk Sonic DVD-R 4x for only $29 -100pk Sonic DVD+R for only $33
Save 50% off Retail on Ink & Toner - Free Shipping and Free Gift.
http://www.shop4tech.com/z/Inkjet_Cartridges/9_108_r285

Re: [Fwd: [Fwd: patch to include a custom dsdt]]

[Herman Sheremetyev]

On Mon, 2004-08-09 at 15:41, Len Brown wrote:
<snip>
> Kernel re-build + initrd update I dislike because it depends on the
> existence of an initrd (not everybody uses has an initrd, I haven't used
> an initrd in over a year), and worse, it depends on the format of the
> initrd, which we don't control.
</snip>

Just a quick comment on this, the DSDT-initrd patch doesn't require an
initrd per se, i.e. using mkinitrd to create one, just the initrd option
in the kernel.  It allows you to specify the compiled DSDT file as the
initrd itself making it very easy to change DSDTs without recompiling
the kernel - just compile the DSDT and tell the boot-loader where to
find it with the initrd option.  It also has the ability to detect the
DSDT when it's inserted into an actual initrd but that functionality is
pretty secondary and simply makes the patch usable for those poor people
still using an initrd for some reason.  I do agree that it's definitely
most useful for developers but I think having it as an option in the
main line may be handy for many "advanced users" as well.

-Herman



-------------------------------------------------------
SF.Net email is sponsored by Shop4tech.com-Lowest price on Blank Media
100pk Sonic DVD-R 4x for only $29 -100pk Sonic DVD+R for only $33
Save 50% off Retail on Ink & Toner - Free Shipping and Free Gift.
http://www.shop4tech.com/z/Inkjet_Cartridges/9_108_r285

Re: [Fwd: [Fwd: patch to include a custom dsdt]]

[Stefan Seyfried]

On Mon, Aug 09, 2004 at 03:41:08PM -0400, Len Brown wrote:

> I think that one major Distro pulled the dsdt-in-initrd patch, and I
> think it was a mistake for them to do so -- they can't support it.

Of course we (SUSE) probably cannot support machines with custom DSDT - but
we neither can support the ones with a broken DSDT that just won't work.
But we can give even less support for self-compiled kernels, so the dog
bites its tail.
The DSDT-initrd-Patch at least gives me the possibility to tell a user
"If you are really desperate, you can try to fix your DSDT and override
it by doing this...".

> That said, it is useful for developers to be able to override the DSDT.
> There are two methods -- re-build kernel or re-build kernel and also
> modify the initrd.

With SUSE it is just "ACPI_DSDT=/boot/my/dsdt/file" in a config file
and "mkinitrd" afterwards.
-- 
Stefan Seyfried



-------------------------------------------------------
SF.Net email is sponsored by Shop4tech.com-Lowest price on Blank Media
100pk Sonic DVD-R 4x for only $29 -100pk Sonic DVD+R for only $33
Save 50% off Retail on Ink & Toner - Free Shipping and Free Gift.
http://www.shop4tech.com/z/Inkjet_Cartridges/9_108_r285

Re: [Fwd: [Fwd: patch to include a custom dsdt]]

[Pavel Machek]

Hi!

> This looks handy.
> comments?

It certainly makes life better for developers.

								Pavel

> --- linux-2.6.7/drivers/acpi/Kconfig.orig	2004-07-17 10:34:39.000000000 +0200
> +++ linux-2.6.7/drivers/acpi/Kconfig	2004-07-17 10:28:11.000000000 +0200
> @@ -204,6 +204,23 @@
>  	  If you have a legacy free Toshiba laptop (such as the Libretto L1
>  	  series), say Y.
>  
> +config ACPI_CUSTOM_TABLE
> +	bool "Include Custom ACPI Table"
> +	depends on X86
> +	depends on ACPI_INTERPRETER
> +	default ""
> +	help
> +	  Thist option is to load a custom acpi dsdt table, e.g. for buggy acpi 
> +	  implementations like on DELL inspiron 5100
> +
> +config ACPI_CUSTOM_TABLE_FILE
> +	string "Custom ACPI Table file to include"
> +	depends on ACPI_CUSTOM_TABLE
> +	default ""
> +	help
> +	  please enter the full path name to the file wich includes the AmlCode delclaration
> +
> +
>  config ACPI_DEBUG
>  	bool "Debug Statements"
>  	depends on ACPI_INTERPRETER
> --- linux-2.6.7/drivers/acpi/osl.c.orig	2004-07-17 08:39:55.000000000 +0200
> +++ linux-2.6.7/drivers/acpi/osl.c	2004-07-17 10:31:51.000000000 +0200
> @@ -55,6 +55,9 @@
>      void		    *context;
>  };
>  
> +#ifdef CONFIG_ACPI_CUSTOM_TABLE
> +#include CONFIG_ACPI_CUSTOM_TABLE_FILE
> +#endif
>  
>  #ifdef ENABLE_DEBUGGER
>  #include <linux/kdb.h>
> @@ -235,7 +238,14 @@
>  	if (!existing_table || !new_table)
>  		return AE_BAD_PARAMETER;
>  
> +#ifdef CONFIG_ACPI_CUSTOM_TABLE
> +	if (strncmp(existing_table->signature, "DSDT", 4) == 0)
> +		*new_table = (struct acpi_table_header*)AmlCode;
> +	else
> +		*new_table = NULL;
> +#else
>  	*new_table = NULL;
> +#endif
>  	return AE_OK;
>  }
>  




-- 
People were complaining that M$ turns users into beta-testers...
...jr ghea gurz vagb qrirybcref, naq gurl frrz gb yvxr vg gung jnl!


-------------------------------------------------------
SF.Net email is sponsored by Shop4tech.com-Lowest price on Blank Media
100pk Sonic DVD-R 4x for only $29 -100pk Sonic DVD+R for only $33
Save 50% off Retail on Ink & Toner - Free Shipping and Free Gift.
http://www.shop4tech.com/z/Inkjet_Cartridges/9_108_r285