From mboxrd@z Thu Jan 1 00:00:00 1970 From: Pavel Machek Subject: Re: [RFC, PATCH] sysdev suspend/resume order? Date: Mon, 16 Aug 2004 22:15:31 +0200 Sender: acpi-devel-admin-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org Message-ID: <20040816201530.GG467@openzaurus.ucw.cz> References: <88056F38E9E48644A0F562A38C64FB60029C689B@scsmsx403.amr.corp.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <88056F38E9E48644A0F562A38C64FB60029C689B-exJ48ZlmiLpQxe9IK+vIArfspsVTdybXVpNB7YpNyf8@public.gmane.org> Errors-To: acpi-devel-admin-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , List-Archive: To: "Pallipadi, Venkatesh" Cc: "Li, Shaohua" , Patrick Mochel , Pavel Machek , acpi-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org, "Brown, Len" List-Id: linux-acpi@vger.kernel.org Hi! > One solution to this problem: > Call the sysdev_registers during the actual device > initialization. Say, i8259 sysdev_register should be > called when i8259 device is getting registered and > not with a device_initcall 'sometime' later. Okay, nice trick. At the very least, we should document somewhere that order of sysdev_register matters and that we depend on it. > Questions: > Is this solution proper? > Is there any better solution to this problem? Say > introducing some sort of levels in device_initcall. > If the above soultion is proper, is it > practical/feasible to audit all usages of > sysdev_register() and try to move it to the > device initialization function? I'd hope that for most system devices, order does not matter and we can only audit/fix those that matter. Patrick may have nicer solution in his sleeve, through. -- 64 bytes from 195.113.31.123: icmp_seq=28 ttl=51 time=448769.1 ms ------------------------------------------------------- SF.Net email is sponsored by Shop4tech.com-Lowest price on Blank Media 100pk Sonic DVD-R 4x for only $29 -100pk Sonic DVD+R for only $33 Save 50% off Retail on Ink & Toner - Free Shipping and Free Gift. http://www.shop4tech.com/z/Inkjet_Cartridges/9_108_r285