ibm-acpi-0.1

ibm-acpi-0.1

[Borislav Deianov]

[-- Attachment #1: Type: text/plain, Size: 665 bytes --]

Hi,

This is the first public release of my ACPI driver for IBM ThinkPad
laptops. The features currently supported are:

- hot keys (Fn key combinations)
- docking and undocking
- some basic fan speed control

Note that I've only tested on a ThinkPad X40 with the X4 UltraBase. I
suspect many other recent models are sufficiently similar to work with
this driver but I have no such reports yet.

I'll release this on the linux-thinkpad list as well, but I thought
I'd get some comments here first. This is my first foray into the ACPI
code, so do let me know if I'm doing something horribly wrong. :-)

(Sorry, no web page yet. One thing at a time.)

Thanks,
Boris

[-- Attachment #2: ibm-acpi-0.1.tar.gz --]
[-- Type: application/x-gzip, Size: 9694 bytes --]

Re: ibm-acpi-0.1

[Michael Wahlbrink]

Hi,
Borislav Deianov wrote:
> Hi,
> 
> This is the first public release of my ACPI driver for IBM ThinkPad
> laptops. The features currently supported are:
> 
> - hot keys (Fn key combinations)

all working with my R32 without any special driver ;-)

> - docking and undocking
> - some basic fan speed control

seems to work too with the basic acpi stuff in 2.6 kernels

> 
> Note that I've only tested on a ThinkPad X40 with the X4 UltraBase. I
> suspect many other recent models are sufficiently similar to work with
> this driver but I have no such reports yet.

Ok, I've a IBM ThinkPad R32 but no docking station, so I can't test it.

> I'll release this on the linux-thinkpad list as well, but I thought
> I'd get some comments here first. This is my first foray into the ACPI
> code, so do let me know if I'm doing something horribly wrong. :-)
> 
> (Sorry, no web page yet. One thing at a time.)
Dont care, keep on hacking,

> 
> Thanks,
> Boris
hth&cu
micha (who's glad to obviously don't need a special driver)


-------------------------------------------------------
SF.Net email is sponsored by Shop4tech.com-Lowest price on Blank Media
100pk Sonic DVD-R 4x for only $29 -100pk Sonic DVD+R for only $33
Save 50% off Retail on Ink & Toner - Free Shipping and Free Gift.
http://www.shop4tech.com/z/Inkjet_Cartridges/9_108_r285

Re: ibm-acpi-0.1

[Borislav Deianov]

On Tue, 10 Aug 2004 08:47:04 +0000 (UTC) Michael Wahlbrink <linux.wali-Mmb7MZpHnFY@public.gmane.org> wrote:
> Borislav Deianov wrote:
> > 
> > - hot keys (Fn key combinations)
>
> all working with my R32 without any special driver ;-)

Good for you :-). Do they generate ACPI events or do they just do the
right thing? On the X40, Fn-F4 generates button/sleep, Fn-F7 switches
to external display by itself, the other keys do nothing.

Thanks,
Boris


-------------------------------------------------------
SF.Net email is sponsored by Shop4tech.com-Lowest price on Blank Media
100pk Sonic DVD-R 4x for only $29 -100pk Sonic DVD+R for only $33
Save 50% off Retail on Ink & Toner - Free Shipping and Free Gift.
http://www.shop4tech.com/z/Inkjet_Cartridges/9_108_r285

Re: Re: ibm-acpi-0.1

[Michael Wahlbrink]

Borislav Deianov wrote:

> On Tue, 10 Aug 2004 08:47:04 +0000 (UTC) Michael Wahlbrink <linux.wali-Mmb7MZpHnFY@public.gmane.org> wrote:
> 
>>Borislav Deianov wrote:
>>
>>>- hot keys (Fn key combinations)
>>
>>all working with my R32 without any special driver ;-)
> 
> 
> Good for you :-). Do they generate ACPI events or do they just do the
> right thing? On the X40, Fn-F4 generates button/sleep, Fn-F7 switches
> to external display by itself, the other keys do nothing.
> 
Same here, I've never used the Fn-F3 and Fn-F12 thing cause I don't need 
them ..... wait, F3 and F12 are also not workin... :-( But the keys for 
dimming the display (on a german Keyboard Fn-Pos1 and Fn-Ende and for 
this cool little led-light Fn-Bild^ are working without a problem and 
this are the usual buttons I use.....
so keep on hacking
thanks,
micha

ps: if there is some time I'll test the patch... (then F3 and F12 should 
also generate acpi events??)


-------------------------------------------------------
SF.Net email is sponsored by Shop4tech.com-Lowest price on Blank Media
100pk Sonic DVD-R 4x for only $29 -100pk Sonic DVD+R for only $33
Save 50% off Retail on Ink & Toner - Free Shipping and Free Gift.
http://www.shop4tech.com/z/Inkjet_Cartridges/9_108_r285

Re: Re: ibm-acpi-0.1

[Paul Ionescu]

On Tue, 10 Aug 2004 12:52:53 +0200, Michael Wahlbrink wrote:
> 
> ps: if there is some time I'll test the patch... (then F3 and F12 should 
> also generate acpi events??)

Yes, they do.
ibm/hotkey HKEY 00000080 00001003 for Fn+F3 and
ibm/hotkey HKEY 00000080 0000100c for Fn_F12




-------------------------------------------------------
SF.Net email is sponsored by Shop4tech.com-Lowest price on Blank Media
100pk Sonic DVD-R 4x for only $29 -100pk Sonic DVD+R for only $33
Save 50% off Retail on Ink & Toner - Free Shipping and Free Gift.
http://www.shop4tech.com/z/Inkjet_Cartridges/9_108_r285

Re: ibm-acpi-0.1

[Matthew Garrett]

On Tue, 2004-08-10 at 01:08 -0700, Borislav Deianov wrote:

> I'll release this on the linux-thinkpad list as well, but I thought
> I'd get some comments here first. This is my first foray into the ACPI
> code, so do let me know if I'm doing something horribly wrong. :-)

It (unsurprisingly) works well on my X40. I've added a script to use the
video switch to call i855switch (i810crt works badly on the X40). I'm
entertained to see that you're using the same workaround as me for video
corruption after closing the lid :)

-- 
Matthew Garrett | mjg59-1xO5oi07KQx4cg9Nei1l7Q@public.gmane.org



-------------------------------------------------------
SF.Net email is sponsored by Shop4tech.com-Lowest price on Blank Media
100pk Sonic DVD-R 4x for only $29 -100pk Sonic DVD+R for only $33
Save 50% off Retail on Ink & Toner - Free Shipping and Free Gift.
http://www.shop4tech.com/z/Inkjet_Cartridges/9_108_r285

Re: ibm-acpi-0.1

[Paul Ionescu]

Hi Boris,

On a T41 it inserts in the kernel only if I replace _SB.GDCK with
_SB.PCI0.PCI1.DOCK.
If I don't, I get the following message:
insmod ./ibm_acpi.ko 
insmod: error inserting './ibm_acpi.ko': -1 No such device

and in dmesg I found:
ibm_acpi: acpi_get_handle(\_SB.GDCK) failed

At a fist glance, hot-keys work, but the Fn-F5 does not enable bluetooth
anymore.
I will get back with more feedback.

Thanks,
Paul

On Tue, 10 Aug 2004 01:08:26 -0700, Borislav Deianov wrote:

> Hi,
> 
> This is the first public release of my ACPI driver for IBM ThinkPad
> laptops. The features currently supported are:
> 
> - hot keys (Fn key combinations)
> - docking and undocking
> - some basic fan speed control
> 
> Note that I've only tested on a ThinkPad X40 with the X4 UltraBase. I
> suspect many other recent models are sufficiently similar to work with
> this driver but I have no such reports yet.
> 
> I'll release this on the linux-thinkpad list as well, but I thought
> I'd get some comments here first. This is my first foray into the ACPI
> code, so do let me know if I'm doing something horribly wrong. :-)
> 
> (Sorry, no web page yet. One thing at a time.)
> 
> Thanks,
> Boris




-------------------------------------------------------
SF.Net email is sponsored by Shop4tech.com-Lowest price on Blank Media
100pk Sonic DVD-R 4x for only $29 -100pk Sonic DVD+R for only $33
Save 50% off Retail on Ink & Toner - Free Shipping and Free Gift.
http://www.shop4tech.com/z/Inkjet_Cartridges/9_108_r285

Re: ibm-acpi-0.1

[Paul Ionescu]

Hi Boris,

Some more feedback from my T41.
First, the environment:
Fedora Core 2, Kernel 2.6.8-rc2 vanilla with acpica-20040715 patch.
This is the first version of kernel and acpi that does s3 suspend to ram
reliably on my T41. If you want my dsdt, just tell me and I will send you
privately, because PAN is not able to attach anything to news posts.
(maybe is not even possible).

now:
cd /proc/acpi/ibm
cat fan 
current:        -1 -1 -1
preset1:        3000 3720 4410
preset2:        3120 3520 3800
preset3:        3120 3520 3800
commands:       <low> <medium> <high>, preset1, preset2, preset3

and i found this in dmesg:
ibm_acpi: acpi_invokef(FAN9, d, ...) failed
ibm_acpi: acpi_invokef(FANB, d, ...) failed
ibm_acpi: acpi_invokef(FAND, d, ...) failed
ibm_acpi: acpi_invokef(FAN9, d, ...) failed
ibm_acpi: acpi_invokef(FANB, d, ...) failed
ibm_acpi: acpi_invokef(FAND, d, ...) failed

if I echo preset1 > fan, I got this in dmesg:

ibm_acpi: acpi_invokef(FANS, vddd, ...) failed
ibm_acpi: FANS(3000, 3720, 4410) failed

As for docking, I don't have the dock right now, but I'll test it some
other time.

The hotkey is the only thing working right now, but not completely.
Like I said before, the Fn+F5 should enable/disable the wlan AND the
bluetooth, but with this acpi driver, the bluetooth is not enabled any
more.
The bluetooth is an internal USB device, which gets connected and
disconnected from the USB bus when pressing Fn+F5:

usb 3-1: new full speed USB device using address 4
Bluetooth: HCI USB driver ver 2.6
usbcore: registered new driver hci_usb



> 
> On a T41 it inserts in the kernel only if I replace _SB.GDCK with
> _SB.PCI0.PCI1.DOCK.
> If I don't, I get the following message:
> insmod ./ibm_acpi.ko 
> insmod: error inserting './ibm_acpi.ko': -1 No such device
> 
> and in dmesg I found:
> ibm_acpi: acpi_get_handle(\_SB.GDCK) failed
> 
> At a fist glance, hot-keys work, but the Fn-F5 does not enable bluetooth
> anymore.
> I will get back with more feedback.
> 
> Thanks,
> Paul
> 
> On Tue, 10 Aug 2004 01:08:26 -0700, Borislav Deianov wrote:
> 
>> Hi,
>> 
>> This is the first public release of my ACPI driver for IBM ThinkPad
>> laptops. The features currently supported are:
>> 
>> - hot keys (Fn key combinations)
>> - docking and undocking
>> - some basic fan speed control
>> 
>> Note that I've only tested on a ThinkPad X40 with the X4 UltraBase. I
>> suspect many other recent models are sufficiently similar to work with
>> this driver but I have no such reports yet.
>> 
>> I'll release this on the linux-thinkpad list as well, but I thought
>> I'd get some comments here first. This is my first foray into the ACPI
>> code, so do let me know if I'm doing something horribly wrong. :-)
>> 
>> (Sorry, no web page yet. One thing at a time.)
>> 
>> Thanks,
>> Boris
> 
> 
> 
> 
> -------------------------------------------------------
> SF.Net email is sponsored by Shop4tech.com-Lowest price on Blank Media
> 100pk Sonic DVD-R 4x for only $29 -100pk Sonic DVD+R for only $33
> Save 50% off Retail on Ink & Toner - Free Shipping and Free Gift.
> http://www.shop4tech.com/z/Inkjet_Cartridges/9_108_r285




-------------------------------------------------------
SF.Net email is sponsored by Shop4tech.com-Lowest price on Blank Media
100pk Sonic DVD-R 4x for only $29 -100pk Sonic DVD+R for only $33
Save 50% off Retail on Ink & Toner - Free Shipping and Free Gift.
http://www.shop4tech.com/z/Inkjet_Cartridges/9_108_r285

Re: ibm-acpi-0.1

[Borislav Deianov]

On Tue, 10 Aug 2004 12:21:04 +0000 (UTC) Paul Ionescu <i_p_a_u_l-/E1597aS9LQAvxtiuMwx3w@public.gmane.org> wrote:
> Some more feedback from my T41.

Thanks a lot, Paul, that was very helpful. It looks like I have some
work to do.

> If you want my dsdt, just tell me and I will send you privately,
> because PAN is not able to attach anything to news posts.  (maybe is
> not even possible).

If it's not too much trouble, I'd appreciate it. In the mean time, I'm
looking at a hacked one off http://acpi.sf.net, so it's not very
important.

> ibm_acpi: acpi_invokef(FAN9, d, ...) failed
> ibm_acpi: acpi_invokef(FANS, vddd, ...) failed

Interesting. It seems that the T41 has the fan presets but no methods
to use them. No standard ACPI fan device either. Does it actually have
a fan? :-) I don't think there's much I can do for now apart from
disabling the fan control.

> The hotkey is the only thing working right now, but not completely.
> Like I said before, the Fn+F5 should enable/disable the wlan AND the
> bluetooth, but with this acpi driver, the bluetooth is not enabled
> any more.

That was to be expected. The code for the hot keys usually does
something like this:

if hot key events enabled
	generate event
else
	invoke default hot key behaviour

In this case, the default behaviour is toggling bluetooth on and
off. This should be easy to fix, though - a /proc/acpi/ibm/bluetooth
control would allow you to toggle the state from the ACPI handler for
Fn-F5.

> > On a T41 it inserts in the kernel only if I replace _SB.GDCK with
> > _SB.PCI0.PCI1.DOCK.

I'll make it look for that. As Shaohua noted, though, I'm not yet
scanning the PCI bus on the dock.

> I saw that you use idectl for enabling the cdrom on the docking
> station. I also use idectl to enable my cdrom or secondary hard-disk
> in the UltraBay slim, but I have the following problems: DMA is not
> working any more for hdc after "idectl 1 rescan" After some rescan
> cycles I will have a lot of ide1 in /proc/ide/
>
> See http://bugme.osdl.org/show_bug.cgi?id=2261
>
> Do you have the same problems ?

Yes, although I hadn't noticed DMA was off. I found all these posts
saying that both IDE and ACPI hot plugging are basically not supported
yet, so I was happy to get docking and undocking with the CD drive
working at all...

Thanks,
Boris


-------------------------------------------------------
SF.Net email is sponsored by Shop4tech.com-Lowest price on Blank Media
100pk Sonic DVD-R 4x for only $29 -100pk Sonic DVD+R for only $33
Save 50% off Retail on Ink & Toner - Free Shipping and Free Gift.
http://www.shop4tech.com/z/Inkjet_Cartridges/9_108_r285

Re: Re: ibm-acpi-0.1

[Karol Kozimor]

Thus wrote Borislav Deianov:
> In this case, the default behaviour is toggling bluetooth on and
> off. This should be easy to fix, though - a /proc/acpi/ibm/bluetooth
> control would allow you to toggle the state from the ACPI handler for
> Fn-F5.

Consider doing that from the notify handler, I'd bet that's what the
Windows driver does.
Best regards,

-- 
Karol 'sziwan' Kozimor
sziwan-DETuoxkZsSqrDJvtcaxF/A@public.gmane.org


-------------------------------------------------------
SF.Net email is sponsored by Shop4tech.com-Lowest price on Blank Media
100pk Sonic DVD-R 4x for only $29 -100pk Sonic DVD+R for only $33
Save 50% off Retail on Ink & Toner - Free Shipping and Free Gift.
http://www.shop4tech.com/z/Inkjet_Cartridges/9_108_r285

Re: Re: ibm-acpi-0.1

[Paul Ionescu]

On Wed, 11 Aug 2004 01:32:38 +0200, Karol Kozimor wrote:
> Thus wrote Borislav Deianov:
>> In this case, the default behaviour is toggling bluetooth on and
>> off. This should be easy to fix, though - a /proc/acpi/ibm/bluetooth
>> control would allow you to toggle the state from the ACPI handler for
>> Fn-F5.
> 
> Consider doing that from the notify handler, I'd bet that's what the
> Windows driver does.
> Best regards,

But in this case I think it would be less flexible. Maybe somebody does
not want to enable bluetooth by default with Fn-F5, but only the wlan.
In windows you can specify what action to have for Fn-F5, like
enable/disable for bluetooth, wlan, or bluetooth+wlan.
If you enable/disable the bluetooth from notify handler, then
you could not just enable/disable the wlan with Fn-F5.

Thanks,
Paul




-------------------------------------------------------
SF.Net email is sponsored by Shop4tech.com-Lowest price on Blank Media
100pk Sonic DVD-R 4x for only $29 -100pk Sonic DVD+R for only $33
Save 50% off Retail on Ink & Toner - Free Shipping and Free Gift.
http://www.shop4tech.com/z/Inkjet_Cartridges/9_108_r285

Re: Re: Re: ibm-acpi-0.1

[Karol Kozimor]

Thus wrote Paul Ionescu:
> > Consider doing that from the notify handler, I'd bet that's what the
> > Windows driver does.
> But in this case I think it would be less flexible. Maybe somebody does
> not want to enable bluetooth by default with Fn-F5, but only the wlan.
> In windows you can specify what action to have for Fn-F5, like
> enable/disable for bluetooth, wlan, or bluetooth+wlan.
> If you enable/disable the bluetooth from notify handler, then
> you could not just enable/disable the wlan with Fn-F5.

It's still easier to do that from the notify handler and provide an
interface to enable / disable the specific bits at user request. By moving
it completely to userspace you add another layer of redirection which most
users won't need (as they don't give a damn about writing and configuring
glue scripts) as opposed to having your driver do as expected for most
non-developers. As I said, it's easy to come up with an interface to change
the default behaviour if anybody should wish so.
Best regards,

-- 
Karol 'sziwan' Kozimor
sziwan-DETuoxkZsSqrDJvtcaxF/A@public.gmane.org


-------------------------------------------------------
SF.Net email is sponsored by Shop4tech.com-Lowest price on Blank Media
100pk Sonic DVD-R 4x for only $29 -100pk Sonic DVD+R for only $33
Save 50% off Retail on Ink & Toner - Free Shipping and Free Gift.
http://www.shop4tech.com/z/Inkjet_Cartridges/9_108_r285

Re: Re: Re: ibm-acpi-0.1

[Paul Ionescu]

On Wed, 11 Aug 2004 09:47:17 +0200, Karol Kozimor wrote:

> Thus wrote Paul Ionescu:
>> > Consider doing that from the notify handler, I'd bet that's what the
>> > Windows driver does.
>> But in this case I think it would be less flexible. Maybe somebody does
>> not want to enable bluetooth by default with Fn-F5, but only the wlan.
>> In windows you can specify what action to have for Fn-F5, like
>> enable/disable for bluetooth, wlan, or bluetooth+wlan.
>> If you enable/disable the bluetooth from notify handler, then
>> you could not just enable/disable the wlan with Fn-F5.
> 
> It's still easier to do that from the notify handler and provide an
> interface to enable / disable the specific bits at user request. By moving
> it completely to userspace you add another layer of redirection which most
> users won't need (as they don't give a damn about writing and configuring
> glue scripts) as opposed to having your driver do as expected for most
> non-developers. As I said, it's easy to come up with an interface to change
> the default behaviour if anybody should wish so.
> Best regards,

Well, in this case I don't have any other comments/complains for doing it
in the notify handler.

Thanks,
Paul



-------------------------------------------------------
SF.Net email is sponsored by Shop4tech.com-Lowest price on Blank Media
100pk Sonic DVD-R 4x for only $29 -100pk Sonic DVD+R for only $33
Save 50% off Retail on Ink & Toner - Free Shipping and Free Gift.
http://www.shop4tech.com/z/Inkjet_Cartridges/9_108_r285

Re: ibm-acpi-0.1

[Borislav Deianov]

On Wed, 11 Aug 2004 07:53:03 +0000 (UTC) Karol Kozimor <sziwan-DETuoxkZsSqrDJvtcaxF/A@public.gmane.org> wrote:
>
> It's still easier to do that from the notify handler and provide an
> interface to enable / disable the specific bits at user request. By moving
> it completely to userspace you add another layer of redirection which most
> users won't need (as they don't give a damn about writing and configuring
> glue scripts) as opposed to having your driver do as expected for most
> non-developers. As I said, it's easy to come up with an interface to change
> the default behaviour if anybody should wish so.

Come to think of it, that interface already exists. Here is what the
DSDT does for Fn-F5 (I slightly oversimplified in my previous
message):

if a particular bit is set in the mask
	if hot key events are enabled
        	generate ACPI event
else
        invoke default hot key behaviour

This means that if the driver leaves the mask alone on insmod, the
function keys will continue with their default behavior (e.g. Fn-F5
will toggle bluetooth, Fn-F7 will switch the screens, etc.). Once the
mask is set to include the relevant bits, the default behavior is
stopped and instead ACPI events are generated.

Version 0.1 set the mask on insmod for convenience, but the plan is to
not do that in 0.2. If you want hotkey events, after insmod you'll
have to:

echo enable > /proc/acpi/ibm/hotkey
echo ffff > /proc/acpi/ibm/hotkey

How's that?

Boris


-------------------------------------------------------
SF.Net email is sponsored by Shop4tech.com-Lowest price on Blank Media
100pk Sonic DVD-R 4x for only $29 -100pk Sonic DVD+R for only $33
Save 50% off Retail on Ink & Toner - Free Shipping and Free Gift.
http://www.shop4tech.com/z/Inkjet_Cartridges/9_108_r285

Re: Re: ibm-acpi-0.1

[Karol Kozimor]

Thus wrote Borislav Deianov:
> if a particular bit is set in the mask
> 	if hot key events are enabled
>         	generate ACPI event
> else
>         invoke default hot key behaviour
> 
> This means that if the driver leaves the mask alone on insmod, the
> function keys will continue with their default behavior (e.g. Fn-F5
> will toggle bluetooth, Fn-F7 will switch the screens, etc.). Once the
> mask is set to include the relevant bits, the default behavior is
> stopped and instead ACPI events are generated.

I guess it might still be a good way to go with both, i.e. do the AML magic
to turn the device on _and_ generate an event in case the user wanted to
run hciattach for example. On the other hand, if that's a USB device
hotplug may suffice.
Best regards,

-- 
Karol 'sziwan' Kozimor
sziwan-DETuoxkZsSqrDJvtcaxF/A@public.gmane.org


-------------------------------------------------------
SF.Net email is sponsored by Shop4tech.com-Lowest price on Blank Media
100pk Sonic DVD-R 4x for only $29 -100pk Sonic DVD+R for only $33
Save 50% off Retail on Ink & Toner - Free Shipping and Free Gift.
http://www.shop4tech.com/z/Inkjet_Cartridges/9_108_r285

Re: ibm-acpi-0.1

[Paul Ionescu]

On Fri, 13 Aug 2004 22:34:10 -0700, Borislav Deianov wrote:
> Come to think of it, that interface already exists. Here is what the
> DSDT does for Fn-F5 (I slightly oversimplified in my previous
> message):
> 
> if a particular bit is set in the mask
> 	if hot key events are enabled
>         	generate ACPI event
> else
>         invoke default hot key behaviour
> 
> This means that if the driver leaves the mask alone on insmod, the
> function keys will continue with their default behavior (e.g. Fn-F5
> will toggle bluetooth, Fn-F7 will switch the screens, etc.). Once the
> mask is set to include the relevant bits, the default behavior is
> stopped and instead ACPI events are generated.
> 
> Version 0.1 set the mask on insmod for convenience, but the plan is to
> not do that in 0.2. If you want hotkey events, after insmod you'll
> have to:
> 
> echo enable > /proc/acpi/ibm/hotkey
> echo ffff > /proc/acpi/ibm/hotkey
> 
> How's that?
> 
> Boris

Hi Boris,

Right now, I am using the way you mentioned above, with the hotkey mask,
but it does not provide enough flexibility.
That is because now I can have one or another, but I cannot have both.
What should I do if I want to activate both bluetooth and wireless ?
I have to enable bluetooth AND have an hotkey event for activating the
wireless, because by default is taken care only of the USB bluetooth, but
nothing is done for the wireless.


Thanks,
Paul



-------------------------------------------------------
SF.Net email is sponsored by Shop4tech.com-Lowest price on Blank Media
100pk Sonic DVD-R 4x for only $29 -100pk Sonic DVD+R for only $33
Save 50% off Retail on Ink & Toner - Free Shipping and Free Gift.
http://www.shop4tech.com/z/Inkjet_Cartridges/9_108_r285

Re: Re: ibm-acpi-0.1

[Takanori Watanabe]

In message <pan.2004.08.14.14.34.33.639754-/E1597aS9LQAvxtiuMwx3w@public.gmane.org>, Paul Ionescu ^[$B$5$s$$$o$/^[(B:
>> 
>> How's that?
>> 
>> Boris
>
>Hi Boris,
>
>Right now, I am using the way you mentioned above, with the hotkey mask,
>but it does not provide enough flexibility.
>That is because now I can have one or another, but I cannot have both.
>What should I do if I want to activate both bluetooth and wireless ?

Make wireless interface up and activate Bluetooth by executing 
blutooth activating method:-).

>I have to enable bluetooth AND have an hotkey event for activating the
>wireless, because by default is taken care only of the USB bluetooth, but
>nothing is done for the wireless.

Wireless LED seems to be connected to MINI PCI GPIO register.



-------------------------------------------------------
SF.Net email is sponsored by Shop4tech.com-Lowest price on Blank Media
100pk Sonic DVD-R 4x for only $29 -100pk Sonic DVD+R for only $33
Save 50% off Retail on Ink & Toner - Free Shipping and Free Gift.
http://www.shop4tech.com/z/Inkjet_Cartridges/9_108_r285

Re: Re: ibm-acpi-0.1

[Paul Ionescu]

--- Takanori Watanabe <takawata-PURzwyb9WQGaMJb+Lgu22Q@public.gmane.org> wrote:

> >Right now, I am using the way you mentioned above,
> with the hotkey mask,
> >but it does not provide enough flexibility.
> >That is because now I can have one or another, but
> I cannot have both.
> >What should I do if I want to activate both
> bluetooth and wireless ?
> 
> Make wireless interface up and activate Bluetooth by
> executing 
> blutooth activating method:-).

To make wireless interface up, I need the hotkey
event.
Anyway, this will be solved in next release.

> 
> >I have to enable bluetooth AND have an hotkey event
> for activating the
> >wireless, because by default is taken care only of
> the USB bluetooth, but
> >nothing is done for the wireless.
> 
> Wireless LED seems to be connected to MINI PCI GPIO
> register.

I know.
Atheros drivers will take care of that if compiled
with a special option.



		
__________________________________
Do you Yahoo!?
Yahoo! Mail Address AutoComplete - You start. We finish.
http://promotions.yahoo.com/new_mail 


-------------------------------------------------------
SF.Net email is sponsored by Shop4tech.com-Lowest price on Blank Media
100pk Sonic DVD-R 4x for only $29 -100pk Sonic DVD+R for only $33
Save 50% off Retail on Ink & Toner - Free Shipping and Free Gift.
http://www.shop4tech.com/z/Inkjet_Cartridges/9_108_r285

Re: Re: ibm-acpi-0.1

[Takanori Watanabe]

In message <20040814152051.54002.qmail-k4S4SYk0aM6A/QwVtaZbd3CJp6faPEW9@public.gmane.org>, Paul Ionescu 
wrote:

>> >Right now, I am using the way you mentioned above,
>> with the hotkey mask,
>> >but it does not provide enough flexibility.
>> >That is because now I can have one or another, but
>> I cannot have both.
>> >What should I do if I want to activate both
>> bluetooth and wireless ?
>> 
>> Make wireless interface up and activate Bluetooth by
>> executing 
>> blutooth activating method:-).
>
>To make wireless interface up, I need the hotkey
>event.
>Anyway, this will be solved in next release.


Hmm, SBDC, GBDC method under HKEY device may be related.
SBDC takes two mask value.( 0x2 seems Wireless lan related and
0x4 is Bluetooth attach method, it seems). 
I tried to activate wireless lan in my environment by calling the 
method.
But the wireless LED was not changed so I imageine that it is
not useless for wireless LAN. 
 
>> Wireless LED seems to be connected to MINI PCI GPIO
>> register.
>
>I know.
>Atheros drivers will take care of that if compiled
>with a special option.

Ok, I'm sorry.


-------------------------------------------------------
SF.Net email is sponsored by Shop4tech.com-Lowest price on Blank Media
100pk Sonic DVD-R 4x for only $29 -100pk Sonic DVD+R for only $33
Save 50% off Retail on Ink & Toner - Free Shipping and Free Gift.
http://www.shop4tech.com/z/Inkjet_Cartridges/9_108_r285

Re: ibm-acpi-0.1

[Borislav Deianov]

On Sat, 14 Aug 2004 15:41:20 +0000 (UTC) Takanori Watanabe <takawata-PURzwyb9WQGaMJb+Lgu22Q@public.gmane.org> wrote:
>
> Hmm, SBDC, GBDC method under HKEY device may be related.
> SBDC takes two mask value.( 0x2 seems Wireless lan related and
> 0x4 is Bluetooth attach method, it seems). 

That's what I'm using to control bluetooth in 0.2. As far as I can
tell, 0x2 turns bluetooth on and off, but I have no idea what 0x4
does. It doesn't seem to affect the wireless in any way, so I think
it's also bluetooth-related. I've left it as "unknown" in
/proc/acpi/ibm/bluetooth, hopefully somebody who has bluetooth support
and devices can figure out what it does.

Boris


-------------------------------------------------------
SF.Net email is sponsored by Shop4tech.com-Lowest price on Blank Media
100pk Sonic DVD-R 4x for only $29 -100pk Sonic DVD+R for only $33
Save 50% off Retail on Ink & Toner - Free Shipping and Free Gift.
http://www.shop4tech.com/z/Inkjet_Cartridges/9_108_r285

Re: Re: ibm-acpi-0.1

[Borislav Deianov]

On Wed, Aug 11, 2004 at 01:32:38AM +0200, Karol Kozimor wrote:
> Thus wrote Borislav Deianov:
> > In this case, the default behaviour is toggling bluetooth on and
> > off. This should be easy to fix, though - a /proc/acpi/ibm/bluetooth
> > control would allow you to toggle the state from the ACPI handler for
> > Fn-F5.
> 
> Consider doing that from the notify handler, I'd bet that's what the
> Windows driver does.

That'd be easier but a lot less flexible. Besides, I'd like to expose
the bluetooth presence and status to user space anyway. Any particular
reason not to give full control to user space? That'd be more in line
with how the other keys work, too. All of them now just generate ACPI
events and it's up to the acpid handler to make them do whatever is
necessary. I find that very useful for taking pre- and post-event
actions, or for remapping keys.

Thanks,
Boris


-------------------------------------------------------
SF.Net email is sponsored by Shop4tech.com-Lowest price on Blank Media
100pk Sonic DVD-R 4x for only $29 -100pk Sonic DVD+R for only $33
Save 50% off Retail on Ink & Toner - Free Shipping and Free Gift.
http://www.shop4tech.com/z/Inkjet_Cartridges/9_108_r285

Re: Re: ibm-acpi-0.1

[Karol Kozimor]

Thus wrote Borislav Deianov:
> That'd be easier but a lot less flexible. Besides, I'd like to expose
> the bluetooth presence and status to user space anyway. Any particular
> reason not to give full control to user space? That'd be more in line

No, none at all, control from userspace is needed too.

> with how the other keys work, too. All of them now just generate ACPI
> events and it's up to the acpid handler to make them do whatever is
> necessary. I find that very useful for taking pre- and post-event
> actions, or for remapping keys.

>From my experience, users find it confusing if something works before the
module loads but stops afterwards (and that would be common since you can't
force a sane configuration, especially that you'll probably find machines
that do the BT stuff differently).
Best regards,

-- 
Karol 'sziwan' Kozimor
sziwan-DETuoxkZsSqrDJvtcaxF/A@public.gmane.org


-------------------------------------------------------
SF.Net email is sponsored by Shop4tech.com-Lowest price on Blank Media
100pk Sonic DVD-R 4x for only $29 -100pk Sonic DVD+R for only $33
Save 50% off Retail on Ink & Toner - Free Shipping and Free Gift.
http://www.shop4tech.com/z/Inkjet_Cartridges/9_108_r285

Re: ibm-acpi-0.1

[Paul Ionescu]

On Tue, 10 Aug 2004 16:11:29 -0700, Borislav Deianov wrote:


> If it's not too much trouble, I'd appreciate it. In the mean time, I'm
> looking at a hacked one off http://acpi.sf.net, so it's not very
> important.
> 

I've sent my dsdt to your email at sourceforge.

>> The hotkey is the only thing working right now, but not completely.
>> Like I said before, the Fn+F5 should enable/disable the wlan AND the
>> bluetooth, but with this acpi driver, the bluetooth is not enabled
>> any more.
> 
> That was to be expected. The code for the hot keys usually does
> something like this:
> 
> if hot key events enabled
> 	generate event
> else
> 	invoke default hot key behaviour
> 
> In this case, the default behaviour is toggling bluetooth on and
> off. This should be easy to fix, though - a /proc/acpi/ibm/bluetooth
> control would allow you to toggle the state from the ACPI handler for
> Fn-F5.

Yeap, that would do. I much prefer this option that hard-coding it in the
notify handler. 

>> > On a T41 it inserts in the kernel only if I replace _SB.GDCK with
>> > _SB.PCI0.PCI1.DOCK.
> 
> I'll make it look for that. As Shaohua noted, though, I'm not yet
> scanning the PCI bus on the dock.
Yes, I know that. I managed to test a T50p in a dock, but it doesn't work
as expected. So there may be some IBM magic added in here.

>> Do you have the same problems ?
> 
> Yes, although I hadn't noticed DMA was off. I found all these posts
> saying that both IDE and ACPI hot plugging are basically not supported
> yet, so I was happy to get docking and undocking with the CD drive
> working at all...

Well, they are not supported, but somewhat working half way.
Anyway, if you put a secondary hard disk in the bay as I do, then you WILL
want DMA for sure.

Thanks,
Paul



-------------------------------------------------------
SF.Net email is sponsored by Shop4tech.com-Lowest price on Blank Media
100pk Sonic DVD-R 4x for only $29 -100pk Sonic DVD+R for only $33
Save 50% off Retail on Ink & Toner - Free Shipping and Free Gift.
http://www.shop4tech.com/z/Inkjet_Cartridges/9_108_r285

Re: ibm-acpi-0.1

[Paul Ionescu]

Boris,

First, I want to apologize if this is a little bit off-topic for this
list, but I think that maybe this could be interesting for the others too.

 I saw that you use idectl for enabling the cdrom on the docking
station. I also use idectl to enable my cdrom or secondary hard-disk in
the UltraBay slim, but I have the following problems: DMA is not working
any more for hdc after "idectl 1 rescan" After some rescan cycles I will
have a lot of ide1 in /proc/ide/

See http://bugme.osdl.org/show_bug.cgi?id=2261

Do you have the same problems ?



On Tue, 10 Aug 2004 13:18:09 +0300, Paul Ionescu wrote:

> Hi Boris,
> 
> On a T41 it inserts in the kernel only if I replace _SB.GDCK with
> _SB.PCI0.PCI1.DOCK.
> If I don't, I get the following message:
> insmod ./ibm_acpi.ko 
> insmod: error inserting './ibm_acpi.ko': -1 No such device
> 
> and in dmesg I found:
> ibm_acpi: acpi_get_handle(\_SB.GDCK) failed
> 
> At a fist glance, hot-keys work, but the Fn-F5 does not enable bluetooth
> anymore.
> I will get back with more feedback.
> 
> Thanks,
> Paul
> 
> On Tue, 10 Aug 2004 01:08:26 -0700, Borislav Deianov wrote:
> 
>> Hi,
>> 
>> This is the first public release of my ACPI driver for IBM ThinkPad
>> laptops. The features currently supported are:
>> 
>> - hot keys (Fn key combinations)
>> - docking and undocking
>> - some basic fan speed control
>> 
>> Note that I've only tested on a ThinkPad X40 with the X4 UltraBase. I
>> suspect many other recent models are sufficiently similar to work with
>> this driver but I have no such reports yet.
>> 
>> I'll release this on the linux-thinkpad list as well, but I thought
>> I'd get some comments here first. This is my first foray into the ACPI
>> code, so do let me know if I'm doing something horribly wrong. :-)
>> 
>> (Sorry, no web page yet. One thing at a time.)
>> 
>> Thanks,
>> Boris
> 
> 
> 
> 
> -------------------------------------------------------
> SF.Net email is sponsored by Shop4tech.com-Lowest price on Blank Media
> 100pk Sonic DVD-R 4x for only $29 -100pk Sonic DVD+R for only $33
> Save 50% off Retail on Ink & Toner - Free Shipping and Free Gift.
> http://www.shop4tech.com/z/Inkjet_Cartridges/9_108_r285




-------------------------------------------------------
SF.Net email is sponsored by Shop4tech.com-Lowest price on Blank Media
100pk Sonic DVD-R 4x for only $29 -100pk Sonic DVD+R for only $33
Save 50% off Retail on Ink & Toner - Free Shipping and Free Gift.
http://www.shop4tech.com/z/Inkjet_Cartridges/9_108_r285

Re: Re: ibm-acpi-0.1

[Alan Cox]

On Maw, 2004-08-10 at 12:49, Paul Ionescu wrote:
> station. I also use idectl to enable my cdrom or secondary hard-disk in
> the UltraBay slim, but I have the following problems: DMA is not working
> any more for hdc after "idectl 1 rescan" After some rescan cycles I will
> have a lot of ide1 in /proc/ide/
> 
> See http://bugme.osdl.org/show_bug.cgi?id=2261

The 2.4 kernel supports IDE device hotplugging. The 2.6 maintainer has
consistently refused to merge the change because some bits are ugly
but hasn't done anything else to move it forward either.

You need 2.4 for the ultrabay stuff to work properly right now.

Alan



-------------------------------------------------------
SF.Net email is sponsored by Shop4tech.com-Lowest price on Blank Media
100pk Sonic DVD-R 4x for only $29 -100pk Sonic DVD+R for only $33
Save 50% off Retail on Ink & Toner - Free Shipping and Free Gift.
http://www.shop4tech.com/z/Inkjet_Cartridges/9_108_r285

Re: Re: ibm-acpi-0.1

[Paul Ionescu]

Hi Alan,

As far as I remember, I had the same problems with
2.4.26. But I will try 2.4.27 these days.

You can easily try on your computer to do:
idectl 1 off
idectl 1 on

now see if hdparm -D1 /dev/hdc works anymore (assuming
you have something on /dev/hdc)

and also you will have two of ide1 in /proc/ide

Just give it a try if you have 2.4.x kernel.

Thanks,
Paul

--- Alan Cox <alan-qBU/x9rampVanCEyBjwyrvXRex20P6io@public.gmane.org> wrote:

> On Maw, 2004-08-10 at 12:49, Paul Ionescu wrote:
> > station. I also use idectl to enable my cdrom or
> secondary hard-disk in
> > the UltraBay slim, but I have the following
> problems: DMA is not working
> > any more for hdc after "idectl 1 rescan" After
> some rescan cycles I will
> > have a lot of ide1 in /proc/ide/
> > 
> > See http://bugme.osdl.org/show_bug.cgi?id=2261
> 
> The 2.4 kernel supports IDE device hotplugging. The
> 2.6 maintainer has
> consistently refused to merge the change because
> some bits are ugly
> but hasn't done anything else to move it forward
> either.
> 
> You need 2.4 for the ultrabay stuff to work properly
> right now.
> 
> Alan
> 
> 



		
__________________________________
Do you Yahoo!?
Yahoo! Mail - You care about security. So do we.
http://promotions.yahoo.com/new_mail


-------------------------------------------------------
SF.Net email is sponsored by Shop4tech.com-Lowest price on Blank Media
100pk Sonic DVD-R 4x for only $29 -100pk Sonic DVD+R for only $33
Save 50% off Retail on Ink & Toner - Free Shipping and Free Gift.
http://www.shop4tech.com/z/Inkjet_Cartridges/9_108_r285

Re: Re: ibm-acpi-0.1

[Alan Cox]

On Maw, 2004-08-10 at 13:55, Paul Ionescu wrote:
> now see if hdparm -D1 /dev/hdc works anymore (assuming
> you have something on /dev/hdc)
> 
> and also you will have two of ide1 in /proc/ide
> 
> Just give it a try if you have 2.4.x kernel.

Works perfectly for me with the last 2.4-ac tree. 

Alan



-------------------------------------------------------
SF.Net email is sponsored by Shop4tech.com-Lowest price on Blank Media
100pk Sonic DVD-R 4x for only $29 -100pk Sonic DVD+R for only $33
Save 50% off Retail on Ink & Toner - Free Shipping and Free Gift.
http://www.shop4tech.com/z/Inkjet_Cartridges/9_108_r285

Re: Re: ibm-acpi-0.1

[Paul Ionescu]

Hi Alan,

Then I'll give it a try asap.
Can you please give me link to the latest -ac tree for
2.4.27, or the -ac tree you are using ?

Many thanks,
Paul

--- Alan Cox <alan-qBU/x9rampVanCEyBjwyrvXRex20P6io@public.gmane.org> wrote:

> On Maw, 2004-08-10 at 13:55, Paul Ionescu wrote:
> > now see if hdparm -D1 /dev/hdc works anymore
> (assuming
> > you have something on /dev/hdc)
> > 
> > and also you will have two of ide1 in /proc/ide
> > 
> > Just give it a try if you have 2.4.x kernel.
> 
> Works perfectly for me with the last 2.4-ac tree. 
> 
> Alan
> 
> 



		
__________________________________
Do you Yahoo!?
Y! Messenger - Communicate in real time. Download now. 
http://messenger.yahoo.com


-------------------------------------------------------
SF.Net email is sponsored by Shop4tech.com-Lowest price on Blank Media
100pk Sonic DVD-R 4x for only $29 -100pk Sonic DVD+R for only $33
Save 50% off Retail on Ink & Toner - Free Shipping and Free Gift.
http://www.shop4tech.com/z/Inkjet_Cartridges/9_108_r285

Re: ibm-acpi-0.1

[Paul Ionescu]

On Tue, 10 Aug 2004 01:08:26 -0700, Borislav Deianov wrote:

> Hi,
> 
> This is the first public release of my ACPI driver for IBM ThinkPad
> laptops. The features currently supported are:
> 
> - hot keys (Fn key combinations)
> - docking and undocking
> - some basic fan speed control

Hi Boris,

I found this in the README file:

TODO
----
The following features are planned but not yet implemented:
- LCD on/off switching
- LCD / external display switching
- LED status and control

Other features I'd like to support but don't yet have any information
on:
- TrackPoint tap enable/disable
- motion sensor support


And I can add more ideas to it:

Methods for adjusting LCD brightness and sound volume, and then we can use
an external keyboard to control them. (something like
/proc/acpi/ibm/brightness and /proc/acpi/ibm/volume )

Method to soft eject/insert the device in UltraBay, and capture the event
generated by the pull-off device-from-bay  button.

As for the tapping on Trackpoint, I think it can be programed with the
synaptic driver which can do more than that.
See: http://w1.894.telia.com/~u89404340/touchpad/

And the motion sensor I don't think is an acpi device.

Thanks,
Paul




-------------------------------------------------------
SF.Net email is sponsored by Shop4tech.com-Lowest price on Blank Media
100pk Sonic DVD-R 4x for only $29 -100pk Sonic DVD+R for only $33
Save 50% off Retail on Ink & Toner - Free Shipping and Free Gift.
http://www.shop4tech.com/z/Inkjet_Cartridges/9_108_r285

Re: Re: ibm-acpi-0.1

[Erik Tews]

Am Mi, den 11.08.2004 schrieb Paul Ionescu um 3:01:
> Method to soft eject/insert the device in UltraBay, and capture the event
> generated by the pull-off device-from-bay  button.

This would be really fine, I don't want to reboot everytime I switch
between cd-writer and extra battery.



-------------------------------------------------------
SF.Net email is sponsored by Shop4tech.com-Lowest price on Blank Media
100pk Sonic DVD-R 4x for only $29 -100pk Sonic DVD+R for only $33
Save 50% off Retail on Ink & Toner - Free Shipping and Free Gift.
http://www.shop4tech.com/z/Inkjet_Cartridges/9_108_r285

Re: Re: ibm-acpi-0.1

[Paul Ionescu]

On Wed, 11 Aug 2004 03:44:11 +0200, Erik Tews wrote:
> Am Mi, den 11.08.2004 schrieb Paul Ionescu um 3:01:
>> Method to soft eject/insert the device in UltraBay, and capture the event
>> generated by the pull-off device-from-bay  button.
> 
> This would be really fine, I don't want to reboot everytime I switch
> between cd-writer and extra battery.

Hi Erik,

Even now, without proper ACPI support, you don't have to reboot your
thinkpad to do that.
If you are using an ACPI enabled kernel, then you can just 
"idectl 1 off"
pull out your cdrom
insert your battery
use the battery
eject the battery
insert the cdrom
"idectl 1 on" or "idectl 1 rescan"
use the cdrom


however the DMA on the cdrom will not work because of this bug:
 http://bugme.osdl.org/show_bug.cgi?id=2261

Also, you can use hotplug utility instead of idectl.

Good luck,
Paul



-------------------------------------------------------
SF.Net email is sponsored by Shop4tech.com-Lowest price on Blank Media
100pk Sonic DVD-R 4x for only $29 -100pk Sonic DVD+R for only $33
Save 50% off Retail on Ink & Toner - Free Shipping and Free Gift.
http://www.shop4tech.com/z/Inkjet_Cartridges/9_108_r285

Re: Re: Re: ibm-acpi-0.1

[Erik Tews]

Am Mi, den 11.08.2004 schrieb Paul Ionescu um 11:38:
> Even now, without proper ACPI support, you don't have to reboot your
> thinkpad to do that.
> If you are using an ACPI enabled kernel, then you can just 
> "idectl 1 off"
> pull out your cdrom
> insert your battery
> use the battery
> eject the battery
> insert the cdrom
> "idectl 1 on" or "idectl 1 rescan"
> use the cdrom

Cool, this works.

> however the DMA on the cdrom will not work because of this bug:
>  http://bugme.osdl.org/show_bug.cgi?id=2261

Yes, same thing here, running 2.6.8-rc3 with acpi-patch.



-------------------------------------------------------
SF.Net email is sponsored by Shop4tech.com-Lowest price on Blank Media
100pk Sonic DVD-R 4x for only $29 -100pk Sonic DVD+R for only $33
Save 50% off Retail on Ink & Toner - Free Shipping and Free Gift.
http://www.shop4tech.com/z/Inkjet_Cartridges/9_108_r285

Re: ibm-acpi-0.1

[Borislav Deianov]

On Wed, 11 Aug 2004 01:16:04 +0000 (UTC) Paul Ionescu <i_p_a_u_l-/E1597aS9LQAvxtiuMwx3w@public.gmane.org> wrote:

> TODO
> ----
...
> And I can add more ideas to it:
>
> Methods for adjusting LCD brightness and sound volume, and then we can use
> an external keyboard to control them. (something like
> /proc/acpi/ibm/brightness and /proc/acpi/ibm/volume )
>
> Method to soft eject/insert the device in UltraBay, and capture the event
> generated by the pull-off device-from-bay  button.

Sounds good. I don't know how to do any of that yet, but I'll give it
a try.

Boris


-------------------------------------------------------
SF.Net email is sponsored by Shop4tech.com-Lowest price on Blank Media
100pk Sonic DVD-R 4x for only $29 -100pk Sonic DVD+R for only $33
Save 50% off Retail on Ink & Toner - Free Shipping and Free Gift.
http://www.shop4tech.com/z/Inkjet_Cartridges/9_108_r285

ibm-acpi-0.2

[Borislav Deianov]

Hi,

This is the second alpha release of my ACPI driver for IBM ThinkPad
laptops. The features currently supported are:

	- Fn key combinations
	- Bluetooth enable and disable
	- limited docking and undocking

So far, it has been tested on several T and X series ThinkPads. I
appreciate any user reports, either successful or unsuccessful. Please
see the included README for more information.

Changes since 0.1:

	- fixed problems preventing insmod on the T series and the X20
	- implemented bluetooth enable/disable
	- hotkey events are disabled by default, need explicit enable
	- fixed compilation problem on vanilla 2.6.7
	- dropped fan control, was useless in its current state 

(Sorry, no web page yet. One thing at a time.)

Thanks,
Boris


-- 
The linux-thinkpad mailing list home page is at:
http://mailman.linux-thinkpad.org/mailman/listinfo/linux-thinkpad

Re: ibm-acpi-0.2

[Borislav Deianov]

[-- Attachment #1: Type: text/plain, Size: 239 bytes --]

On Sat, Aug 14, 2004 at 02:12:47PM -0700, borislav wrote:
> Hi,
> 
> This is the second alpha release of my ACPI driver for IBM ThinkPad
> laptops. The features currently supported are:

Argh, forgot to actually attach the .tar.gz.

Boris

[-- Attachment #2: ibm-acpi-0.2.tar.gz --]
[-- Type: application/x-gzip, Size: 16517 bytes --]

R31

[Bernd Schubert]

[-- Attachment #1: Type: text/plain, Size: 2145 bytes --]

Hello Boris,

> > This is the second alpha release of my ACPI driver for IBM ThinkPad
> > laptops. The features currently supported are:
>
> Argh, forgot to actually attach the .tar.gz.
>

thanks a lot for programming the ibm-acpi support.

I guess my R31 is currently not yet supported, well since no path could be 
found ibm_acpi first could not be loaded. Without further knowledge of what 
I'm doing ;-) I added an entry for it:

char *ibm_hkey_paths[] = {
        "\\_SB.PCI0.ISA.EC.HKEY", /* X20 */
        "\\_SB.PCI0.LPC.EC.HKEY", /* X31, X40, T30, T40, T41 */
        "\\_SB.PCI0.ICH3.HKEY", /* R31 */
        NULL,
};

Could you please verify from the attached deassembled dstd if this is correct?

The next problem to load the module was docking support, though the R31 has a 
docking slot I'm not so sure if docking is supported at all.For a first test 
and to get the module loading I simply removed the hole docking stuff from 
"struct ibm_struct ibms".
This worked, but has to be improved of course.

No I can enable hotkey, but setting any mask fails:

beno:/proc/acpi/ibm# cat hotkey
state:          disabled
mask:           0000
commands:       enable, disable, reset, <mask>

beno:/proc/acpi/ibm# echo enable >hotkey
beno:/proc/acpi/ibm# cat hotkey
state:          enabled
mask:           0000
commands:       enable, disable, reset, <mask>

beno:/proc/acpi/ibm# echo "ffff" >hotkey
beno:/proc/acpi/ibm# cat hotkey
state:          enabled
mask:           0000
commands:       enable, disable, reset, <mask>


The most wanted feature from my side is certainly fan control. After I sent my 
R31 to repair last summer since it got much to hot, IBM rejusted the fan 
control which made the fan running permanently, though they only needed to 
make the cooler fitting properly on the cpu.

In v0.1 there was some basic fan control stuff, unfortunality I currently have 
no access to those sources to compare what happend with it. Is there any 
chance to get this working? As I really hate noisy fans, I'm willing to 
investigate time to get some basic fan control, I just need a pointer into 
the right direction.

Thanks,	
	Bernd

[-- Attachment #2: dsdt.asl.gz --]
[-- Type: application/x-gzip, Size: 14280 bytes --]

Re: [ltp] ibm-acpi-0.2

[Dax Kelson]

On Sat, 2004-08-14 at 15:12, Borislav Deianov wrote:
> Hi,
> 
> This is the second alpha release of my ACPI driver for IBM ThinkPad
> laptops. The features currently supported are:
> 
> 	- Fn key combinations
> 	- Bluetooth enable and disable

Without your driver, Bluetooth enable/disable already works fine on my
T42p.

When I press Fn+F5, the led lights up and the following messages show up
in dmesg:

usb 4-1: new full speed USB device using address 2
Bluetooth: Core ver 2.6
NET: Registered protocol family 31
Bluetooth: HCI device and connection manager initialized
Bluetooth: HCI socket layer initialized
Bluetooth: HCI USB driver ver 2.6
usbcore: registered new driver hci_usb

When I press Fn+F5 again, the led turns off and I get:

usb 4-1: USB disconnect, address 2

Does it work differently on older ThinkPads? Can I use your driver
without messing up the already working Bluetooth enable/disable?

Dax Kelson
Guru Labs



-------------------------------------------------------
SF.Net email is sponsored by Shop4tech.com-Lowest price on Blank Media
100pk Sonic DVD-R 4x for only $29 -100pk Sonic DVD+R for only $33
Save 50% off Retail on Ink & Toner - Free Shipping and Free Gift.
http://www.shop4tech.com/z/Inkjet_Cartridges/9_108_r285

Re: ibm-acpi-0.2

[Borislav Deianov]

On Sun, Aug 15, 2004 at 02:19:21AM -0600, Dax Kelson wrote:
> 
> Does it work differently on older ThinkPads? Can I use your driver
> without messing up the already working Bluetooth enable/disable?

Yes, you can. When you first load the driver, Fn-F5 will continue to
work the same way. If you then enable hotkey events and set the mask
to include Fn-F5 (see the README for the full details), Fn-F5 will
instead generate an ACPI event. Using acpid, you can set a script to
run on this event. You can do whatever you want in the script,
including controlling Bluetooth via /proc/acpi/ibm/bluetooth.

Regards,
Boris
-- 
The linux-thinkpad mailing list home page is at:
http://mailman.linux-thinkpad.org/mailman/listinfo/linux-thinkpad

Re: [ltp] ibm-acpi-0.2

[Daniel Pittman]

On 15 Aug 2004, Dax Kelson wrote:
> On Sat, 2004-08-14 at 15:12, Borislav Deianov wrote:
>> Hi,
>>
>> This is the second alpha release of my ACPI driver for IBM ThinkPad
>> laptops. The features currently supported are:
>>
>> 	- Fn key combinations
>> 	- Bluetooth enable and disable
>
> Without your driver, Bluetooth enable/disable already works fine on my
> T42p.

[...]

> Does it work differently on older ThinkPads? 

Yes. My A31p, at least, will only enable the Bluetooth adapter when I
hit a dedicated hardware button on the screen.

This module, presumably, will allow me to control it from software, just
like Windows does.

     Daniel
-- 
CAUTION: This product exerts a force on every other object in the
Universe, proportional to the product of their masses divided by the
square of the distance between them, center to center.



-------------------------------------------------------
SF.Net email is sponsored by Shop4tech.com-Lowest price on Blank Media
100pk Sonic DVD-R 4x for only $29 -100pk Sonic DVD+R for only $33
Save 50% off Retail on Ink & Toner - Free Shipping and Free Gift.
http://www.shop4tech.com/z/Inkjet_Cartridges/9_108_r285

hotkey/video framework [was: ibm-acpi-0.2]

[Hiroshi Miura]

Hi,

'Fn key combination' is common on machines,
so I think we need some abstraction layer or framework on acpi core.

I wrote acpi driver for Panasonic Let's note laptops recentry.
It supports lcd brightness control and hotkey.
Toshiba and asus driver also support hotkey combination.

How do you think about hotkey framework?
Does anyone already work for it?

eg) 

proc interface:
/proc/acpi/hotkey/keymap   --- key num - event meaning map
/proc/acpi/hotkey/mask     --- hotkey enable/disable mask.
/proc/acpi/event           --- send hotkey event to acpid
/proc/acpi/video/lcd/brightness  --- control lcd brightness
/proc/acpi/video/outdev    --- control video output (lcd/crt)
/proc/acpi/ibm/*           --- vendor specific devices conrol


Source tree:
drivers/acpi/video.c      -- video/lcd abstraction driver.
drivers/acpi/hotkey.c     -- hotkey abstraction driver.
drivers/acpi/oem/asus_acpi.c
drivers/acpi/oem/toshiba-acpi.c
drivers/acpi/oem/pcc-acpi.c
drivers/acpi/oem/ibm-acpi.c    -- vendor specific drivers.
				which implement hotkey, video, and lcd etc.


At Sat, 14 Aug 2004 14:12:47 -0700,
Borislav Deianov wrote:
>
> This is the second alpha release of my ACPI driver for IBM ThinkPad
> laptops. The features currently supported are:
> 
> 	- Fn key combinations
> 	- Bluetooth enable and disable
> 	- limited docking and undocking
> 

-- 
Hiroshi Miura  --- http://www.da-cha.org/  --- miura-yiisDzvROlQdnm+yROfE0A@public.gmane.org
NTTDATA Corp. OpenSource Software Center. --- miurahr-3MafRgGXt7BL9jVzuh4AOg@public.gmane.org 
NTTDATA Intellilink Corp. OpenSource Engineering Dev. -- miurahr-w0OK63jvRlAuJ+9fw/WgBHgSJqDPrsil@public.gmane.org
Key fingerprint = 9117 9407 5684 FBF1 4063  15B4 401D D077 04AB 8617


-------------------------------------------------------
SF.Net email is sponsored by Shop4tech.com-Lowest price on Blank Media
100pk Sonic DVD-R 4x for only $29 -100pk Sonic DVD+R for only $33
Save 50% off Retail on Ink & Toner - Free Shipping and Free Gift.
http://www.shop4tech.com/z/Inkjet_Cartridges/9_108_r285

Re: hotkey/video framework [was: ibm-acpi-0.2]

[Borislav Deianov]

On Sun, Aug 15, 2004 at 11:41:30PM +0900, Hiroshi Miura wrote:
> Hi,
> 
> 'Fn key combination' is common on machines,
> so I think we need some abstraction layer or framework on acpi core.

One possibility is to just agree on the proc file format and ACPI
events for the common features, then have each driver implement them
separately. This would probably be simpler than trying to come up with
some sort of a wrapper framework as the code involved is fairly simple
and there probably isn't much we can share. Then again, there might
be, I haven't looked.

I'd be up for something like this, although I'll be busy for a while
getting all the ThinkPad features to work.

Boris


-------------------------------------------------------
SF.Net email is sponsored by Shop4tech.com-Lowest price on Blank Media
100pk Sonic DVD-R 4x for only $29 -100pk Sonic DVD+R for only $33
Save 50% off Retail on Ink & Toner - Free Shipping and Free Gift.
http://www.shop4tech.com/z/Inkjet_Cartridges/9_108_r285

ibm-acpi-0.3

[Borislav Deianov]

Hi,

This is the third alpha release of my ACPI driver for IBM ThinkPad
laptops. The features currently supported are:

	- Fn key combinations
	- Bluetooth enable and disable
	- turning the LCD off, brightness control
	- ThinkLight on/off
	- limited docking and undocking

So far, it has been tested on several T, X and R series ThinkPads. I
appreciate any user reports, either successful or unsuccessful. Please
see the included README for more information.

Changes since 0.2:

	- fixed problems preventing insmod on the R40
	- implemented LCD brightness control and turning off
	- implemented ThinkLight on/off

I just noticed that turning the LCD off only works in X, not on the
console, at least for me. I'll need to look into this further.

Finally, a download URL:

http://bkernel.sf.net/tmp/ibm-acpi-0.3.tar.gz

Still no web page.

I'll be on vacation for the next three weeks, so I'll be a little slow
with replies to email. If you are replying to the lists, I'd
appreciate a CC, I'd see it sooner that way.

Boris
-- 
The linux-thinkpad mailing list home page is at:
http://mailman.linux-thinkpad.org/mailman/listinfo/linux-thinkpad

RE: ibm-acpi-0.1

[Li, Shaohua]

Hi,
IBM hotkey has a unique ID. In T40, it's 'IBM0068'. I guess other IBM
laptops also use it. Using a hardcode path in the patch possibly isn't a
good idea. 
BTW, I'm interested in how can you know the meaning of 'DHKC', 'MHKC'
and etc. They are non-standard ACPI methods.

Thanks,
Shaohua

>-----Original Message-----
>From: acpi-devel-admin-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org [mailto:acpi-devel-
>admin-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org] On Behalf Of Borislav Deianov
>Sent: Tuesday, August 10, 2004 4:08 PM
>To: acpi-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org
>Subject: [ACPI] ibm-acpi-0.1
>
>Hi,
>
>This is the first public release of my ACPI driver for IBM ThinkPad
>laptops. The features currently supported are:
>
>- hot keys (Fn key combinations)
>- docking and undocking
>- some basic fan speed control
>
>Note that I've only tested on a ThinkPad X40 with the X4 UltraBase. I
>suspect many other recent models are sufficiently similar to work with
>this driver but I have no such reports yet.
>
>I'll release this on the linux-thinkpad list as well, but I thought
>I'd get some comments here first. This is my first foray into the ACPI
>code, so do let me know if I'm doing something horribly wrong. :-)
>
>(Sorry, no web page yet. One thing at a time.)
>
>Thanks,
>Boris


-------------------------------------------------------
SF.Net email is sponsored by Shop4tech.com-Lowest price on Blank Media
100pk Sonic DVD-R 4x for only $29 -100pk Sonic DVD+R for only $33
Save 50% off Retail on Ink & Toner - Free Shipping and Free Gift.
http://www.shop4tech.com/z/Inkjet_Cartridges/9_108_r285

Re: ibm-acpi-0.1

[Borislav Deianov]

On Tue, Aug 10, 2004 at 04:24:39PM +0800, Li, Shaohua wrote:
>
> IBM hotkey has a unique ID. In T40, it's 'IBM0068'. I guess other
> IBM laptops also use it. Using a hardcode path in the patch possibly
> isn't a good idea.

Agreed. I was originally using acpi_bus_register_driver() and refering
to devices by HID but that turned out to not work very well for the
dock (ACPI drops it if it's not present at boot) and embedded
controller (the ec driver has already grabbed it). So I switched to
looking things up by the path. I see your point, though, I'll see what
I can do.

> BTW, I'm interested in how can you know the meaning of 'DHKC',
> 'MHKC' and etc. They are non-standard ACPI methods.

Guesswork from the disassembled DSDT and trial and error...

Regards,
Boris


-------------------------------------------------------
SF.Net email is sponsored by Shop4tech.com-Lowest price on Blank Media
100pk Sonic DVD-R 4x for only $29 -100pk Sonic DVD+R for only $33
Save 50% off Retail on Ink & Toner - Free Shipping and Free Gift.
http://www.shop4tech.com/z/Inkjet_Cartridges/9_108_r285

Re: ibm-acpi-0.1

[Takanori Watanabe]

In message <20040810083807.GF28939-AKoe11r2kkOzaBltdDZI6w@public.gmane.org>, Borislav Deianov wrote:
>On Tue, Aug 10, 2004 at 04:24:39PM +0800, Li, Shaohua wrote:
>>
>> IBM hotkey has a unique ID. In T40, it's 'IBM0068'. I guess other
>> IBM laptops also use it. Using a hardcode path in the patch possibly
>> isn't a good idea.
>
>Agreed. I was originally using acpi_bus_register_driver() and refering
>to devices by HID but that turned out to not work very well for the
>dock (ACPI drops it if it's not present at boot) and embedded
>controller (the ec driver has already grabbed it). So I switched to
>looking things up by the path. I see your point, though, I'll see what
>I can do.

Probably this may unable to work on other Thinkpads.
I have X31 and i1620, and there are some incompatibility on 
AML between two.
Generic notify events Bus check, Device Wake, Eject request,
may have to be caught by enumrator.

>> BTW, I'm interested in how can you know the meaning of 'DHKC',
>> 'MHKC' and etc. They are non-standard ACPI methods.
>
>Guesswork from the disassembled DSDT and trial and error...

I wrote such driver for FreeBSD (though I don't implement
docking station).

http://www.init-main.com/acpi_tpkey/



-------------------------------------------------------
SF.Net email is sponsored by Shop4tech.com-Lowest price on Blank Media
100pk Sonic DVD-R 4x for only $29 -100pk Sonic DVD+R for only $33
Save 50% off Retail on Ink & Toner - Free Shipping and Free Gift.
http://www.shop4tech.com/z/Inkjet_Cartridges/9_108_r285

Re: ibm-acpi-0.1

[Borislav Deianov]

On Tue, Aug 10, 2004 at 06:19:20PM +0900, Takanori Watanabe wrote:
>
> I wrote such driver for FreeBSD (though I don't implement
> docking station).
> 
> http://www.init-main.com/acpi_tpkey/

I'll have a look, thanks!

Boris


-------------------------------------------------------
SF.Net email is sponsored by Shop4tech.com-Lowest price on Blank Media
100pk Sonic DVD-R 4x for only $29 -100pk Sonic DVD+R for only $33
Save 50% off Retail on Ink & Toner - Free Shipping and Free Gift.
http://www.shop4tech.com/z/Inkjet_Cartridges/9_108_r285

Re: ibm-acpi-0.1

[Len Brown]

On Tue, 2004-08-10 at 04:38, Borislav Deianov wrote:
> On Tue, Aug 10, 2004 at 04:24:39PM +0800, Li, Shaohua wrote:
> >
> > IBM hotkey has a unique ID. In T40, it's 'IBM0068'. I guess other
> > IBM laptops also use it. Using a hardcode path in the patch possibly
> > isn't a good idea.
> 
> Agreed. I was originally using acpi_bus_register_driver() and refering
> to devices by HID but that turned out to not work very well for the
> dock (ACPI drops it if it's not present at boot) and embedded
> controller (the ec driver has already grabbed it). So I switched to
> looking things up by the path. I see your point, though, I'll see what
> I can do.

please stick with the HID method if you can.

Docking is a big hole in linux.  Probably there is some docking even
that we need to handle and perhaps re-initialize the driver.

> 
> > BTW, I'm interested in how can you know the meaning of 'DHKC',
> > 'MHKC' and etc. They are non-standard ACPI methods.
> 
> Guesswork from the disassembled DSDT and trial and error...
> 
> Regards,
> Boris
> 
> 
> -------------------------------------------------------
> SF.Net email is sponsored by Shop4tech.com-Lowest price on Blank Media
> 100pk Sonic DVD-R 4x for only $29 -100pk Sonic DVD+R for only $33
> Save 50% off Retail on Ink & Toner - Free Shipping and Free Gift.
> http://www.shop4tech.com/z/Inkjet_Cartridges/9_108_r285
> _______________________________________________
> Acpi-devel mailing list
> Acpi-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org
> https://lists.sourceforge.net/lists/listinfo/acpi-devel



-------------------------------------------------------
SF.Net email is sponsored by Shop4tech.com-Lowest price on Blank Media
100pk Sonic DVD-R 4x for only $29 -100pk Sonic DVD+R for only $33
Save 50% off Retail on Ink & Toner - Free Shipping and Free Gift.
http://www.shop4tech.com/z/Inkjet_Cartridges/9_108_r285

Re: ibm-acpi-0.1

[Borislav Deianov]

Hi Len,

Apologies for taking so long to reply.

On Wed, Aug 18, 2004 at 01:09:22AM -0400, Len Brown wrote:
> On Tue, 2004-08-10 at 04:38, Borislav Deianov wrote:
> > On Tue, Aug 10, 2004 at 04:24:39PM +0800, Li, Shaohua wrote:
> > >
> > > IBM hotkey has a unique ID. In T40, it's 'IBM0068'. I guess other
> > > IBM laptops also use it. Using a hardcode path in the patch possibly
> > > isn't a good idea.
> > 
> > Agreed. I was originally using acpi_bus_register_driver() and refering
> > to devices by HID but that turned out to not work very well for the
> > dock (ACPI drops it if it's not present at boot) and embedded
> > controller (the ec driver has already grabbed it). So I switched to
> > looking things up by the path. I see your point, though, I'll see what
> > I can do.
> 
> please stick with the HID method if you can.

I'd like to, but, for the most part, I can't. The two problems above
still stand: I need to access devices not present at boot time, and I
need to access devices already grabbed by other drivers. In addition,
I need to access devices and methods which just don't have
HIDs. Basically, out of the six features currently supported by
ibm-acpi, two can be done via acpi_bus_register_driver(). For the
other four, I need to call acpi_get_handle() (with several hard-coded
alternative paths). I use the latter method for all features,
simplifies the structure of the driver quite a bit.

Would you consider something like acpi_get_handle_by_hid() (which can
also access non-present devices)? That would help a lot.

On Wed, Aug 18, 2004 at 01:41:37AM -0400, Len Brown wrote:
> what's the GLOBAL_NOTIFY stuff about?
> 
>         status = acpi_install_notify_handler(ACPI_ROOT_OBJECT,
>                                              ACPI_DEVICE_NOTIFY,
>                                              global_notify, NULL);
> 

Used it for debugging before I figured out how to use
/proc/acpi/debug_*.  Got rid of it in 0.4.

On Wed, Aug 18, 2004 at 09:38:18AM -0400, Len Brown wrote:
> On Wed, 2004-08-18 at 09:23, Henrik Brix Andersen wrote:
> > On Wed, 2004-08-18 at 07:42, Len Brown wrote:
> > > #!/bin/bash
> > > 
> > > if ! /sbin/rmmod ipw2100; then
> > >         /sbin/service network restart
> > > fi
> > > 
> > > 
> > > Does this means that the button press magically changed
> > > the state of the radio in hardware?  I didn't see any
> > > processing inside the driver to do that.
> > 
> > No. The listed radio.sh script just unloads the ipw2100 module from
> > memory which effectively disables the wireless network connection.
> 
> So rather than actually disabling the radio, we're diabling the network
> by unloading the driver?  Is there an indicator light that says if the
> radio is enalbed?  Does is stay on?

The "antenna" LED goes off and power consumption goes down a bit, so I
assume unloading the module does turn off the radio. My laptop doesn't
have a software kill switch, so not much else I can do.

Regards,
Boris


-------------------------------------------------------
This SF.Net email is sponsored by: YOU BE THE JUDGE. Be one of 170
Project Admins to receive an Apple iPod Mini FREE for your judgement on
who ports your project to Linux PPC the best. Sponsored by IBM.
Deadline: Sept. 24. Go here: http://sf.net/ppc_contest.php

Re: ibm-acpi-0.3

[Paul Ionescu]

Hi Boris,

Here is the feedback for the new features of ibm_acpi-0.3 on IBM T41/R50p :

ThinkLight works (on/off)
LCD (up/down/off) does not work, but it does increment the brightness
level reported by "tpb".
This means that if I "echo up > lcd", the tbp OSD increments, but the LCD
is at the same level of brightness.
Moreover "echo off > lcd" triggers an AccessIBM button event in "tpb"

And have a happy holiday.

Thanks,
Paul


On Tue, 17 Aug 2004 02:19:21 -0700, Borislav Deianov wrote:

> Hi,
> 
> This is the third alpha release of my ACPI driver for IBM ThinkPad
> laptops. The features currently supported are:
> 
> 	- Fn key combinations
> 	- Bluetooth enable and disable
> 	- turning the LCD off, brightness control - ThinkLight on/off
> 	- limited docking and undocking
> 
> So far, it has been tested on several T, X and R series ThinkPads. I
> appreciate any user reports, either successful or unsuccessful. Please see
> the included README for more information.
> 
> Changes since 0.2:
> 
> 	- fixed problems preventing insmod on the R40 - implemented LCD
> 	brightness control and turning off - implemented ThinkLight on/off
> 
> I just noticed that turning the LCD off only works in X, not on the
> console, at least for me. I'll need to look into this further.
> 
> Finally, a download URL:
> 
> http://bkernel.sf.net/tmp/ibm-acpi-0.3.tar.gz
> 
> Still no web page.
> 
> I'll be on vacation for the next three weeks, so I'll be a little slow
> with replies to email. If you are replying to the lists, I'd appreciate a
> CC, I'd see it sooner that way.
> 
> Boris


-- 
The linux-thinkpad mailing list home page is at:
http://mailman.linux-thinkpad.org/mailman/listinfo/linux-thinkpad

Re: ibm-acpi-0.3

[Matthew Garrett]

On Tue, 2004-08-17 at 02:19 -0700, Borislav Deianov wrote:

> 	- turning the LCD off, brightness control

On my X40, brightness control works but I don't seem to be able to
switch the screen off.

-- 
Matthew Garrett | mjg59-1xO5oi07KQx4cg9Nei1l7Q@public.gmane.org



-------------------------------------------------------
SF.Net email is sponsored by Shop4tech.com-Lowest price on Blank Media
100pk Sonic DVD-R 4x for only $29 -100pk Sonic DVD+R for only $33
Save 50% off Retail on Ink & Toner - Free Shipping and Free Gift.
http://www.shop4tech.com/z/Inkjet_Cartridges/9_108_r285

Re: ibm-acpi-0.3

[Len Brown]

what's the GLOBAL_NOTIFY stuff about?

        status = acpi_install_notify_handler(ACPI_ROOT_OBJECT,
                                             ACPI_DEVICE_NOTIFY,
                                             global_notify, NULL);




-------------------------------------------------------
SF.Net email is sponsored by Shop4tech.com-Lowest price on Blank Media
100pk Sonic DVD-R 4x for only $29 -100pk Sonic DVD+R for only $33
Save 50% off Retail on Ink & Toner - Free Shipping and Free Gift.
http://www.shop4tech.com/z/Inkjet_Cartridges/9_108_r285

Re: ibm-acpi-0.3

[Len Brown]

> http://bkernel.sf.net/tmp/ibm-acpi-0.3.tar.gz

The radio hot key sends an ACPI event,
and the acpid example calls this radio.sh:

#!/bin/bash

if ! /sbin/rmmod ipw2100; then
        /sbin/service network restart
fi


Does this means that the button press magically changed
the state of the radio in hardware?  I didn't see any
processing inside the driver to do that.

thanks,
-Len




-------------------------------------------------------
SF.Net email is sponsored by Shop4tech.com-Lowest price on Blank Media
100pk Sonic DVD-R 4x for only $29 -100pk Sonic DVD+R for only $33
Save 50% off Retail on Ink & Toner - Free Shipping and Free Gift.
http://www.shop4tech.com/z/Inkjet_Cartridges/9_108_r285

Re: [Ipw2100-devel] Re: [ACPI] ibm-acpi-0.3

[Henrik Brix Andersen]

Hi,

On Wed, 2004-08-18 at 07:42, Len Brown wrote:
> > http://bkernel.sf.net/tmp/ibm-acpi-0.3.tar.gz
> 
> The radio hot key sends an ACPI event,
> and the acpid example calls this radio.sh:
> 
> #!/bin/bash
> 
> if ! /sbin/rmmod ipw2100; then
>         /sbin/service network restart
> fi
> 
> 
> Does this means that the button press magically changed
> the state of the radio in hardware?  I didn't see any
> processing inside the driver to do that.

No. The listed radio.sh script just unloads the ipw2100 module from
memory which effectively disables the wireless network connection.

Regards,
Brix
-- 
Henrik Brix Andersen <brix@gimp.org>

-- 
The linux-thinkpad mailing list home page is at:
http://mailman.linux-thinkpad.org/mailman/listinfo/linux-thinkpad

Re: [Ipw2100-devel] Re: ibm-acpi-0.3

[Len Brown]

On Wed, 2004-08-18 at 09:23, Henrik Brix Andersen wrote:
> Hi,
> 
> On Wed, 2004-08-18 at 07:42, Len Brown wrote:
> > > http://bkernel.sf.net/tmp/ibm-acpi-0.3.tar.gz
> > 
> > The radio hot key sends an ACPI event,
> > and the acpid example calls this radio.sh:
> > 
> > #!/bin/bash
> > 
> > if ! /sbin/rmmod ipw2100; then
> >         /sbin/service network restart
> > fi
> > 
> > 
> > Does this means that the button press magically changed
> > the state of the radio in hardware?  I didn't see any
> > processing inside the driver to do that.
> 
> No. The listed radio.sh script just unloads the ipw2100 module from
> memory which effectively disables the wireless network connection.

So rather than actually disabling the radio, we're diabling the network
by unloading the driver?  Is there an indicator light that says if the
radio is enalbed?  Does is stay on?

thanks,
-Len




-------------------------------------------------------
SF.Net email is sponsored by Shop4tech.com-Lowest price on Blank Media
100pk Sonic DVD-R 4x for only $29 -100pk Sonic DVD+R for only $33
Save 50% off Retail on Ink & Toner - Free Shipping and Free Gift.
http://www.shop4tech.com/z/Inkjet_Cartridges/9_108_r285

Re: [Ipw2100-devel] Re: ibm-acpi-0.3

[James Ketrenos]

Len Brown wrote:

>>http://bkernel.sf.net/tmp/ibm-acpi-0.3.tar.gz
>>    
>>
>
>The radio hot key sends an ACPI event,
>and the acpid example calls this radio.sh:
>
>#!/bin/bash
>
>if ! /sbin/rmmod ipw2100; then
>        /sbin/service network restart
>fi
>
>
>Does this means that the button press magically changed
>the state of the radio in hardware?  I didn't see any
>processing inside the driver to do that.
>  
>
The laptop might not actually have any RF switch circuitry to signal the 
GPIO pin -- so on detection of keypress, it fully removes and reloads 
the module (which will have the result of powering off/on the radio with 
the side effect of loading/unloading any modules  and services also 
listed in the network service)

As of 0.53 (since the proc entries are all broken in 0.52) the script 
could be changed to do something more along these lines (until we change 
from proc to sysfs and from strings to ints):

#!/bin/sh
if grep -q disabled /proc/net/ipw2100/eth1/state; then
    echo 0 > /proc/net/ipw2100/eth1/state
else
    echo 1 > /proc/net/ipw2100/eth1/state
fi

The above will check the state of the RF kill switch.  If the radio is 
disabled, it enables it (by turning off the kill state), etc.  The link 
state will toggle based on whether the device is associated -- and that 
is likely what the various service scripts should be tied to (vs. 
whether or not the module is loaded)

James



-------------------------------------------------------
SF.Net email is sponsored by Shop4tech.com-Lowest price on Blank Media
100pk Sonic DVD-R 4x for only $29 -100pk Sonic DVD+R for only $33
Save 50% off Retail on Ink & Toner - Free Shipping and Free Gift.
http://www.shop4tech.com/z/Inkjet_Cartridges/9_108_r285

Re: [Ipw2100-devel] Re: ibm-acpi-0.3

[Matthew Garrett]

On Wed, 2004-08-18 at 10:27 -0500, James Ketrenos wrote:

> As of 0.53 (since the proc entries are all broken in 0.52) the script 
> could be changed to do something more along these lines (until we change 
> from proc to sysfs and from strings to ints):

Surely going to /sys/bus/pci/devices/whatever/power/state is more
useful? In the long run that'll probably also power down the device,
which seems to save me a few hundred mW over just removing the module.

-- 
Matthew Garrett | mjg59-1xO5oi07KQx4cg9Nei1l7Q@public.gmane.org



-------------------------------------------------------
SF.Net email is sponsored by Shop4tech.com-Lowest price on Blank Media
100pk Sonic DVD-R 4x for only $29 -100pk Sonic DVD+R for only $33
Save 50% off Retail on Ink & Toner - Free Shipping and Free Gift.
http://www.shop4tech.com/z/Inkjet_Cartridges/9_108_r285

Re: ibm-acpi-0.3

[Vincent Touquet]

Hi Borislav,

I noticed this post on lkml:
http://marc.theaimsgroup.com/?l=linux-kernel&m=109300540306110&w=2

I think it deals with the same issues as your code, maybe things
can be shared or merged ? I already mailed the author to point to your
code.

best regards,

Vincent
-- 
The linux-thinkpad mailing list home page is at:
http://mailman.linux-thinkpad.org/mailman/listinfo/linux-thinkpad

RE: hotkey/video framework [was: ibm-acpi-0.2]

[Yu, Luming]

>> 
>> 'Fn key combination' is common on machines,
>> so I think we need some abstraction layer or framework on acpi core.
>
>One possibility is to just agree on the proc file format and ACPI
>events for the common features, then have each driver implement them
>separately. This would probably be simpler than trying to come up with
>some sort of a wrapper framework as the code involved is fairly simple
>and there probably isn't much we can share. Then again, there might
>be, I haven't looked.
>

I think the proposaled framework/abstraction layer is NOT just for 
code sharing. We need to dynamically load the proper hotkey/video driver
.

Thanks,
Luming  


-------------------------------------------------------
SF.Net email is sponsored by Shop4tech.com-Lowest price on Blank Media
100pk Sonic DVD-R 4x for only $29 -100pk Sonic DVD+R for only $33
Save 50% off Retail on Ink & Toner - Free Shipping and Free Gift.
http://www.shop4tech.com/z/Inkjet_Cartridges/9_108_r285

Re: hotkey/video framework [was: ibm-acpi-0.2]

[Karol Kozimor]

Thus wrote Yu, Luming:
> >One possibility is to just agree on the proc file format and ACPI
> >events for the common features, then have each driver implement them
> >separately. This would probably be simpler than trying to come up with
> >some sort of a wrapper framework as the code involved is fairly simple
> >and there probably isn't much we can share. Then again, there might
> >be, I haven't looked.
> I think the proposaled framework/abstraction layer is NOT just for 
> code sharing. We need to dynamically load the proper hotkey/video driver

While binding all HIDs in one place should be fairly easy, I don't think I
see an advantage to that as opposed to a modrobe *_acpi solution,
especially now that the fix to acpi_bus_register_driver() is in place.

As for the video, if a certain API was agreed on, the generic driver could
provide an abstraction that vendor-specific drivers could bind on. What I'm
afraid of is that the components and AML code used are so diverse that the
management of such a layer becomes a nightmare.

Best regards,

-- 
Karol 'sziwan' Kozimor
sziwan-DETuoxkZsSqrDJvtcaxF/A@public.gmane.org


-------------------------------------------------------
SF.Net email is sponsored by Shop4tech.com-Lowest price on Blank Media
100pk Sonic DVD-R 4x for only $29 -100pk Sonic DVD+R for only $33
Save 50% off Retail on Ink & Toner - Free Shipping and Free Gift.
http://www.shop4tech.com/z/Inkjet_Cartridges/9_108_r285

Re: hotkey/video framework [was: ibm-acpi-0.2]

[Hiroshi Miura]

Hi,

At Tue, 17 Aug 2004 17:15:17 +0800,
Yu, Luming wrote:
> 
> >> 
> >> 'Fn key combination' is common on machines,
> >> so I think we need some abstraction layer or framework on acpi core.
> >
> >One possibility is to just agree on the proc file format and ACPI
> >events for the common features,

I think it's good start. 

> > then have each driver implement them
> >separately. This would probably be simpler than trying to come up with
> >some sort of a wrapper framework as the code involved is fairly simple
> >and there probably isn't much we can share. Then again, there might
> >be, I haven't looked.
> >
> 
> I think the proposaled framework/abstraction layer is NOT just for 
> code sharing. We need to dynamically load the proper hotkey/video driver

I have read three driver, asus, toshiba, and ibm.
These are differ each other.

asus:    notify key event by 'Notify(event num)'
toshiba: polling some device/method for get key event.
ibm:     notify key event by 'Notify(DEVICE_NOTIFY)' then get key by some method.
panasonic: same as ibm but device and method name is differ.

This means difficulties of sharing driver code. 

Dynamic loading is nice propose.
with this code, i can determine which is that machine.

	static struct acpi_table_header *dsdt_info;
        status = acpi_get_table(ACPI_TABLE_DSDT, 1, &dsdt);
        if (ACPI_FAILURE(status))
                /* error */

	dsdt_info = (struct acpi_table_header *) dsdt.pointer;
	chek_which_oem_and_invoke_proper_driver (dsdt->oem_id);

Wrapper driver only need to know oem_ids and driver name mapping.


Hiroshi Miura  --- http://www.da-cha.org/  --- miura-yiisDzvROlQdnm+yROfE0A@public.gmane.org
NTTDATA Corp. OpenSource Software Center. --- miurahr-3MafRgGXt7BL9jVzuh4AOg@public.gmane.org 
NTTDATA Intellilink Corp. OpenSource Engineering Dev. -- miurahr-w0OK63jvRlAuJ+9fw/WgBHgSJqDPrsil@public.gmane.org
Key fingerprint = 9117 9407 5684 FBF1 4063  15B4 401D D077 04AB 8617



-------------------------------------------------------
SF.Net email is sponsored by Shop4tech.com-Lowest price on Blank Media
100pk Sonic DVD-R 4x for only $29 -100pk Sonic DVD+R for only $33
Save 50% off Retail on Ink & Toner - Free Shipping and Free Gift.
http://www.shop4tech.com/z/Inkjet_Cartridges/9_108_r285

Re: hotkey/video framework [was: ibm-acpi-0.2]

[Len Brown]

On Tue, 2004-08-17 at 19:55, Hiroshi Miura wrote:
> Hi,
> 
> At Tue, 17 Aug 2004 17:15:17 +0800,
> Yu, Luming wrote:
> > 
> > >> 
> > >> 'Fn key combination' is common on machines,
> > >> so I think we need some abstraction layer or framework on acpi core.
> > >
> > >One possibility is to just agree on the proc file format and ACPI
> > >events for the common features,
> 
> I think it's good start. 

i agree.

> > > then have each driver implement them
> > >separately. This would probably be simpler than trying to come up with
> > >some sort of a wrapper framework as the code involved is fairly simple
> > >and there probably isn't much we can share. Then again, there might
> > >be, I haven't looked.
> > >
> > 
> > I think the proposaled framework/abstraction layer is NOT just for 
> > code sharing. We need to dynamically load the proper hotkey/video driver
> 
> I have read three driver, asus, toshiba, and ibm.
> These are differ each other.
> 
> asus:    notify key event by 'Notify(event num)'
> toshiba: polling some device/method for get key event.
> ibm:     notify key event by 'Notify(DEVICE_NOTIFY)' then get key by some method.
> panasonic: same as ibm but device and method name is differ.
> 
> This means difficulties of sharing driver code. 

Lots of tinkering has been done in this space.
here's the top google hit:
http://www.tuxmobil.org/Mobile-Guide.db/mobile-guide-p2c1s8-ext-keys.html

I'm confident that the platforms will all have different methods to
actually grab the hotkey events, because ACPI doesn't standardize that
part.  Some will not use ACPI at all to get the hotkey events, but for
those that do, I want to make sure that the ACPI interfaces are standard
and sufficient to support somebody building a platform specific driver. 
More important is the stuff that the event handlers call for sending
events to user space, or video control within the kernel -- this should
be shared and not duplicated.

> Dynamic loading is nice propose.
> with this code, i can determine which is that machine.
> 
> 	static struct acpi_table_header *dsdt_info;
>         status = acpi_get_table(ACPI_TABLE_DSDT, 1, &dsdt);
>         if (ACPI_FAILURE(status))
>                 /* error */
> 
> 	dsdt_info = (struct acpi_table_header *) dsdt.pointer;
> 	chek_which_oem_and_invoke_proper_driver (dsdt->oem_id);
> 
> Wrapper driver only need to know oem_ids and driver name mapping.


Your panasonic driver looked like it got it right by using
acpi_bus_register_driver() and a HID.  I don't understand
why mess that up by looking at table headers?

-Len




-------------------------------------------------------
SF.Net email is sponsored by Shop4tech.com-Lowest price on Blank Media
100pk Sonic DVD-R 4x for only $29 -100pk Sonic DVD+R for only $33
Save 50% off Retail on Ink & Toner - Free Shipping and Free Gift.
http://www.shop4tech.com/z/Inkjet_Cartridges/9_108_r285