From: Jesse Barnes <jbarnes@engr.sgi.com>
To: acpi-devel@lists.sourceforge.net
Cc: Alex Williamson <alex.williamson@hp.com>,
"Martin J. Bligh" <mbligh@aracnet.com>,
"Randy.Dunlap" <rddunlap@osdl.org>, Paul Jackson <pj@sgi.com>,
haveblue@us.ibm.com, linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [ACPI] Re: [PATCH] cleanup ACPI numa warnings
Date: Fri, 20 Aug 2004 15:22:41 -0400 [thread overview]
Message-ID: <200408201522.41334.jbarnes@engr.sgi.com> (raw)
In-Reply-To: <1093028151.4993.42.camel@tdi>
On Friday, August 20, 2004 2:55 pm, Alex Williamson wrote:
> I'm not sure where we stand on this, sorry for the delay. To recap,
> the first patch I submitted cleaned up the original functions, but moved
> the ugliness up into multi-line macros. People didn't like the macros
> and suggested static inlines. However, static inlines don't work for
> this application because the debug print needs state setup by the
> ACPI_FUNCTION_NAME call. IMHO, it's not worth setting up that state in
> the static inline function for this little bit of cleanup.
>
> So, I think we left it at nobody liked the macros and static inlines
> don't work. General unhappiness. Below is a patch that doesn't attempt
> to cleanup the original code, it just adds the #ifdefs and range
> checking w/ no macros. Does this look better? Below is the original
> submit comment outlining the goal. Thanks,
Yes please.
Jesse
next prev parent reply other threads:[~2004-08-20 19:22 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-08-05 20:46 [PATCH] cleanup ACPI numa warnings Alex Williamson
2004-08-05 21:01 ` Dave Hansen
2004-08-05 21:25 ` Alex Williamson
2004-08-06 3:35 ` Martin J. Bligh
2004-08-06 3:50 ` [ACPI] " Randy.Dunlap
[not found] ` <20040805205059.3fb67b71.rddunlap-3NddpPZAyC0@public.gmane.org>
2004-08-07 17:57 ` Paul Jackson
2004-08-08 21:36 ` [ACPI] " Randy.Dunlap
[not found] ` <20040808143631.7c18cae9.rddunlap-3NddpPZAyC0@public.gmane.org>
2004-08-09 2:53 ` Martin J. Bligh
2004-08-20 18:55 ` Alex Williamson
2004-08-20 19:22 ` Jesse Barnes [this message]
2004-08-09 4:19 ` Alex Williamson
[not found] ` <1092025184.2292.26.camel-bi+AKbBUZKY6gyzm1THtWbp2dZbC/Bob@public.gmane.org>
2004-08-09 4:52 ` Dave Hansen
2004-08-09 5:10 ` Alex Williamson
[not found] ` <1092028238.2211.5.camel-bi+AKbBUZKY6gyzm1THtWbp2dZbC/Bob@public.gmane.org>
2004-08-09 5:44 ` Dave Hansen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200408201522.41334.jbarnes@engr.sgi.com \
--to=jbarnes@engr.sgi.com \
--cc=acpi-devel@lists.sourceforge.net \
--cc=alex.williamson@hp.com \
--cc=haveblue@us.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mbligh@aracnet.com \
--cc=pj@sgi.com \
--cc=rddunlap@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox