From: Bjorn Helgaas <bjorn.helgaas-VXdhtT5mjnY@public.gmane.org>
To: acpi-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org
Cc: "S,
Naveen B" <naveen.b.s-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>,
Dave Hansen <haveblue-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>,
lhms
<lhms-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org>,
"Tolentino,
Matthew E"
<matthew.e.tolentino-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
Subject: Re: [Lhms-devel] [PATCH] ACPI based Memory Hotplug DriverPatch
Date: Fri, 10 Sep 2004 09:33:39 -0600 [thread overview]
Message-ID: <200409100933.40293.bjorn.helgaas@hp.com> (raw)
In-Reply-To: <FEB6C4E97F6CAF41978FB2059D5454180F37F3-OkeUvhg1trkFyVwBAnZdSLfspsVTdybXVpNB7YpNyf8@public.gmane.org>
On Friday 10 September 2004 7:01 am, S, Naveen B wrote:
> > If it ends up that all of the callers of remove_memory() prefer to give
> > start and end addresses, we'll probably change the calling convention at
> > some point. Whatever is most natural.
>
> Looks good. This should avoid usage of +1.
IMHO an "address, size" convention is much nicer than "start, end".
I don't like "start, end" because (1) there's always the ambiguity of
whether the last byte is included, and (2) zero-length ranges look funny
(e.g., "0x0,0xffff").
"address, size" avoids both problems, and is already used by tons of
kernel interfaces like ioremap(), the dma interfaces, verify_area(),
memset(), etc, etc.
-------------------------------------------------------
This SF.Net email is sponsored by: YOU BE THE JUDGE. Be one of 170
Project Admins to receive an Apple iPod Mini FREE for your judgement on
who ports your project to Linux PPC the best. Sponsored by IBM.
Deadline: Sept. 13. Go here: http://sf.net/ppc_contest.php
next prev parent reply other threads:[~2004-09-10 15:33 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-09-10 13:01 [Lhms-devel] [PATCH] ACPI based Memory Hotplug DriverPatch S, Naveen B
[not found] ` <FEB6C4E97F6CAF41978FB2059D5454180F37F3-OkeUvhg1trkFyVwBAnZdSLfspsVTdybXVpNB7YpNyf8@public.gmane.org>
2004-09-10 15:33 ` Bjorn Helgaas [this message]
-- strict thread matches above, loose matches on Subject: below --
2004-09-13 5:46 S, Naveen B
2004-09-10 12:49 S, Naveen B
2004-09-09 18:28 Tolentino, Matthew E
[not found] ` <D36CE1FCEFD3524B81CA12C6FE5BCAB007A6C485-oCDej+MBycNZtRGVdHMbwrfspsVTdybXVpNB7YpNyf8@public.gmane.org>
2004-09-09 18:33 ` Dave Hansen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200409100933.40293.bjorn.helgaas@hp.com \
--to=bjorn.helgaas-vxdhtt5mjny@public.gmane.org \
--cc=acpi-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org \
--cc=haveblue-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org \
--cc=lhms-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org \
--cc=matthew.e.tolentino-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
--cc=naveen.b.s-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox