From mboxrd@z Thu Jan 1 00:00:00 1970 From: Keshavamurthy Anil S Subject: Re: [ACPI] PATCH-ACPI based CPU hotplug[2/6]-ACPI Eject interface support Date: Mon, 27 Sep 2004 09:53:48 -0700 Sender: linux-ia64-owner@vger.kernel.org Message-ID: <20040927095348.A29594@unix-os.sc.intel.com> References: <20040920092520.A14208@unix-os.sc.intel.com> <200409201812.45933.dtor_core@ameritech.net> <20040924162823.B27778@unix-os.sc.intel.com> <200409270112.29422.dtor_core@ameritech.net> Reply-To: Keshavamurthy Anil S Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: Content-Disposition: inline In-Reply-To: <200409270112.29422.dtor_core@ameritech.net>; from dtor_core@ameritech.net on Mon, Sep 27, 2004 at 01:12:28AM -0500 To: Dmitry Torokhov Cc: Keshavamurthy Anil S , Len Brown , acpi-devel@lists.sourceforge.net, LHNS list , Linux IA64 , Linux Kernel List-Id: linux-acpi@vger.kernel.org On Mon, Sep 27, 2004 at 01:12:28AM -0500, Dmitry Torokhov wrote: > On Friday 24 September 2004 06:28 pm, Keshavamurthy Anil S wrote: > > +typedef void acpi_device_sysfs_files(struct kobject *, > > +=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0= =A0=A0=A0=A0=A0=A0=A0=A0=A0const struct attribute *); > > + > > +static void setup_sys_fs_device_files(struct acpi_device *dev, > > +=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0acpi_device_sysfs_fil= es *func); > > + > > +#define create_sysfs_device_files(dev)=A0\ > > +=A0=A0=A0=A0=A0=A0=A0setup_sys_fs_device_files(dev, (acpi_device_s= ysfs_files *)&sysfs_create_file) > > +#define remove_sysfs_device_files(dev)=A0\ > > +=A0=A0=A0=A0=A0=A0=A0setup_sys_fs_device_files(dev, (acpi_device_s= ysfs_files *)&sysfs_remove_file) >=20 >=20 > Hi Anil, >=20 > It looks very nice except for the part above. I am really confused wh= at the > purpose of this code is... It looks like it just complicates things? Hi Dmitry, I just wanted to have a single function i.e setup_sys_fs_device_files(= ) for both creating and removing sysfs files. So I have #defined create_sysfs_devi= ce_files() and=20 remove_sysfs_device_files() and one of the arguments to the setup_sys_f= s_device_files() is a function pointer, i.e for one it takes sysfs_create_file and for o= ther it takes sysfs_remove_file. Having single function for creating and removing sysfs files make it ea= sy=20 from the maintaince perspective, as oppose to remember to code for remo= ve=20 as well when one adds the new file. thanks, Anil - To unsubscribe from this list: send the line "unsubscribe linux-ia64" i= n the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html