From: Pavel Machek <pavel-+ZI9xUNit7I@public.gmane.org>
To: "Li, Shaohua" <shaohua.li-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
Cc: ML ACPI-devel
<acpi-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org>
Subject: Re: save/restore sysdev - re:2.6.9 S4: clock not updated after resume
Date: Fri, 29 Oct 2004 12:18:57 +0200 [thread overview]
Message-ID: <20041029101857.GA1007@elf.ucw.cz> (raw)
In-Reply-To: <16A54BF5D6E14E4D916CE26C9AD3057563CCE1-4yWAQGcml66iAffOGbnezLfspsVTdybXVpNB7YpNyf8@public.gmane.org>
Hi!
> The patch is useless. The sysdev suspend/resume isn't invoked by swsusp,
> as Bjorn has mentioned before.
> http://marc.theaimsgroup.com/?l=linux-kernel&m=109753613422952&w=2
This patch should add sysdev suspend/resume. Can you verify it helps
for you?
Pavel
--- clean/kernel/power/disk.c 2004-10-01 00:30:32.000000000 +0200
+++ linux/kernel/power/disk.c 2004-10-29 11:57:26.000000000 +0200
@@ -102,6 +116,7 @@
static void finish(void)
{
+ sysdev_resume();
device_resume();
platform_finish();
enable_nonboot_cpus();
@@ -133,8 +148,12 @@
free_some_memory();
disable_nonboot_cpus();
- if ((error = device_suspend(PM_SUSPEND_DISK)))
+ if ((error = device_suspend(PMSG_SUSPEND_DISK))) {
+ printk("Some devices failed to suspend\n");
goto Finish;
+ }
+
+ sysdev_suspend(PMSG_SUSPEND_DISK);
return 0;
Finish:
--- clean/kernel/power/main.c 2004-10-01 00:30:32.000000000 +0200
+++ linux/kernel/power/main.c 2004-10-29 11:56:59.000000000 +0200
@@ -825,6 +812,7 @@
int swsusp_write(void)
{
int error;
+ sysdev_resume();
device_resume();
lock_swapdevices();
error = write_suspend_image();
--
People were complaining that M$ turns users into beta-testers...
...jr ghea gurz vagb qrirybcref, naq gurl frrz gb yvxr vg gung jnl!
-------------------------------------------------------
This Newsletter Sponsored by: Macrovision
For reliable Linux application installations, use the industry's leading
setup authoring tool, InstallShield X. Learn more and evaluate
today. http://clk.atdmt.com/MSI/go/ins0030000001msi/direct/01/
next prev parent reply other threads:[~2004-10-29 10:18 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-10-25 6:16 save/restore sysdev - re:2.6.9 S4: clock not updated after resume Li, Shaohua
[not found] ` <16A54BF5D6E14E4D916CE26C9AD3057563CCE1-4yWAQGcml66iAffOGbnezLfspsVTdybXVpNB7YpNyf8@public.gmane.org>
2004-10-29 10:18 ` Pavel Machek [this message]
-- strict thread matches above, loose matches on Subject: below --
2004-11-04 7:08 Li, Shaohua
[not found] ` <16A54BF5D6E14E4D916CE26C9AD30575796CEB-4yWAQGcml66iAffOGbnezLfspsVTdybXVpNB7YpNyf8@public.gmane.org>
2004-11-16 12:26 ` Pavel Machek
[not found] ` <20041116122648.GB1013-I/5MKhXcvmPrBKCeMvbIDA@public.gmane.org>
2004-11-17 8:19 ` Li Shaohua
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20041029101857.GA1007@elf.ucw.cz \
--to=pavel-+zi9xunit7i@public.gmane.org \
--cc=acpi-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org \
--cc=shaohua.li-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox